Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38465

ECR plugin isn't compatible with credentials managed by folder plugin

    Details

    • Similar Issues:

      Description

      If you define your credentials at a folder level the ECR plugin cannot access to them.

      Looking at https://github.com/jenkinsci/amazon-ecr-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java#L76, ecr plugin only look for credentials from Jenkins.instance context, not within current folder.

        Attachments

          Issue Links

            Activity

            aheritier Arnaud Héritier created issue -
            aheritier Arnaud Héritier made changes -
            Field Original Value New Value
            Assignee Nicolas De Loof [ ndeloof ]
            stephenconnolly Stephen Connolly made changes -
            Component/s credentials-plugin [ 16523 ]
            ifernandezcalvo Ivan Fernandez Calvo made changes -
            Assignee Ivan Fernandez Calvo [ ifernandezcalvo ]
            ifernandezcalvo Ivan Fernandez Calvo made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ifernandezcalvo Ivan Fernandez Calvo made changes -
            Remote Link This issue links to "PR (Web Link)" [ 14922 ]
            ifernandezcalvo Ivan Fernandez Calvo made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ivan Fernandez Calvo
            Path:
            src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java
            src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java
            http://jenkins-ci.org/commit/amazon-ecr-plugin/7572ce2975f9c5a8ebc8a2509fd980dd6a979dd9
            Log:
            JENKINS-38465 it now search credentials also into folders

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Fernandez Calvo Path: src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java http://jenkins-ci.org/commit/amazon-ecr-plugin/7572ce2975f9c5a8ebc8a2509fd980dd6a979dd9 Log: JENKINS-38465 it now search credentials also into folders
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ivan Fernandez Calvo
            Path:
            src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java
            src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java
            http://jenkins-ci.org/commit/amazon-ecr-plugin/6eee172bd9cdc2351bed9cc32228cf8ebbeaa63a
            Log:
            Merge pull request #7 from kuisathaverat/JENKINS-38465

            [FIX JENKINS-38465] it now search credentials also into folders

            Compare: https://github.com/jenkinsci/amazon-ecr-plugin/compare/1e9f9237825d...6eee172bd9cd

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Fernandez Calvo Path: src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java http://jenkins-ci.org/commit/amazon-ecr-plugin/6eee172bd9cdc2351bed9cc32228cf8ebbeaa63a Log: Merge pull request #7 from kuisathaverat/ JENKINS-38465 [FIX JENKINS-38465] it now search credentials also into folders Compare: https://github.com/jenkinsci/amazon-ecr-plugin/compare/1e9f9237825d...6eee172bd9cd
            ifernandezcalvo Ivan Fernandez Calvo made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-1470 (Web Link)" [ 18685 ]

              People

              • Assignee:
                ifernandezcalvo Ivan Fernandez Calvo
                Reporter:
                aheritier Arnaud Héritier
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: