Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38691

Sub-par write performance in JNLPv4 NIONetwork layer

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Won't Fix
    • Component/s: remoting
    • Labels:
      None
    • Similar Issues:

      Description

      The JNLP v2 protocol has a sub par write implementation if there is more than one buffers worth of data to be written to the network.
      The current implementation writes one buffers worth and then exits - waiting for another callback from the selector before writing another buffer.
      The code should write as much data as possible before returning back.

      see https://github.com/jenkinsci/remoting/blob/c3e675c9f1dc29a8fd99eca191c1ce1e5ebb2a7e/src/main/java/org/jenkinsci/remoting/protocol/impl/NIONetworkLayer.java#L191-L227

        Attachments

          Issue Links

            Activity

            Hide
            teilo James Nord added a comment - - edited

            Stephen Connolly looked at this and tried an implementation - but it did not improve performance and used more heap

            Show
            teilo James Nord added a comment - - edited Stephen Connolly looked at this and tried an implementation - but it did not improve performance and used more heap

              People

              • Assignee:
                teilo James Nord
                Reporter:
                teilo James Nord
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: