Details

    • Similar Issues:

      Description

      Now that 1.2.0 of the vault-java-driver is available, it would be excellent if this plugin added support for github auth.

      Would a PR be welcome for this change? Willing to dig into the plugin and work on adding github support.

        Attachments

          Activity

          garadox Gareth Harcombe-Minson created issue -
          garadox Gareth Harcombe-Minson made changes -
          Field Original Value New Value
          Issue Type New Feature [ 2 ] Improvement [ 4 ]
          Hide
          ptierno Peter Tierno added a comment -

          Gareth Harcombe-Minson Yes I am definitely open to PR's

          Show
          ptierno Peter Tierno added a comment - Gareth Harcombe-Minson Yes I am definitely open to PR's
          ptierno Peter Tierno made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Peter Tierno
          Path:
          src/main/java/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential.java
          src/main/resources/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential/credentials.jelly
          http://jenkins-ci.org/commit/hashicorp-vault-plugin/b93ac10a683d8b5fb33d6788388311198a8b8373
          Log:
          JENKINS-38939 add VaultGithubTokenCredential to authenticate to vault with a Github personal access token

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Peter Tierno Path: src/main/java/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential.java src/main/resources/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential/credentials.jelly http://jenkins-ci.org/commit/hashicorp-vault-plugin/b93ac10a683d8b5fb33d6788388311198a8b8373 Log: JENKINS-38939 add VaultGithubTokenCredential to authenticate to vault with a Github personal access token
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Peter Tierno
          Path:
          src/main/java/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential.java
          src/main/resources/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential/credentials.jelly
          http://jenkins-ci.org/commit/hashicorp-vault-plugin/94d618ceb83930b091ec465c4be539ab55243102
          Log:
          Merge pull request #10 from ptierno/JENKINS-38939

          JENKINS-38939 add VaultGithubTokenCredential to authenticate to vau…

          Compare: https://github.com/jenkinsci/hashicorp-vault-plugin/compare/ee8acbddaff1...94d618ceb839

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Peter Tierno Path: src/main/java/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential.java src/main/resources/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential/credentials.jelly http://jenkins-ci.org/commit/hashicorp-vault-plugin/94d618ceb83930b091ec465c4be539ab55243102 Log: Merge pull request #10 from ptierno/ JENKINS-38939 JENKINS-38939 add VaultGithubTokenCredential to authenticate to vau… Compare: https://github.com/jenkinsci/hashicorp-vault-plugin/compare/ee8acbddaff1...94d618ceb839
          ptierno Peter Tierno made changes -
          Summary Update to vault-java-driver to 1.2.0 and support github token auth Add support github token auth
          Hide
          ptierno Peter Tierno added a comment - - edited

          Added in 2.1.0

          Show
          ptierno Peter Tierno added a comment - - edited Added in 2.1.0
          ptierno Peter Tierno made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Done [ 10000 ]

            People

            • Assignee:
              ptierno Peter Tierno
              Reporter:
              garadox Gareth Harcombe-Minson
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: