Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39026

Add a ViewJobFilter specialized for filtering by Branch

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      A common requirement for multibranch plugins is to create specialized sub-views that are filtered by the different types of branch. Given that some plugins have half-complete hacky implementations of this, we should provide a correct base implementation so that plugins can have a simpler path to doing the correct thing.

      (note; half complete because it assumes that it only ever will be applied to a WorkflowJob rather than correctly navigating to the BranchProjectFactory and then using that to access the Branch instance... thus the utility of that class is compromised relative to what it should be)

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/SimpleViewBranchFilter.java
            http://jenkins-ci.org/commit/branch-api-plugin/ee7887d4e1767c6a2d9184e53fa28b475ddb6ad7
            Log:
            JENKINS-39026 Add an abstract base class for simple ViewBranchFilter

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/SimpleViewBranchFilter.java http://jenkins-ci.org/commit/branch-api-plugin/ee7887d4e1767c6a2d9184e53fa28b475ddb6ad7 Log: JENKINS-39026 Add an abstract base class for simple ViewBranchFilter
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBranchFilter.java
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubPullRequestFilter.java
            src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties
            http://jenkins-ci.org/commit/github-branch-source-plugin/c9bd727e64a221ebdcd85fd42ed336233435ea3d
            Log:
            [JENKINS-39026 Follow-up] Add ViewBranchFilter implementations for PRs and GitHub branches

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBranchFilter.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubPullRequestFilter.java src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties http://jenkins-ci.org/commit/github-branch-source-plugin/c9bd727e64a221ebdcd85fd42ed336233435ea3d Log: [JENKINS-39026 Follow-up] Add ViewBranchFilter implementations for PRs and GitHub branches
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBranchFilter.java
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubPullRequestFilter.java
            src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties
            http://jenkins-ci.org/commit/github-branch-source-plugin/7872bf2eea07ee7a6c9e54c32bc5d63f8eabdbbe
            Log:
            [JENKINS-39026 Follow-up] Add ViewBranchFilter implementations for PRs and GitHub branches

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBranchFilter.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubPullRequestFilter.java src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties http://jenkins-ci.org/commit/github-branch-source-plugin/7872bf2eea07ee7a6c9e54c32bc5d63f8eabdbbe Log: [JENKINS-39026 Follow-up] Add ViewBranchFilter implementations for PRs and GitHub branches
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/SimpleViewBranchFilter.java
            http://jenkins-ci.org/commit/branch-api-plugin/ee698b5c27aed55a2644d1a55031b4334085db63
            Log:
            Merge pull request #53 from jenkinsci/jenkins-39026

            [FIXED JENKINS-39026] Add an abstract base class for simple ViewBranchFilter

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/3645881cb775...ee698b5c27ae

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/SimpleViewBranchFilter.java http://jenkins-ci.org/commit/branch-api-plugin/ee698b5c27aed55a2644d1a55031b4334085db63 Log: Merge pull request #53 from jenkinsci/jenkins-39026 [FIXED JENKINS-39026] Add an abstract base class for simple ViewBranchFilter Compare: https://github.com/jenkinsci/branch-api-plugin/compare/3645881cb775...ee698b5c27ae
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBranchFilter.java
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubPullRequestFilter.java
            src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties
            http://jenkins-ci.org/commit/github-branch-source-plugin/03f37a24ca969a22ffdfe51c3c7742da15bab1f0
            Log:
            Merge pull request #84 from jenkinsci/jenkins-39026-follow-up

            [JENKINS-39026 Follow-up] Add ViewBranchFilter implementations for PRs and GitHub branches

            Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/4fa015f744c4...03f37a24ca96

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBranchFilter.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubPullRequestFilter.java src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties http://jenkins-ci.org/commit/github-branch-source-plugin/03f37a24ca969a22ffdfe51c3c7742da15bab1f0 Log: Merge pull request #84 from jenkinsci/jenkins-39026-follow-up [JENKINS-39026 Follow-up] Add ViewBranchFilter implementations for PRs and GitHub branches Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/4fa015f744c4...03f37a24ca96

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: