Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39132

No comments to Gerrit 2.13.1 for Change Merged trigger

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: gerrit-trigger-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.26, gerrit-trigger-plugin 2.22.0, Gerrit 2.13.1
    • Similar Issues:

      Description

      After upgrading of Gerrit from 2.12 to 2.13.1 and Jenkins to 2.26, we have lost comments for Change Merged triggered builds. We have both "Patchset created" and "Change Merged" triggers configured. "Patchset created" trigger votes Verified=1 and Code-Review=1, but "Change Merged" trigger votes Verified=0 and Code-Review=0 and Gerrit refuses this review (comment) with error "change is closed".

      Gerrit log
      [2016-10-20 08:03:05,924 +0200] 62f9143f jenkins a/4 LOGIN FROM 10.20.220.21
      [2016-10-20 08:03:06,298 +0200] 62f9143f jenkins a/4 gerrit.review.120,1.--message.Build Successful
      
      https://*****/25/ : SUCCESS.--label.Build-check=1.--code-review.1 1ms 85ms 0
      [2016-10-20 08:03:06,472 +0200] 62f9143f jenkins a/4 LOGOUT
      
      -----------------------------
      [2016-10-20 08:04:08,437 +0200] 623ef439 jenkins a/4 LOGIN FROM 10.20.220.21
      [2016-10-20 08:04:08,733 +0200] 623ef439 jenkins a/4 gerrit.review.120,1.--message.Build Successful
      
      https://*****/26/ : SUCCESS.--label.Build-check=0.--code-review.0 1ms 9ms 1
      [2016-10-20 08:04:08,921 +0200] 623ef439 jenkins a/4 LOGOUT
      
      Jenkins log
      Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onTriggered
      INFO: Project [Test] triggered by Gerrit: [[ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1]]
      Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.EventListener schedule
      INFO: Project Test Build Scheduled: true By event: 120/1
      Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
      INFO: Gerrit build [Test #25] Started for cause: [GerritCause: [ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1] silent: false].
      Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
      INFO: MemoryStatus:
        Project/Build: [Test]: [#25: null] Completed: false
      
      Oct 20, 2016 8:03:05 AM hudson.model.Run execute
      INFO: Test #25 main build action completed: SUCCESS
      Oct 20, 2016 8:03:05 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener allBuildsCompleted
      INFO: All Builds are completed for cause: GerritCause: [ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1] silent: false
      Oct 20, 2016 8:03:05 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier buildCompleted
      INFO: Notifying BuildCompleted to gerrit: gerrit review 120,1 --message 'Build Successful 
      
      https://*****/25/ : SUCCESS' --label Build-check=1 --code-review 1
      Oct 20, 2016 8:04:00 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onTriggered
      INFO: Project [Test] triggered by Gerrit: [com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77]
      Oct 20, 2016 8:04:00 AM com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.EventListener schedule
      INFO: Project Test Build Scheduled: true By event: 120/1
      Oct 20, 2016 8:04:06 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
      INFO: Gerrit build [Test #26] Started for cause: [GerritCause: com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77 silent: false].
      Oct 20, 2016 8:04:06 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
      INFO: MemoryStatus:
        Project/Build: [Test]: [#26: null] Completed: false
      
      Oct 20, 2016 8:04:07 AM hudson.model.Run execute
      INFO: Test #26 main build action completed: SUCCESS
      Oct 20, 2016 8:04:07 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener allBuildsCompleted
      INFO: All Builds are completed for cause: GerritCause: com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77 silent: false
      Oct 20, 2016 8:04:07 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier buildCompleted
      INFO: Notifying BuildCompleted to gerrit: gerrit review 120,1 --message 'Build Successful 
      
      https://*****/26/ : SUCCESS' --label Build-check=0 --code-review 0
      Oct 20, 2016 8:04:08 AM com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob sendCommand
      SEVERE: Could not run command gerrit review 120,1 --message 'Build Successful 
      
      https://*****/26/ : SUCCESS' --label Build-check=0 --code-review 0
      java.io.IOException: Error during sending command
      	at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:118)
      	at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand(AbstractSendCommandJob.java:79)
      	at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier.buildCompleted(GerritNotifier.java:118)
      	at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.job.ssh.BuildCompletedCommandJob.run(BuildCompletedCommandJob.java:71)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
      	at java.util.concurrent.FutureTask.run(Unknown Source)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
      	at java.lang.Thread.run(Unknown Source)
      Caused by: com.sonymobile.tools.gerrit.gerritevents.ssh.SshException: error: fatal: change is closed
      
      fatal: one or more reviews failed; review output above (1)
      	at com.sonymobile.tools.gerrit.gerritevents.ssh.SshConnectionImpl.executeCommand(SshConnectionImpl.java:254)
      	at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:116)
      	... 8 more
      

        Attachments

          Activity

          engy Jiří Engelthaler created issue -
          engy Jiří Engelthaler made changes -
          Field Original Value New Value
          Summary No comments to gerrit for Change Merged trigger No comments to Gerrit 2.13.1 for Change Merged trigger
          engy Jiří Engelthaler made changes -
          Description After upgrading of Gerrit from 2.12 to 2.13.1, we have lost comments for Change Merged triggered builds. We have both "Patchset created" and "Change Merged" triggers configured. "Patchset created" trigger votes Verified=1 and Code-Review=1, but "Change Merged" trigger votes Verified=0 and Code-Review=0 and Gerrit refuses this review (comment) with error "change is closed".

          {code:title=Gerrit log}
          [2016-10-20 08:03:05,924 +0200] 62f9143f jenkins a/4 LOGIN FROM 10.20.220.21
          [2016-10-20 08:03:06,298 +0200] 62f9143f jenkins a/4 gerrit.review.120,1.--message.Build Successful

          https://*****/25/ : SUCCESS.--label.Build-check=1.--code-review.1 1ms 85ms 0
          [2016-10-20 08:03:06,472 +0200] 62f9143f jenkins a/4 LOGOUT

          -----------------------------
          [2016-10-20 08:04:08,437 +0200] 623ef439 jenkins a/4 LOGIN FROM 10.20.220.21
          [2016-10-20 08:04:08,733 +0200] 623ef439 jenkins a/4 gerrit.review.120,1.--message.Build Successful

          https://*****/26/ : SUCCESS.--label.Build-check=0.--code-review.0 1ms 9ms 1
          [2016-10-20 08:04:08,921 +0200] 623ef439 jenkins a/4 LOGOUT
          {code}


          {code:none|title=Jenkins log}
          Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onTriggered
          INFO: Project [Test] triggered by Gerrit: [[ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1]]
          Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.EventListener schedule
          INFO: Project Test Build Scheduled: true By event: 120/1
          Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
          INFO: Gerrit build [Test #25] Started for cause: [GerritCause: [ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1] silent: false].
          Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
          INFO: MemoryStatus:
            Project/Build: [Test]: [#25: null] Completed: false

          Oct 20, 2016 8:03:05 AM hudson.model.Run execute
          INFO: Test #25 main build action completed: SUCCESS
          Oct 20, 2016 8:03:05 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener allBuildsCompleted
          INFO: All Builds are completed for cause: GerritCause: [ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1] silent: false
          Oct 20, 2016 8:03:05 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier buildCompleted
          INFO: Notifying BuildCompleted to gerrit: gerrit review 120,1 --message 'Build Successful

          https://*****/25/ : SUCCESS' --label Build-check=1 --code-review 1
          Oct 20, 2016 8:04:00 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onTriggered
          INFO: Project [Test] triggered by Gerrit: [com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77]
          Oct 20, 2016 8:04:00 AM com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.EventListener schedule
          INFO: Project Test Build Scheduled: true By event: 120/1
          Oct 20, 2016 8:04:06 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
          INFO: Gerrit build [Test #26] Started for cause: [GerritCause: com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77 silent: false].
          Oct 20, 2016 8:04:06 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
          INFO: MemoryStatus:
            Project/Build: [Test]: [#26: null] Completed: false

          Oct 20, 2016 8:04:07 AM hudson.model.Run execute
          INFO: Test #26 main build action completed: SUCCESS
          Oct 20, 2016 8:04:07 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener allBuildsCompleted
          INFO: All Builds are completed for cause: GerritCause: com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77 silent: false
          Oct 20, 2016 8:04:07 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier buildCompleted
          INFO: Notifying BuildCompleted to gerrit: gerrit review 120,1 --message 'Build Successful

          https://*****/26/ : SUCCESS' --label Build-check=0 --code-review 0
          Oct 20, 2016 8:04:08 AM com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob sendCommand
          SEVERE: Could not run command gerrit review 120,1 --message 'Build Successful

          https://*****/26/ : SUCCESS' --label Build-check=0 --code-review 0
          java.io.IOException: Error during sending command
          at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:118)
          at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand(AbstractSendCommandJob.java:79)
          at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier.buildCompleted(GerritNotifier.java:118)
          at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.job.ssh.BuildCompletedCommandJob.run(BuildCompletedCommandJob.java:71)
          at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
          at java.util.concurrent.FutureTask.run(Unknown Source)
          at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
          at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
          at java.lang.Thread.run(Unknown Source)
          Caused by: com.sonymobile.tools.gerrit.gerritevents.ssh.SshException: error: fatal: change is closed

          fatal: one or more reviews failed; review output above (1)
          at com.sonymobile.tools.gerrit.gerritevents.ssh.SshConnectionImpl.executeCommand(SshConnectionImpl.java:254)
          at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:116)
          ... 8 more
          {code}
          After upgrading of Gerrit from 2.12 to 2.13.1 and Jenkins to 2.26, we have lost comments for Change Merged triggered builds. We have both "Patchset created" and "Change Merged" triggers configured. "Patchset created" trigger votes Verified=1 and Code-Review=1, but "Change Merged" trigger votes Verified=0 and Code-Review=0 and Gerrit refuses this review (comment) with error "change is closed".

          {code:title=Gerrit log}
          [2016-10-20 08:03:05,924 +0200] 62f9143f jenkins a/4 LOGIN FROM 10.20.220.21
          [2016-10-20 08:03:06,298 +0200] 62f9143f jenkins a/4 gerrit.review.120,1.--message.Build Successful

          https://*****/25/ : SUCCESS.--label.Build-check=1.--code-review.1 1ms 85ms 0
          [2016-10-20 08:03:06,472 +0200] 62f9143f jenkins a/4 LOGOUT

          -----------------------------
          [2016-10-20 08:04:08,437 +0200] 623ef439 jenkins a/4 LOGIN FROM 10.20.220.21
          [2016-10-20 08:04:08,733 +0200] 623ef439 jenkins a/4 gerrit.review.120,1.--message.Build Successful

          https://*****/26/ : SUCCESS.--label.Build-check=0.--code-review.0 1ms 9ms 1
          [2016-10-20 08:04:08,921 +0200] 623ef439 jenkins a/4 LOGOUT
          {code}


          {code:none|title=Jenkins log}
          Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onTriggered
          INFO: Project [Test] triggered by Gerrit: [[ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1]]
          Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.EventListener schedule
          INFO: Project Test Build Scheduled: true By event: 120/1
          Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
          INFO: Gerrit build [Test #25] Started for cause: [GerritCause: [ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1] silent: false].
          Oct 20, 2016 8:03:03 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
          INFO: MemoryStatus:
            Project/Build: [Test]: [#25: null] Completed: false

          Oct 20, 2016 8:03:05 AM hudson.model.Run execute
          INFO: Test #25 main build action completed: SUCCESS
          Oct 20, 2016 8:03:05 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener allBuildsCompleted
          INFO: All Builds are completed for cause: GerritCause: [ManualPatchsetCreated Change: Change-Id for #120: Ib30b882237ecc6e6e55c26cd0763862a81e4ab9d PatchSet: PatchSet: 1] silent: false
          Oct 20, 2016 8:03:05 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier buildCompleted
          INFO: Notifying BuildCompleted to gerrit: gerrit review 120,1 --message 'Build Successful

          https://*****/25/ : SUCCESS' --label Build-check=1 --code-review 1
          Oct 20, 2016 8:04:00 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onTriggered
          INFO: Project [Test] triggered by Gerrit: [com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77]
          Oct 20, 2016 8:04:00 AM com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.EventListener schedule
          INFO: Project Test Build Scheduled: true By event: 120/1
          Oct 20, 2016 8:04:06 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
          INFO: Gerrit build [Test #26] Started for cause: [GerritCause: com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77 silent: false].
          Oct 20, 2016 8:04:06 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener onStarted
          INFO: MemoryStatus:
            Project/Build: [Test]: [#26: null] Completed: false

          Oct 20, 2016 8:04:07 AM hudson.model.Run execute
          INFO: Test #26 main build action completed: SUCCESS
          Oct 20, 2016 8:04:07 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener allBuildsCompleted
          INFO: All Builds are completed for cause: GerritCause: com.sonymobile.tools.gerrit.gerritevents.dto.events.ChangeMerged@c3398b77 silent: false
          Oct 20, 2016 8:04:07 AM com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier buildCompleted
          INFO: Notifying BuildCompleted to gerrit: gerrit review 120,1 --message 'Build Successful

          https://*****/26/ : SUCCESS' --label Build-check=0 --code-review 0
          Oct 20, 2016 8:04:08 AM com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob sendCommand
          SEVERE: Could not run command gerrit review 120,1 --message 'Build Successful

          https://*****/26/ : SUCCESS' --label Build-check=0 --code-review 0
          java.io.IOException: Error during sending command
          at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:118)
          at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand(AbstractSendCommandJob.java:79)
          at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier.buildCompleted(GerritNotifier.java:118)
          at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.job.ssh.BuildCompletedCommandJob.run(BuildCompletedCommandJob.java:71)
          at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
          at java.util.concurrent.FutureTask.run(Unknown Source)
          at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
          at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
          at java.lang.Thread.run(Unknown Source)
          Caused by: com.sonymobile.tools.gerrit.gerritevents.ssh.SshException: error: fatal: change is closed

          fatal: one or more reviews failed; review output above (1)
          at com.sonymobile.tools.gerrit.gerritevents.ssh.SshConnectionImpl.executeCommand(SshConnectionImpl.java:254)
          at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:116)
          ... 8 more
          {code}
          scm_issue_link SCM/JIRA link daemon made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              rsandell rsandell
              Reporter:
              engy Jiří Engelthaler
            • Votes:
              4 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: