Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39213

Add ability for computed folders to control the views in the folder

    Details

    • Similar Issues:

      Description

      AbstractFolder does not provide a hook for plugins to contribute a static view configuration, rather it stores the mutable view configuration.

      Some folder sub-types (typically based off of ComputedFolder, but this is probably more general) have a requirement for the views to be specified based on programmatic criteria where synchronizing the configuration with the mutable list will result in unnecessary configuration file changes.

      In this regard it makes sense to refactor the view configuration of an AbstractFolder into an extension point that can be replaced by concrete subclasses.

        Attachments

          Issue Links

            Activity

            stephenconnolly Stephen Connolly created issue -
            stephenconnolly Stephen Connolly made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolderDescriptor.java
            src/main/java/com/cloudbees/hudson/plugins/folder/views/AbstractFolderViewHolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly
            src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/3df543235f7882e8cbcf4e11a37f637380ff34ac
            Log:
            JENKINS-39213 Add ability for computed folders to control the views in the folder

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolderDescriptor.java src/main/java/com/cloudbees/hudson/plugins/folder/views/AbstractFolderViewHolder.java src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/3df543235f7882e8cbcf4e11a37f637380ff34ac Log: JENKINS-39213 Add ability for computed folders to control the views in the folder
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/views/AbstractFolderViewHolder.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/96bfd09a343138a9a2d62eeb060f9ec4f6389c94
            Log:
            JENKINS-39213 Jesse wants us not to use ExtensionPoint unless it is an @Extension

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/views/AbstractFolderViewHolder.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/96bfd09a343138a9a2d62eeb060f9ec4f6389c94 Log: JENKINS-39213 Jesse wants us not to use ExtensionPoint unless it is an @Extension
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly
            src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/f3068bbc9ce417f7ae6e6351face1f74ebddda8b
            Log:
            JENKINS-39213 Fix bug and commit test

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/3df543235f78...f3068bbc9ce4

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/f3068bbc9ce417f7ae6e6351face1f74ebddda8b Log: JENKINS-39213 Fix bug and commit test Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/3df543235f78...f3068bbc9ce4
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/views/AbstractFolderViewHolder.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/f5bd1775c3d9b2bf982a73c7f84f2c9876baad4a
            Log:
            JENKINS-39213 Turns out to be really helpful if there is an ability to clear internal caches

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/views/AbstractFolderViewHolder.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/f5bd1775c3d9b2bf982a73c7f84f2c9876baad4a Log: JENKINS-39213 Turns out to be really helpful if there is an ability to clear internal caches
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolderDescriptor.java
            src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/FolderIconDescriptor.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ChildObserver.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/FolderComputation.java
            src/main/java/com/cloudbees/hudson/plugins/folder/views/AbstractFolderViewHolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/tasks-top-extra.jelly
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/FolderComputation/events.jelly
            src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/0d9318d1ecfd3f36d2691e3245731be5b29b8d50
            Log:
            Merge pull request #74 from jenkinsci/jenkins-39213

            JENKINS-39213 Add ability for computed folders to control the views in the folder

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/c95e459d15bc...0d9318d1ecfd

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolderDescriptor.java src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/java/com/cloudbees/hudson/plugins/folder/FolderIconDescriptor.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/ChildObserver.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/FolderComputation.java src/main/java/com/cloudbees/hudson/plugins/folder/views/AbstractFolderViewHolder.java src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/tasks-top-extra.jelly src/main/resources/com/cloudbees/hudson/plugins/folder/computed/FolderComputation/events.jelly src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/0d9318d1ecfd3f36d2691e3245731be5b29b8d50 Log: Merge pull request #74 from jenkinsci/jenkins-39213 JENKINS-39213 Add ability for computed folders to control the views in the folder Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/c95e459d15bc...0d9318d1ecfd
            stephenconnolly Stephen Connolly made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            stephenconnolly Stephen Connolly made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue is related to JENKINS-34597 [ JENKINS-34597 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-1583 (Web Link)" [ 18635 ]

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: