Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39237

Add option to update slave.jar in Windows Service Wrapper on startup (when Jenkins runs on HTTPS)

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Spin-off of JENKINS-16490. In Jenkins project we use this library for managing Windows Agents/Slaves. It's being done by launching a slave.jar via Java. Since the remoting library (effectively slave.jar) is being updated frequently, we would like to have an option to download it from the Jenkins instance directly.

      For such purpose I propose to implement a WinSW plugin

      https://github.com/kohsuke/winsw/issues/126

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Created the pull request: https://github.com/jenkinsci/windows-slave-installer-module/pull/6

            Will appreciate some testing and reviews

            Show
            oleg_nenashev Oleg Nenashev added a comment - Created the pull request: https://github.com/jenkinsci/windows-slave-installer-module/pull/6 Will appreciate some testing and reviews
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java
            src/main/resources/org/jenkinsci/modules/windows_slave_installer/jenkins-slave.xml
            src/test/java/org/jenkinsci/modules/windows_slave_installer/MockLaunchConfiguration.java
            src/test/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstallerTest.java
            http://jenkins-ci.org/commit/windows-slave-installer-module/33bf7bb673a70fb8b5c63ac35ba6229e88ee6aa8
            Log:
            JENKINS-39237 - Enable the automatic agent download during Windows Service Setup (#6)

            • JENKINS-39237 - Enable the automatic agent download during Windows Service Setup

            This change enables download of slave.jar on startup when it is possible.
            WindowsSlaveInstaller internal API has been slightly tweaked for testing purposes.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java src/main/resources/org/jenkinsci/modules/windows_slave_installer/jenkins-slave.xml src/test/java/org/jenkinsci/modules/windows_slave_installer/MockLaunchConfiguration.java src/test/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstallerTest.java http://jenkins-ci.org/commit/windows-slave-installer-module/33bf7bb673a70fb8b5c63ac35ba6229e88ee6aa8 Log: JENKINS-39237 - Enable the automatic agent download during Windows Service Setup (#6) JENKINS-39237 - Enable the automatic agent download during Windows Service Setup This change enables download of slave.jar on startup when it is possible. WindowsSlaveInstaller internal API has been slightly tweaked for testing purposes. JENKINS-39237 - Fix FindBugs JENKINS-39237 - Disable the download by default JENKINS-39237 - Enable download for HTTPS only
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/pom.xml
            core/src/main/resources/windows-service/jenkins-slave.xml
            core/src/main/resources/windows-service/jenkins.xml
            war/pom.xml
            http://jenkins-ci.org/commit/jenkins/e698d1de41d4311bf5f8b1d2c40b591109e696e2
            Log:
            Update Windows Agent Installer to 1.7 and WinSW to 2.0.2 (#2765)

                1. WinSW changes

            The update includes many fixes and improvements, the full list is provided in the [WinSW changelog](https://github.com/kohsuke/winsw/blob/master/CHANGELOG.md). There are several issues referenced in Jenkins bugtracker:

                1. Windows Agent Installer changes
            • Adapt the default configurations to pick fixes above
            • Slave => Agent renaming where possible
                1. Jenkins core changes
            • Modify the configuration template, reference advanced options
            • Enable Runaway Process Killer by default
            • Update Windows Agent Installer to 1.7
            • Remove the obsolete jenkins-slave.xml file from the core.

            Now it is within windows-slave-installer

            • Use the deployed Snapshot for CI
            • Pick the release version of windows-slave-installer-1.7
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/pom.xml core/src/main/resources/windows-service/jenkins-slave.xml core/src/main/resources/windows-service/jenkins.xml war/pom.xml http://jenkins-ci.org/commit/jenkins/e698d1de41d4311bf5f8b1d2c40b591109e696e2 Log: Update Windows Agent Installer to 1.7 and WinSW to 2.0.2 (#2765) WinSW changes The update includes many fixes and improvements, the full list is provided in the [WinSW changelog] ( https://github.com/kohsuke/winsw/blob/master/CHANGELOG.md ). There are several issues referenced in Jenkins bugtracker: JENKINS-22692 ( https://issues.jenkins-ci.org/browse/JENKINS-22692 ) - Connection reset issues when WinSW gets terminated due to the system shutdown JENKINS-23487 ( https://issues.jenkins-ci.org/browse/JENKINS-23487)- Support of shared directories in WinSW JENKINS-39231 ( https://issues.jenkins-ci.org/browse/JENKINS-39231 ) - Enable Runaway Process Killer by default JENKINS-39237 ( https://issues.jenkins-ci.org/browse/JENKINS-39237 ) - Auto-upgrade of JNLP agent versions on the slaves Windows Agent Installer changes Adapt the default configurations to pick fixes above Slave => Agent renaming where possible Jenkins core changes Modify the configuration template, reference advanced options Enable Runaway Process Killer by default Update Windows Agent Installer to 1.7 Remove the obsolete jenkins-slave.xml file from the core. Now it is within windows-slave-installer Use the deployed Snapshot for CI Pick the release version of windows-slave-installer-1.7
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The feature has been released in Jenkins 2.50
            Automatic upgrade is enabled for newly installed agents with HTTPS connection.
            See the upgrade guidelines here: https://github.com/jenkinsci/windows-slave-installer-module/blob/master/CHANGELOG.md#17

            Show
            oleg_nenashev Oleg Nenashev added a comment - The feature has been released in Jenkins 2.50 Automatic upgrade is enabled for newly installed agents with HTTPS connection. See the upgrade guidelines here: https://github.com/jenkinsci/windows-slave-installer-module/blob/master/CHANGELOG.md#17
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            As a maintainer, I reject backporting of the fix to 2.46.3. The feature will be likely available in the next LTS baseline (to be elected on May 24)

            Show
            oleg_nenashev Oleg Nenashev added a comment - As a maintainer, I reject backporting of the fix to 2.46.3. The feature will be likely available in the next LTS baseline (to be elected on May 24)
            Hide
            casz Joseph Petersen added a comment -

            Oleg Nenashev marked this as lts-candidate

            Show
            casz Joseph Petersen added a comment - Oleg Nenashev marked this as lts-candidate
            Hide
            olivergondza Oliver Gondža added a comment -

            Joseph Petersen, there is no need to. The fix went into 2.50 so it will be part of 2.60.1 released in 2 weeks anyway.

            Show
            olivergondza Oliver Gondža added a comment - Joseph Petersen , there is no need to. The fix went into 2.50 so it will be part of 2.60.1 released in 2 weeks anyway.
            Hide
            casz Joseph Petersen added a comment -

            Awesome, I just really want the feature that's all 

            Show
            casz Joseph Petersen added a comment - Awesome, I just really want the feature that's all 

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                6 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: