Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39339

Try BlueOcean button should keep currently open pipeline context

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      indian

      Description

      Currently the "try blue ocean" button links to the home page.

      In scope:

      • If a user is browsing a pipeline results screen etc - would be nice to take to the equivalent in blue ocean.
      • Try blue ocean should be a hyperlink so that right click "open in new tab" can work as EVERYONE tries to do that and sighs with sadness when they can't.
      • Rename button to "Open Blue Ocean"

        Attachments

          Activity

          Hide
          michaelneale Michael Neale added a comment -

          Tom FENNELLY I think this is what Vincent Latombe was meaning about the blue ocean link - I didn't see a ticket for this so opened one (seems a nice to have). Never thought of this before.

          Neat!

          Show
          michaelneale Michael Neale added a comment - Tom FENNELLY I think this is what Vincent Latombe was meaning about the blue ocean link - I didn't see a ticket for this so opened one (seems a nice to have). Never thought of this before. Neat!
          Hide
          cobexer Ing. Christoph Obexer added a comment -

          And could it be turned into a proper hyperlink (A Tag) please?

          I always try to middle click it to open BO in a new tab and that doesn't work.

          Show
          cobexer Ing. Christoph Obexer added a comment - And could it be turned into a proper hyperlink (A Tag) please? I always try to middle click it to open BO in a new tab and that doesn't work.
          Hide
          michaelneale Michael Neale added a comment -

          Ing. Christoph Obexer me too - good point. Changing description.
          FYI there is another ticket talking abotu the lack of right clickable links...

          Show
          michaelneale Michael Neale added a comment - Ing. Christoph Obexer me too - good point. Changing description. FYI there is another ticket talking abotu the lack of right clickable links...
          Hide
          vlatombe Vincent Latombe added a comment -

          Looks good, thank you for filing this Michael Neale!

          Show
          vlatombe Vincent Latombe added a comment - Looks good, thank you for filing this Michael Neale !
          Hide
          tfennelly Tom FENNELLY added a comment -

          We can do this so long as there's a clean way of mapping the classic URL to the blueocean URL and I think there is.

          Show
          tfennelly Tom FENNELLY added a comment - We can do this so long as there's a clean way of mapping the classic URL to the blueocean URL and I think there is.
          Hide
          tfennelly Tom FENNELLY added a comment - - edited

          Here's the original JIRA for this.... JENKINS-35832. I'm fairly sure the text in the description was copied from somewhere else because I seem to remember writing those exact words Ah ... because it was imported from other JIRA instance.

          Show
          tfennelly Tom FENNELLY added a comment - - edited Here's the original JIRA for this.... JENKINS-35832 . I'm fairly sure the text in the description was copied from somewhere else because I seem to remember writing those exact words Ah ... because it was imported from other JIRA instance.
          Hide
          jamesdumay James Dumay added a comment -

          Tom FENNELLY could you please pick this one up next? This was identified in the CD survey feedback and mentioned on a few email threads as a pain point for adoption.

          Show
          jamesdumay James Dumay added a comment - Tom FENNELLY could you please pick this one up next? This was identified in the CD survey feedback and mentioned on a few email threads as a pain point for adoption.
          Hide
          tfennelly Tom FENNELLY added a comment -

          Hey Vivek Pandey or Ivan Meredith, do we have any magic on the Blue Ocean backend that accurately maps a blue ocean URL to it's equivalent classic Jenkins URL? I appreciate that this might not always be possible, but then we can just go to the Blue Ocean home page (as today).

          In the meantime, I will see if I can implement some @Extension points that get rendered on classic Jenkins pages (Job page and then Run page) and at least be able to redirect when on these pages (to the active pipeline or run details page in BO). This might be enough (as in the description above).

          Show
          tfennelly Tom FENNELLY added a comment - Hey Vivek Pandey or Ivan Meredith , do we have any magic on the Blue Ocean backend that accurately maps a blue ocean URL to it's equivalent classic Jenkins URL? I appreciate that this might not always be possible, but then we can just go to the Blue Ocean home page (as today). In the meantime, I will see if I can implement some @Extension points that get rendered on classic Jenkins pages (Job page and then Run page) and at least be able to redirect when on these pages (to the active pipeline or run details page in BO). This might be enough (as in the description above).
          Hide
          michaelneale Michael Neale added a comment -

          yeah not sure why that other one was closed (doesn't have a reason). Not deliberately related. Great minds think alike.

          Show
          michaelneale Michael Neale added a comment - yeah not sure why that other one was closed (doesn't have a reason). Not deliberately related. Great minds think alike.
          Show
          tfennelly Tom FENNELLY added a comment - PRs: https://github.com/jenkinsci/blueocean-plugin/pull/582 https://github.com/jenkinsci/blueocean-acceptance-test/pull/65
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Tom Fennelly
          Path:
          src/main/js/custom_assertions/urlEndsWith.js
          src/main/js/custom_commands/addOpenBlueOceanLinkToFooter.js
          src/main/js/custom_commands/openBlueOcean.js
          src/main/js/globals.js
          src/main/js/page_objects/blueocean/bluePipelineActivity.js
          src/main/js/page_objects/classic_jenkins/classicRun.js
          src/main/nightwatch.json
          src/test/js/edgeCases/folder.js
          src/test/js/smoke.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/cdf8d0d9c1e5db06951f9de01bf7498a84c7d254
          Log:
          [FIX JENKINS-39339] contextual try Blue Ocean button (#65)

          • Add "Open Blue Ocean" link to footer

          need it because we removed the header

          • Added a few custom assertions
          • Added some pipeline activity page empty state assertions
          • Added openBlueOcean custom command
          • Add smoke test for the "Open Blue Ocean" button
          • remove urlMatches - unused
          • Fix url encoding in urlEndsWith
          • Make pipeline activity basic layout testing less fragile
          • A test for "Open Blue Ocean" on a freestyle down in a folder
          • Fix urlEndsWith assertion to handle weird characters in a more human way
          • A test for "Open Blue Ocean" on a multibranch run down in a folder
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: src/main/js/custom_assertions/urlEndsWith.js src/main/js/custom_commands/addOpenBlueOceanLinkToFooter.js src/main/js/custom_commands/openBlueOcean.js src/main/js/globals.js src/main/js/page_objects/blueocean/bluePipelineActivity.js src/main/js/page_objects/classic_jenkins/classicRun.js src/main/nightwatch.json src/test/js/edgeCases/folder.js src/test/js/smoke.js http://jenkins-ci.org/commit/blueocean-acceptance-test/cdf8d0d9c1e5db06951f9de01bf7498a84c7d254 Log: [FIX JENKINS-39339] contextual try Blue Ocean button (#65) Add "Open Blue Ocean" link to footer need it because we removed the header Added a few custom assertions Added some pipeline activity page empty state assertions Added openBlueOcean custom command Add smoke test for the "Open Blue Ocean" button remove urlMatches - unused Fix url encoding in urlEndsWith Make pipeline activity basic layout testing less fragile A test for "Open Blue Ocean" on a freestyle down in a folder Fix urlEndsWith assertion to handle weird characters in a more human way A test for "Open Blue Ocean" on a multibranch run down in a folder

            People

            • Assignee:
              tfennelly Tom FENNELLY
              Reporter:
              michaelneale Michael Neale
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: