Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39580

Allow configuring either Blue Ocean or Classic links for notifications

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      pannonian

      Description

      It does not seem possible currently to configure which display URL provider to use, but it needs to be.

      Just installing the pre-release Blue Ocean to try it should not make all PR build links point to it – this might be undesired, and additionally BO might get disabled or uninstalled again, rendering the links broken.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James Dumay
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/displayurlapi/ClassicDisplayURLProvider.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/actions/AbstractDisplayAction.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserPropertyDescriptor.java
          src/main/resources/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty/config.jelly
          src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectExtendedTest.java
          http://jenkins-ci.org/commit/display-url-api-plugin/8e35b654e0f7600d64b0c996e640bef0c108e624
          Log:
          JENKINS-39580 - Allow configuring which DisplayUrlProvider to use

          Compare: https://github.com/jenkinsci/display-url-api-plugin/compare/b71315704833^...8e35b654e0f7

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Dumay Path: pom.xml src/main/java/org/jenkinsci/plugins/displayurlapi/ClassicDisplayURLProvider.java src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java src/main/java/org/jenkinsci/plugins/displayurlapi/actions/AbstractDisplayAction.java src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty.java src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserPropertyDescriptor.java src/main/resources/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty/config.jelly src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectExtendedTest.java http://jenkins-ci.org/commit/display-url-api-plugin/8e35b654e0f7600d64b0c996e640bef0c108e624 Log: JENKINS-39580 - Allow configuring which DisplayUrlProvider to use Compare: https://github.com/jenkinsci/display-url-api-plugin/compare/b71315704833 ^...8e35b654e0f7
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James Dumay
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/displayurlapi/ClassicDisplayURLProvider.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/actions/AbstractDisplayAction.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserPropertyDescriptor.java
          src/main/resources/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty/config.jelly
          src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectExtendedTest.java
          http://jenkins-ci.org/commit/display-url-api-plugin/c3bd84e7773c8057374b49c16c3a6d97767f1c48
          Log:
          JENKINS-39580 - Allow configuring which DisplayUrlProvider to use

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Dumay Path: pom.xml src/main/java/org/jenkinsci/plugins/displayurlapi/ClassicDisplayURLProvider.java src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java src/main/java/org/jenkinsci/plugins/displayurlapi/actions/AbstractDisplayAction.java src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty.java src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserPropertyDescriptor.java src/main/resources/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty/config.jelly src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectExtendedTest.java http://jenkins-ci.org/commit/display-url-api-plugin/c3bd84e7773c8057374b49c16c3a6d97767f1c48 Log: JENKINS-39580 - Allow configuring which DisplayUrlProvider to use
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James William Dumay
          Path:
          src/main/java/org/jenkinsci/plugins/displayurlapi/ClassicDisplayURLProvider.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/actions/AbstractDisplayAction.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserPropertyDescriptor.java
          src/main/resources/org/jenkinsci/plugins/displayurlapi/Messages.properties
          src/main/resources/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty/config.jelly
          src/main/resources/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty/help-providerId.html
          src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectExtendedTest.java
          http://jenkins-ci.org/commit/display-url-api-plugin/4f280c227750f37d6c8be8c5532c9701758c55ad
          Log:
          JENKINS-39580 Allow the user to configure a preferred provider (#5)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: src/main/java/org/jenkinsci/plugins/displayurlapi/ClassicDisplayURLProvider.java src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java src/main/java/org/jenkinsci/plugins/displayurlapi/actions/AbstractDisplayAction.java src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty.java src/main/java/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserPropertyDescriptor.java src/main/resources/org/jenkinsci/plugins/displayurlapi/Messages.properties src/main/resources/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty/config.jelly src/main/resources/org/jenkinsci/plugins/displayurlapi/user/PreferredProviderUserProperty/help-providerId.html src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectExtendedTest.java http://jenkins-ci.org/commit/display-url-api-plugin/4f280c227750f37d6c8be8c5532c9701758c55ad Log: JENKINS-39580 Allow the user to configure a preferred provider (#5)
          Hide
          jamesdumay James Dumay added a comment -

          This improvement will be shipping alongside beta 21 this week.

          Show
          jamesdumay James Dumay added a comment - This improvement will be shipping alongside beta 21 this week.
          Hide
          pjaytycy Pieter-Jan Busschaert added a comment -

          Thanks for working on this issue, now I can re-enable Blue Ocean on our setup (without really using it). Just one question on the implementation of this fix: will each user have to select the "classic" URLs or can I change the default system-wide ?

          Show
          pjaytycy Pieter-Jan Busschaert added a comment - Thanks for working on this issue, now I can re-enable Blue Ocean on our setup (without really using it). Just one question on the implementation of this fix: will each user have to select the "classic" URLs or can I change the default system-wide ?
          Hide
          jamesdumay James Dumay added a comment -

          Each user will have to pick for the time being.

          Is there anything in particular that makes you want to go back to Classic?

          Show
          jamesdumay James Dumay added a comment - Each user will have to pick for the time being. Is there anything in particular that makes you want to go back to Classic?
          Hide
          jamesdumay James Dumay added a comment -

          Btw You can grab these fixes from the Update Center right now by upgrading the Blue Ocean Display URL plugin to 1.4

          Show
          jamesdumay James Dumay added a comment - Btw You can grab these fixes from the Update Center right now by upgrading the Blue Ocean Display URL plugin to 1.4
          Hide
          pjaytycy Pieter-Jan Busschaert added a comment -

          There are many reasons why (at the moment) I would prefer classic URLs by default. The Blue Ocean UI does not cover all our uses of Jenkins yet and I'm not sure it ever will (due to different vision). It's mainly enabled to track the progress and see when it becomes useful for us. I disabled it when all the "build failed" emails sent our developers to the Blue Ocean URLs.

          Most of our projects are either freestyle or matrix-style projects. We are very used to the project page showing us at a glance the build status of the last changes + some trend graphs that show the evolution of build times, test runs, code style checking, build warnings, .... At the moment only the build status is available in the "activity" page. The other 2 pages ("branches", "pull requests") are not available at all due to not using multibranch pipeline. So, we converted one of the matrix projects to a multibranch pipeline and occasionally check how that is displayed in Blue Ocean. The branches tab works there, but as we are not using github (not even git), the pull requests tab will stay useless. Nowhere in Blue Ocean do we get the trend graphs we are used to in Classic.

          So, I understand we are not the target audience for Blue Ocean at the moment and that's fine with me. I only have it enabled because I am interested in Blue Ocean and want to track its progress. As we're a small team, I'll just ask all our developers to change the URL setting themselves, but being able to set the default would have been preferred.

          Show
          pjaytycy Pieter-Jan Busschaert added a comment - There are many reasons why (at the moment) I would prefer classic URLs by default. The Blue Ocean UI does not cover all our uses of Jenkins yet and I'm not sure it ever will (due to different vision). It's mainly enabled to track the progress and see when it becomes useful for us. I disabled it when all the "build failed" emails sent our developers to the Blue Ocean URLs. Most of our projects are either freestyle or matrix-style projects. We are very used to the project page showing us at a glance the build status of the last changes + some trend graphs that show the evolution of build times, test runs, code style checking, build warnings, .... At the moment only the build status is available in the "activity" page. The other 2 pages ("branches", "pull requests") are not available at all due to not using multibranch pipeline. So, we converted one of the matrix projects to a multibranch pipeline and occasionally check how that is displayed in Blue Ocean. The branches tab works there, but as we are not using github (not even git), the pull requests tab will stay useless. Nowhere in Blue Ocean do we get the trend graphs we are used to in Classic. So, I understand we are not the target audience for Blue Ocean at the moment and that's fine with me. I only have it enabled because I am interested in Blue Ocean and want to track its progress. As we're a small team, I'll just ask all our developers to change the URL setting themselves, but being able to set the default would have been preferred.
          Hide
          jamesdumay James Dumay added a comment -

          Pieter-Jan Busschaert I am adding a system property and environment variable for you to set the default you want globally. Watch JENKINS-41578 for updates.

          Show
          jamesdumay James Dumay added a comment - Pieter-Jan Busschaert I am adding a system property and environment variable for you to set the default you want globally. Watch JENKINS-41578 for updates.
          Hide
          jamesdumay James Dumay added a comment - - edited

          Pieter-Jan Busschaert this is great feedback! We are going to focus on Trends after the initial 1.0 release. Watch JENKINS-35882 for updates Would you mind me contacting you to discuss this feature as we start designing and planning it? Which report plugins do you use?

          Show
          jamesdumay James Dumay added a comment - - edited Pieter-Jan Busschaert this is great feedback! We are going to focus on Trends after the initial 1.0 release. Watch JENKINS-35882 for updates Would you mind me contacting you to discuss this feature as we start designing and planning it? Which report plugins do you use?
          Hide
          pjaytycy Pieter-Jan Busschaert added a comment -

          Thanks, I'm now watching both issues for updates.
          Feel free to contact me for input on the trends/report topic. However, I don't want to hijack this bug comment thread with a long chat about that topic.

          The report plugins / trend graphs we currently use are:

          Show
          pjaytycy Pieter-Jan Busschaert added a comment - Thanks, I'm now watching both issues for updates. Feel free to contact me for input on the trends/report topic. However, I don't want to hijack this bug comment thread with a long chat about that topic. The report plugins / trend graphs we currently use are: Test result trend (count + duration graphs) ( https://wiki.jenkins-ci.org/display/JENKINS/xUnit+Plugin ) MSBuild warnings trend ( https://wiki.jenkins-ci.org/display/JENKINS/Warnings+Plugin ) CppCheck ( https://wiki.jenkins-ci.org/display/JENKINS/Cppcheck+Plugin ) Build time trend ( core )
          Hide
          kamikaze Oleg Korsak added a comment - - edited

          James Dumay what should I do to get such URL to BlueOcean UI with my build? For classic ui I'm using slackNotify with env.BUILD_URL as an url.

          Show
          kamikaze Oleg Korsak added a comment - - edited James Dumay what should I do to get such URL to BlueOcean UI with my build? For classic ui I'm using slackNotify with env.BUILD_URL as an url.
          Hide
          jamesdumay James Dumay added a comment -

          Oleg Korsak hmm, good point - I don't think we are using display URL in Pipeline right now. let me follow up with a ticket.

          Show
          jamesdumay James Dumay added a comment - Oleg Korsak hmm, good point - I don't think we are using display URL in Pipeline right now. let me follow up with a ticket.
          Hide
          jamesdumay James Dumay added a comment -

          Oleg Korsak adding these now as part of JENKINS-41677

          Show
          jamesdumay James Dumay added a comment - Oleg Korsak adding these now as part of JENKINS-41677

            People

            • Assignee:
              jamesdumay James Dumay
              Reporter:
              danielbeck Daniel Beck
            • Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: