Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39646

Properly generate bundles for packages that have multiple top-level modules

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      Blue Ocean 1.2-beta2

      Description

      Bundled are generated in a sub optimal way. One side effect is there could be multiple submodules of popular libraries appearing in different bundles. 


      See this doc for a description of the problem(s).

        Attachments

          Issue Links

            Activity

            Hide
            michaelneale Michael Neale added a comment -

            Bringing this up for discussion at next hangout.. 

            Show
            michaelneale Michael Neale added a comment - Bringing this up for discussion at next hangout.. 
            Hide
            jamesdumay James Dumay added a comment -

            Michael Neale still needed on the board?

            Show
            jamesdumay James Dumay added a comment - Michael Neale still needed on the board?
            Hide
            tfennelly Tom FENNELLY added a comment -

            I'm going to write up a more detailed and structured doc around all of this wrt what's wrong today with how we generate an use bundles and what I think we need to do to put it right (or more right than it is).

            There are a few fundamental things we are doing wrong imo (yes, my fault). I'd really like to put those things right before we try doing things like what's in jenkinsci/js-builder/pull/19. How we allow exports of modules today without properly generating a "dependency bundle" (e.g. how we export some modules in blueocean.js in the blueocean-web plugin) is fundamentally wrong and is eventually going to break badly ... just a matter of time!! jenkinsci/js-builder/pull/19 would very likely make that situation a lot worse imo + make it harder to fix. So, I'm firmly of the opinion that we fix how we generate bundles etc first, and then come back and see how we can make jenkinsci/js-builder/pull/19 work where it'll be on more solid foundations.

            Show
            tfennelly Tom FENNELLY added a comment - I'm going to write up a more detailed and structured doc around all of this wrt what's wrong today with how we generate an use bundles and what I think we need to do to put it right (or more right than it is). There are a few fundamental things we are doing wrong imo (yes, my fault). I'd really like to put those things right before we try doing things like what's in jenkinsci/js-builder/pull/19 . How we allow exports of modules today without properly generating a "dependency bundle" (e.g. how we export some modules in blueocean.js in the blueocean-web plugin) is fundamentally wrong and is eventually going to break badly ... just a matter of time!! jenkinsci/js-builder/pull/19 would very likely make that situation a lot worse imo + make it harder to fix. So, I'm firmly of the opinion that we fix how we generate bundles etc first, and then come back and see how we can make jenkinsci/js-builder/pull/19 work where it'll be on more solid foundations.
            Hide
            tfennelly Tom FENNELLY added a comment -

            I added the doc. It's linked to in the main description.

            Show
            tfennelly Tom FENNELLY added a comment - I added the doc. It's linked to in the main description.
            Hide
            tfennelly Tom FENNELLY added a comment -

            James Dumay I think we can close this a "Won't Do" .

            Show
            tfennelly Tom FENNELLY added a comment - James Dumay I think we can close this a "Won't Do" .

              People

              • Assignee:
                Unassigned
                Reporter:
                tfennelly Tom FENNELLY
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: