Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39888

REGRESSION: opening/closing run dialog breaks scrolling of activity list and does not update window location

    XMLWordPrintable

    Details

    • Sprint:
      tasman
    • Similar Issues:

      Description

      Steps to reproduce

      1. Make the window 1024x1024
      2. Visit https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
      3. Scroll to the bottom of the activity so the header is not visible
      4. Click on any run
      5. Close the run dialog
      6. try to scroll up - you won't be able to!
      7. the window location is still set to the run and not the activity

        Attachments

          Activity

          Hide
          michaelneale Michael Neale added a comment -

          Thor - looks like Cliff has found the cause and has a fix WIP

          Show
          michaelneale Michael Neale added a comment - Thor - looks like Cliff has found the cause and has a fix WIP
          Hide
          cliffmeyers Cliff Meyers added a comment -

          For posterity: when the A elements were added in the TD's, the outer TR still had a click handler on it. This caused the router.push to be called twice, so Run Detail's "opener" link was pointing to itself. Clicking "close" destroyed the modal but did not actually navigate backwards (it navigated to itself). The broken scrolbar is because that DOM is actually part of the "snapshot" that Keith added to prevent the "flash" when navigating to Run Details.

          Show
          cliffmeyers Cliff Meyers added a comment - For posterity: when the A elements were added in the TD's, the outer TR still had a click handler on it. This caused the router.push to be called twice, so Run Detail's "opener" link was pointing to itself. Clicking "close" destroyed the modal but did not actually navigate backwards (it navigated to itself). The broken scrolbar is because that DOM is actually part of the "snapshot" that Keith added to prevent the "flash" when navigating to Run Details.
          Hide
          michaelneale Michael Neale added a comment -

          hrm.. I think Ivan Meredith pointed this out yesterday - events weren't being stopped at the right point...

          Show
          michaelneale Michael Neale added a comment - hrm.. I think Ivan Meredith pointed this out yesterday - events weren't being stopped at the right point...
          Hide
          cliffmeyers Cliff Meyers added a comment -

          No, has nothing to do with events I'm afraid. See above.

          Show
          cliffmeyers Cliff Meyers added a comment - No, has nothing to do with events I'm afraid. See above.
          Show
          cliffmeyers Cliff Meyers added a comment - WIP PR: https://github.com/jenkinsci/blueocean-plugin/pull/614
          Hide
          cliffmeyers Cliff Meyers added a comment -

          This one is close so putting in review. Last batch of changes in the PR just needs some feedback, then similar changes applied to the Branches and PR's screens (shouldn't take long).

          Show
          cliffmeyers Cliff Meyers added a comment - This one is close so putting in review. Last batch of changes in the PR just needs some feedback, then similar changes applied to the Branches and PR's screens (shouldn't take long).
          Hide
          jamesdumay James Dumay added a comment -

          Cliff Meyers Fantastic!

          Show
          jamesdumay James Dumay added a comment - Cliff Meyers Fantastic!

            People

            • Assignee:
              cliffmeyers Cliff Meyers
              Reporter:
              jamesdumay James Dumay
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: