Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3990

Duplicate scores if user names have different case

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: ci-game-plugin
    • Labels:
      None
    • Environment:
      Platform: Macintosh, OS: All
    • Similar Issues:

      Description

      We have been seeing duplicate CI game scores in our Hudson install. It seems that the reason is that the
      CI game does a case-sensitive compare on user names, whereas Hudson does not.

      Please can the CI game be changed to do a case-insensitive name comparison?

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/pom.xml
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GameDescriptor.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java
            trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global.jelly
            trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global.properties
            trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global_sv.properties
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21341
            Log:
            JENKINS-3990 - Added global checkbox to indicate if the Hudson user names are to be used case sensitive or not.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/pom.xml trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GameDescriptor.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global.jelly trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global.properties trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global_sv.properties trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=21341 Log: JENKINS-3990 - Added global checkbox to indicate if the Hudson user names are to be used case sensitive or not.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/pom.xml
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21342
            Log:
            JENKINS-3990 - Added integration test for global configuring.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/pom.xml trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=21342 Log: JENKINS-3990 - Added integration test for global configuring.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21344
            Log:
            JENKINS-3990 - Game publisher now uses global configured value.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java http://fisheye4.cenqua.com/changelog/hudson/?cs=21344 Log: JENKINS-3990 - Game publisher now uses global configured value.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java
            trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/ScoreCardAction/index.jelly
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionIntegrationTest.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionTest.java
            trunk/hudson/plugins/ci-game/src/test/resources/hudson/plugins/cigame/ScoreCardActionIntegrationTest.zip
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21374
            Log:
            JENKINS-3990 - Score card action now uses global configured value.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/ScoreCardAction/index.jelly trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionIntegrationTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionTest.java trunk/hudson/plugins/ci-game/src/test/resources/hudson/plugins/cigame/ScoreCardActionIntegrationTest.zip http://fisheye4.cenqua.com/changelog/hudson/?cs=21374 Log: JENKINS-3990 - Score card action now uses global configured value.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/CaseInsensitiveUserIdComparator.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GameDescriptor.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/LeaderBoardAction.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/LeaderBoardActionTest.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionIntegrationTest.java
            trunk/hudson/plugins/ci-game/src/test/resources/hudson/plugins/cigame/GameDescriptorIntegrationTest/testLoadingCaseInsensitiveFlagWorks.zip
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21408
            Log:
            [FIXED JENKINS-3990] - If configured scores are not assigned to user with same casing. This will hide some users from the leaderboard, so it is advisable that the scores are reset before continuing the game.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/CaseInsensitiveUserIdComparator.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GameDescriptor.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/LeaderBoardAction.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/LeaderBoardActionTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionIntegrationTest.java trunk/hudson/plugins/ci-game/src/test/resources/hudson/plugins/cigame/GameDescriptorIntegrationTest/testLoadingCaseInsensitiveFlagWorks.zip http://fisheye4.cenqua.com/changelog/hudson/?cs=21408 Log: [FIXED JENKINS-3990] - If configured scores are not assigned to user with same casing. This will hide some users from the leaderboard, so it is advisable that the scores are reset before continuing the game.

              People

              • Assignee:
                redsolo redsolo
                Reporter:
                bids bids
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: