Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39907

Github pull requests gets unproper statuses url link

    Details

    • Sprint:
      frank
    • Similar Issues:

      Description

      As seen on https://github.com/jenkinsci/git-plugin/pull/212, the PR status links to https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgit-plugin/detail/PR-212/21/pipeline, returning a 404 error code.

      The real (even seemingly wrong) url is https://ci.jenkins.io/blue/organizations/jenkins%20/Plugins%2Fgit-plugin/detail/PR-212/21/pipeline/

      Note the extra space (%20) after the organization name, causing the 404

        Attachments

          Activity

          Hide
          imeredith Ivan Meredith added a comment -

          This is caused by i18n and our use of Jenkins.getInstance().getDisplayName() to generate the default org. Spanish translation has a space at the end of that line and I fixed it awhile back in a PR. But we probably just need to use a hardcoded 'jenkins' for default org i guess.

          Show
          imeredith Ivan Meredith added a comment - This is caused by i18n and our use of Jenkins.getInstance().getDisplayName() to generate the default org. Spanish translation has a space at the end of that line and I fixed it awhile back in a PR. But we probably just need to use a hardcoded 'jenkins' for default org i guess.
          Hide
          michaelneale Michael Neale added a comment -

          Possibly related to this fix: https://github.com/jenkinsci/blueocean-plugin/pull/634 (which is not yet released).

          Also - I don't follow. When I click on the link in the PR it takes to the right place - not sure what the https://ci.jenkins.io/blue/organizations/jenkins%20/Plugins%2Fgit-plugin/detail/PR-212/21/pipeline/ is from

          Show
          michaelneale Michael Neale added a comment - Possibly related to this fix: https://github.com/jenkinsci/blueocean-plugin/pull/634 (which is not yet released). Also - I don't follow. When I click on the link in the PR it takes to the right place - not sure what the https://ci.jenkins.io/blue/organizations/jenkins%20/Plugins%2Fgit-plugin/detail/PR-212/21/pipeline/ is from
          Hide
          witokondoria Javier Delgado added a comment -

          Michael Neale
          the pr status has https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgit-plugin/detail/PR-212/22/ as target_url (as github api states: https://api.github.com/repos/jenkinsci/git-plugin/commits/4c6a0284bd46b7d5a4b4fc4f1c27e95fe651d03b/status)

          For my browser (rendering https://ci.jenkins.io/ in spanish), that url throws a 404. The blueocean url that server the proper content contains such space (%20) in the url

          Show
          witokondoria Javier Delgado added a comment - Michael Neale the pr status has https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgit-plugin/detail/PR-212/22/ as target_url (as github api states: https://api.github.com/repos/jenkinsci/git-plugin/commits/4c6a0284bd46b7d5a4b4fc4f1c27e95fe651d03b/status ) For my browser (rendering https://ci.jenkins.io/ in spanish), that url throws a 404. The blueocean url that server the proper content contains such space (%20) in the url

            People

            • Assignee:
              imeredith Ivan Meredith
              Reporter:
              witokondoria Javier Delgado
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: