Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3990

Duplicate scores if user names have different case

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: ci-game-plugin
    • Labels:
      None
    • Environment:
      Platform: Macintosh, OS: All
    • Similar Issues:

      Description

      We have been seeing duplicate CI game scores in our Hudson install. It seems that the reason is that the
      CI game does a case-sensitive compare on user names, whereas Hudson does not.

      Please can the CI game be changed to do a case-insensitive name comparison?

        Attachments

          Issue Links

            Activity

            Hide
            redsolo redsolo added a comment -

            I will look into this

            Show
            redsolo redsolo added a comment - I will look into this
            Hide
            redsolo redsolo added a comment -

            I was looking into this issue, and from what I can tell Hudson does make case sensitive
            comparisons on the user id. If a SCM returns a change set with users "erik" and "Erik",
            both of them will show up under People, ie Hudson thinks there are two users and not one.
            Hudson stores information about each user in a file with the name of the user, but as
            all files are case insensitive in Windows it seems that user "erik" and "Erik" contains
            the same data thus the same user.

            Show
            redsolo redsolo added a comment - I was looking into this issue, and from what I can tell Hudson does make case sensitive comparisons on the user id. If a SCM returns a change set with users "erik" and "Erik", both of them will show up under People, ie Hudson thinks there are two users and not one. Hudson stores information about each user in a file with the name of the user, but as all files are case insensitive in Windows it seems that user "erik" and "Erik" contains the same data thus the same user.
            Hide
            bids bids added a comment -

            My vote is that user id comparisons should not be case sensitive anywhere in Hudson.

            Show
            bids bids added a comment - My vote is that user id comparisons should not be case sensitive anywhere in Hudson.
            Hide
            redsolo redsolo added a comment -

            Im just curious, but what SCM are you using that produces case insensitive user
            names? Maybe I can solve this in the game plugin, but as you say perhaps Hudson
            should not make a difference about caseing.

            Show
            redsolo redsolo added a comment - Im just curious, but what SCM are you using that produces case insensitive user names? Maybe I can solve this in the game plugin, but as you say perhaps Hudson should not make a difference about caseing.
            Hide
            bids bids added a comment -

            We're using VisualSVN on Windows - I think it depends on how the user logs on, e.g. baxtersp, BAXTERSP,
            BaxterSP. This might be different on different machines (we work in a multi-platform environment).

            Show
            bids bids added a comment - We're using VisualSVN on Windows - I think it depends on how the user logs on, e.g. baxtersp, BAXTERSP, BaxterSP. This might be different on different machines (we work in a multi-platform environment).
            Hide
            redsolo redsolo added a comment -

            Created an attachment (id=871)
            Simple patch for the game

            Show
            redsolo redsolo added a comment - Created an attachment (id=871) Simple patch for the game
            Hide
            redsolo redsolo added a comment -

            Created an attachment (id=872)
            mylyn/context/zip

            Show
            redsolo redsolo added a comment - Created an attachment (id=872) mylyn/context/zip
            Hide
            redsolo redsolo added a comment -
                • Issue 4350 has been marked as a duplicate of this issue. ***
            Show
            redsolo redsolo added a comment - Issue 4350 has been marked as a duplicate of this issue. ***
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/UserScoreProperty.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/model/RuleBook.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/model/ScoreCard.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GamePublisherTest.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionTest.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/model/ScoreCardTest.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21317
            Log:
            JENKINS-3990 - Fixed so two users in the same change set will not be included in the score card as two users.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/UserScoreProperty.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/model/RuleBook.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/model/ScoreCard.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GamePublisherTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/model/ScoreCardTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=21317 Log: JENKINS-3990 - Fixed so two users in the same change set will not be included in the score card as two users.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/pom.xml
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GameDescriptor.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java
            trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global.jelly
            trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global.properties
            trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global_sv.properties
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21341
            Log:
            JENKINS-3990 - Added global checkbox to indicate if the Hudson user names are to be used case sensitive or not.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/pom.xml trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GameDescriptor.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global.jelly trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global.properties trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/GameDescriptor/global_sv.properties trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=21341 Log: JENKINS-3990 - Added global checkbox to indicate if the Hudson user names are to be used case sensitive or not.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/pom.xml
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21342
            Log:
            JENKINS-3990 - Added integration test for global configuring.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/pom.xml trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=21342 Log: JENKINS-3990 - Added integration test for global configuring.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21344
            Log:
            JENKINS-3990 - Game publisher now uses global configured value.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GamePublisher.java http://fisheye4.cenqua.com/changelog/hudson/?cs=21344 Log: JENKINS-3990 - Game publisher now uses global configured value.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java
            trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/ScoreCardAction/index.jelly
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionIntegrationTest.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionTest.java
            trunk/hudson/plugins/ci-game/src/test/resources/hudson/plugins/cigame/ScoreCardActionIntegrationTest.zip
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21374
            Log:
            JENKINS-3990 - Score card action now uses global configured value.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java trunk/hudson/plugins/ci-game/src/main/resources/hudson/plugins/cigame/ScoreCardAction/index.jelly trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionIntegrationTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionTest.java trunk/hudson/plugins/ci-game/src/test/resources/hudson/plugins/cigame/ScoreCardActionIntegrationTest.zip http://fisheye4.cenqua.com/changelog/hudson/?cs=21374 Log: JENKINS-3990 - Score card action now uses global configured value.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : redsolo
            Path:
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/CaseInsensitiveUserIdComparator.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GameDescriptor.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/LeaderBoardAction.java
            trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/LeaderBoardActionTest.java
            trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionIntegrationTest.java
            trunk/hudson/plugins/ci-game/src/test/resources/hudson/plugins/cigame/GameDescriptorIntegrationTest/testLoadingCaseInsensitiveFlagWorks.zip
            http://fisheye4.cenqua.com/changelog/hudson/?cs=21408
            Log:
            [FIXED JENKINS-3990] - If configured scores are not assigned to user with same casing. This will hide some users from the leaderboard, so it is advisable that the scores are reset before continuing the game.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/CaseInsensitiveUserIdComparator.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/GameDescriptor.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/LeaderBoardAction.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/ScoreCardAction.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/GameDescriptorIntegrationTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/LeaderBoardActionTest.java trunk/hudson/plugins/ci-game/src/test/java/hudson/plugins/cigame/ScoreCardActionIntegrationTest.java trunk/hudson/plugins/ci-game/src/test/resources/hudson/plugins/cigame/GameDescriptorIntegrationTest/testLoadingCaseInsensitiveFlagWorks.zip http://fisheye4.cenqua.com/changelog/hudson/?cs=21408 Log: [FIXED JENKINS-3990] - If configured scores are not assigned to user with same casing. This will hide some users from the leaderboard, so it is advisable that the scores are reset before continuing the game.

              People

              • Assignee:
                redsolo redsolo
                Reporter:
                bids bids
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: