Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40161

Allow StepExecution.onResume to throw Exception

    Details

    • Similar Issues:

      Description

      Proposal:

      Change onResume to throw Exception. (Would still be binary-compatible.) FlowExecutionList.ItemListenerImpl.onLoaded would then need to catch exceptions and call StepContext.onFailure. Like AbstractStepExecutionImpl, this would rely on transient fields holding the contextual object; the improvement would be that a failure in StepContext.get would stop anything else in onResume (such as the setupTimer methods in TimeoutStepExecution, SleepStep.Execution, or DurableTaskStep.Execution) from running.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Would ease migration of steps after JENKINS-39134.

            Show
            jglick Jesse Glick added a comment - Would ease migration of steps after JENKINS-39134 .
            Hide
            jglick Jesse Glick added a comment -

            Might fix issues like JENKINS-37486, or at least make the root cause more obvious.

            Show
            jglick Jesse Glick added a comment - Might fix issues like JENKINS-37486 , or at least make the root cause more obvious.

              People

              • Assignee:
                Unassigned
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: