Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40262

Promotions created with job DSL are not visible

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I have a very simple promotion:

                promotion {
                    name('Production')
                    icon("star-gold")
                    conditions {
                        manual('teamA,teamB')
                    }
                    actions {
                      copyArtifacts('$PROMOTED_JOB_NAME') {
                        includePatterns('envInject.properties')
                        buildSelector {
                            buildNumber('$PROMOTED_NUMBER')
                        }
                       }
                        downstreamParameterized {
                          trigger("Dist-To-Prod"){
                            block {
                                buildStepFailure('never')
                                failure('FAILURE')
                                unstable('UNSTABLE')
                            }
                            parameters {
                              propertiesFile('envInject.properties',true)
                            }
                          }
                        }
                    }
                }
      

      When I go to the generated job promotion status, I don't see anything.
      If I go to the job configuration, and without changing anything, click on "Save", the promotions become visible.

      Looking the promotion XML, it seems like the isVisible element is missing.

      Am I missing something?

        Attachments

          Issue Links

            Activity

            Show
            imriz Imri Zvik added a comment - It seems like https://github.com/jenkinsci/promoted-builds-plugin/pull/76 and https://github.com/jenkinsci/promoted-builds-plugin/pull/82 didn't take each other into account.
            Hide
            daspilker Daniel Spilker added a comment -

            Redirecting to Oleg Nenashev because this seems to be an issue in the Promoted Builds plugin.

            Show
            daspilker Daniel Spilker added a comment - Redirecting to Oleg Nenashev because this seems to be an issue in the Promoted Builds plugin.
            Hide
            imriz Imri Zvik added a comment -

            Looking into this more carefully, it seems that this is actually a duplicate of JENKINS-41029, and maybe another small bug

            In my specific case, I had promotions both in the template (using()) and in the DSL it self.
            This resulted this badly formatted XML:

                <properties>
                    <hudson.plugins.promoted__builds.JobPropertyImpl plugin="promoted-builds@2.29-SNAPSHOT">
                        <activeProcessNames>
                            <string>from_template</string>
                        </activeProcessNames>
                    </hudson.plugins.promoted__builds.JobPropertyImpl>
                    <hudson.plugins.promoted__builds.JobPropertyImpl plugin="promoted-builds@2.29-SNAPSHOT">
                        <activeProcessNames>
                            <string>from_dsl</string>
                        </activeProcessNames>
                    </hudson.plugins.promoted__builds.JobPropertyImpl>
                </properties>
            

            Also, the "from_dsl" promotion got copied fully into the generated job, but the "from_template" was only copied into the xml.
            When you try to go to promotion in the UI in this state, the screen will be empty.
            Going into the job configuration, and clicking on save will remove the first promotion (from template), and will make the "from_dsl" one visible.

            Show
            imriz Imri Zvik added a comment - Looking into this more carefully, it seems that this is actually a duplicate of JENKINS-41029 , and maybe another small bug In my specific case, I had promotions both in the template (using()) and in the DSL it self. This resulted this badly formatted XML: <properties> <hudson.plugins.promoted__builds.JobPropertyImpl plugin= "promoted-builds@2.29-SNAPSHOT" > <activeProcessNames> <string>from_template</string> </activeProcessNames> </hudson.plugins.promoted__builds.JobPropertyImpl> <hudson.plugins.promoted__builds.JobPropertyImpl plugin= "promoted-builds@2.29-SNAPSHOT" > <activeProcessNames> <string>from_dsl</string> </activeProcessNames> </hudson.plugins.promoted__builds.JobPropertyImpl> </properties> Also, the "from_dsl" promotion got copied fully into the generated job, but the "from_template" was only copied into the xml. When you try to go to promotion in the UI in this state, the screen will be empty. Going into the job configuration, and clicking on save will remove the first promotion (from template), and will make the "from_dsl" one visible.

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                imriz Imri Zvik
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: