After Update to Jenkins 2.34 and 2.35 we see several exceptions "WARNING: Caught exception evaluating: build.badgeActions" (see below) in the log file. We could easily reproduce this in a fresh new setup without additional installed plugins by:

• Setup a new Build-Job and activate "Discard old builds".
• Execute this job.
• Navigate to the build and activate "Keep this build forever"
• Access the job site.
  • => Exception in log file (see below)
  • => Lock icon "KeepBuild" not shown. In case of promotions the icons also not appear.

After deactivating "Keep this build forever" the exception does not appear and promotion icons/stars appear again.

Exception:

… hudson.ExpressionFactory2$JexlExpression evaluate
WARNING: Caught exception evaluating: build.badgeActions in /job/test/. Reason: java.lang.reflect.InvocationTargetException
java.lang.reflect.InvocationTargetException
        at …
Caused by: java.lang.UnsupportedOperationException
        at java.util.Collections$UnmodifiableCollection.add(Collections.java:1055)
        at hudson.model.Run.getBadgeActions(Run.java:483)
        ... 161 more