Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40290

unit tests failures in core on windows

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: core
    • Labels:
    • Environment:
    • Similar Issues:

      Description

      See attached log and surefire reports directory.

      Failed tests:
        RunTest.getLogReturnsAnRightOrder:192 expected:<[...truncated [6]8 B...]> but was:<[...truncated [7]8 B...]>
        SecretRewriterTest.recursionDetection:100 assert 6==sw.rewriteRecursive(t, st)
              | |  |                |  |
              | |  5                |  hudson.util.StreamTaskListener@19855799
              | |                   C:\workarea\source\github\jenkinsci\temp\jenkins\core\target\junit5825166057877884911\t
              | hudson.util.SecretRewriter@bd09a26
              false
        RunIdMigratorTest.legacy:86 expected:<...otherstuff>
      </run>'}[, 99=?2014-01-02_03-04-05, lastFailedBuild=?-1, lastSuccessfulBuild=?99]}> but was:<...otherstuff>
      </run>'}[]}>
        RunIdMigratorTest.reRunMigration:105 expected:<.../number>
      </run>'}, 9[8=?2014-01-02_03-04-04, 99={build.xml='<?xml version='1.0' encoding='UTF-8'?>
      <run>
        <stuff>ok</stuff>
        <timestamp>1388649845000</timestamp>
        <otherstuff>ok</otherstuff>
      </run>'}, lastFailedBuild=?-1, lastSuccessfulBuild=?99]}> but was:<.../number>
      </run>'}, 9[9={build.xml='<?xml version='1.0' encoding='UTF-8'?>
      <run>
        <stuff>ok</stuff>
        <timestamp>1388649845000</timestamp>
        <otherstuff>ok</otherstuff>
      </run>'}]}>
        RunIdMigratorTest.reverseAfterNewBuilds:129 expected:<{[1=?2014-01-02_03-04-05, ]2014-01-02_03-04-05=...> but was:<{[]2014-01-02_03-04-05=...>
        RunIdMigratorTest.reverseImmediately:117 expected:<...erstuff>
      </run>'}, l[astFailedBuild=?-1, lastSuccessfulBuild=?99, l]egacyIds='2014-01-02...> but was:<...erstuff>
      </run>'}, l[]egacyIds='2014-01-02...>
        RunIdMigratorTest.reverseMatrixAfterNewBuilds:139 expected:<{[1=?2014-01-02_03-04-05, ]2014-01-02_03-04-05=...> but was:<{[]2014-01-02_03-04-05=...>
        RunIdMigratorTest.reverseMavenAfterNewBuilds:149 expected:<{[1=?2014-01-02_03-04-05, ]2014-01-02_03-04-05=...> but was:<{[]2014-01-02_03-04-05=...>
        VirtualFileTest.outsideSymlinks:53
      
      Tests run: 3484, Failures: 9, Errors: 0, Skipped: 9
      

        Attachments

          Issue Links

            Activity

            Hide
            batmat Baptiste Mathus added a comment -

            Created JENKINS-40746 to followup on the failures on that module and not mix discussions (though there's still probably a link).

            Show
            batmat Baptiste Mathus added a comment - Created JENKINS-40746 to followup on the failures on that module and not mix discussions (though there's still probably a link).
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/test/java/hudson/model/RunTest.java
            http://jenkins-ci.org/commit/jenkins/5483ee13833bb44ff611e8da3a8c74379ba26e11
            Log:
            Merge pull request #2690 from batmat/fix-windows-build

            JENKINS-40290 Fix test failing on Windows because of line feed assumption

            Compare: https://github.com/jenkinsci/jenkins/compare/6f9837683905...5483ee13833b

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/test/java/hudson/model/RunTest.java http://jenkins-ci.org/commit/jenkins/5483ee13833bb44ff611e8da3a8c74379ba26e11 Log: Merge pull request #2690 from batmat/fix-windows-build JENKINS-40290 Fix test failing on Windows because of line feed assumption Compare: https://github.com/jenkinsci/jenkins/compare/6f9837683905...5483ee13833b
            Hide
            teilo James Nord added a comment -

            @batmat not when I ran it (but make sure you use -Dconcurrency=1 otherwise you have a whole slew of random garbage JENKINS-37177)

            I will run again.

            Show
            teilo James Nord added a comment - @batmat not when I ran it (but make sure you use -Dconcurrency=1 otherwise you have a whole slew of random garbage JENKINS-37177 ) I will run again.
            Hide
            slide_o_mix Alex Earl added a comment -

            Hasn't this been resolved now?

            Show
            slide_o_mix Alex Earl added a comment - Hasn't this been resolved now?
            Hide
            teilo James Nord added a comment -

            Alex Earl a lot of the tests where "fixed" by ignoring them on windows. https://ci.jenkins.io/job/Core/job/jenkins/job/master/510/testReport/hudson.model/JobTest/testDoNotAutoTrimExistingUntrimmedNames/

            So in one way yes the tests no longer fail - but in another way no - no as there are currently 103 skipped tests and I would guess a large proportion of them are assumeFalse("not on windows" , Functions.isWindows())

            Show
            teilo James Nord added a comment - Alex Earl a lot of the tests where "fixed" by ignoring them on windows. https://ci.jenkins.io/job/Core/job/jenkins/job/master/510/testReport/hudson.model/JobTest/testDoNotAutoTrimExistingUntrimmedNames/ So in one way yes the tests no longer fail - but in another way no - no as there are currently 103 skipped tests and I would guess a large proportion of them are assumeFalse("not on windows" , Functions.isWindows())

              People

              • Assignee:
                Unassigned
                Reporter:
                teilo James Nord
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated: