Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40413

Create JNLPMacProvider interface and have AccessControlled inherit from it

    Details

    • Type: Improvement
    • Status: Open (View Workflow)
    • Priority: Trivial
    • Resolution: Unresolved
    • Component/s: core
    • Labels:
    • Similar Issues:

      Description

      It is a follow-up to https://github.com/jenkinsci/jenkins/pull/2658. JENKINS-40286 allows SlaveComputers to change the way the JnlpMac is generated, however ideally any AccessControlled could change override the default behavior.

      Comment from Oleg Nenashev

      > I would rather introduce a new interface like JNLPMacProvider with getJnlpMac(). In such case other AccessControlled items will be also able to tweak the logic by implementing this interface. Maybe deserves a follow-up JIRA ticket

        Attachments

          Issue Links

            Activity

            Hide
            kbrowder Kevin Browder added a comment - - edited

            Hmm, JnlpClientDatabase basically goes in the opposite direction of this and more-or-less hard-codes the mac generation to node name. It's not clear to me what the easiest way to make the jnlp mac customizable by SlaveComputer.getJnlpMac given this.

            Show
            kbrowder Kevin Browder added a comment - - edited Hmm, JnlpClientDatabase basically goes in the opposite direction of this and more-or-less hard-codes the mac generation to node name. It's not clear to me what the easiest way to make the jnlp mac customizable by SlaveComputer.getJnlpMac given this.

              People

              • Assignee:
                Unassigned
                Reporter:
                kbrowder Kevin Browder
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: