Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40434

Pagination for branches and ATH coverage

    Details

    • Similar Issues:
    • Sprint:
      frank

      Description

      Paging currently has some problems.

      1) broken on activity (PR has been merged, see below)
      2) Branches hides show more button erroneously

      In Scope

      • Write an ATH for branches and activity pagination
      • Fix the bug with activity button: ttps://github.com/jenkinsci/blueocean-plugin/pull/658
      • Fix branches
      • Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now? confirm with test coverage

      Steps to reproduce broken pagination on activity

      1. Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
      2. Click show more

      Console error

      Uncaught TypeError: _this2.pager.fetchMore is not a function
          at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
          at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
          at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
          at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
          at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
          at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
          at Array.forEach (native)
          at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
          at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
          at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
      

      cc Ivan Meredith

        Attachments

          Activity

          jamesdumay James Dumay created issue -
          jamesdumay James Dumay made changes -
          Field Original Value New Value
          Sprint frank [ 156 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Priority Minor [ 4 ] Blocker [ 1 ]
          jamesdumay James Dumay made changes -
          Description *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}
          *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}
          jamesdumay James Dumay made changes -
          Description *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}
          *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug
          * Write an ATH
          michaelneale Michael Neale made changes -
          Description *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug
          * Write an ATH
          *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug
          * Write an ATH
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js)

          NOT SO SMART FETCH NOW HA!
          michaelneale Michael Neale made changes -
          Description *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug
          * Write an ATH
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js)

          NOT SO SMART FETCH NOW HA!
          *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug
          * Write an ATH
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now?

          cc [~imeredith]
          michaelneale Michael Neale made changes -
          Description *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug
          * Write an ATH
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now?

          cc [~imeredith]
          *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug: ttps://github.com/jenkinsci/blueocean-plugin/pull/658
          * Write an ATH
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now?

          cc [~imeredith]
          michaelneale Michael Neale made changes -
          Assignee Ivan Meredith [ imeredith ]
          michaelneale Michael Neale made changes -
          Priority Blocker [ 1 ] Major [ 3 ]
          michaelneale Michael Neale made changes -
          Summary REGRESSION: pagination is broken on activity Pagination needs ATH coverage
          michaelneale Michael Neale made changes -
          Description *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug: ttps://github.com/jenkinsci/blueocean-plugin/pull/658
          * Write an ATH
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now?

          cc [~imeredith]
          *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug: ttps://github.com/jenkinsci/blueocean-plugin/pull/658
          * Write an ATH
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now? confirm with test coverage

          cc [~imeredith]
          michaelneale Michael Neale made changes -
          Summary Pagination needs ATH coverage Pagination for branches and ATH coverage
          michaelneale Michael Neale made changes -
          Description *Steps to reproduce*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}

          *In Scope*
          * Fix the bug: ttps://github.com/jenkinsci/blueocean-plugin/pull/658
          * Write an ATH
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now? confirm with test coverage

          cc [~imeredith]
          Paging currently has some problems.

          1) broken on activity (PR has been merged, see below)
          2) Branches hides show more button erroneously

          *In Scope*
          * Write an ATH for branches and activity pagination
          * Fix the bug with activity button: ttps://github.com/jenkinsci/blueocean-plugin/pull/658
          * Fix branches
          * Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now? confirm with test coverage


          *Steps to reproduce broken pagination on activity*
          # Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
          # Click {{show more}}

          *Console error*
          {noformat}
          Uncaught TypeError: _this2.pager.fetchMore is not a function
              at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
              at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
              at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
              at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
              at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
              at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
              at Array.forEach (native)
              at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
              at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
              at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
          {noformat}


          cc [~imeredith]
          michaelneale Michael Neale made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          jamesdumay James Dumay made changes -
          Sprint frank [ 156 ] frank, christmas [ 156, 176 ]
          jamesdumay James Dumay made changes -
          Epic Link JENKINS-35742 [ 171802 ]
          jamesdumay James Dumay made changes -
          Sprint frank, christmas [ 156, 176 ] frank [ 156 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Sprint frank [ 156 ] frank, panthalassa [ 156, 221 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint frank, panthalassa [ 156, 221 ] frank, up next [ 156, 171 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Sprint frank, up next [ 156, 171 ] frank [ 156 ]
          jamesdumay James Dumay made changes -
          Sprint frank [ 156 ] frank, 1.1 [ 156, 251 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Labels technical-debt
          michaelneale Michael Neale made changes -
          Priority Critical [ 2 ] Minor [ 4 ]
          michaelneale Michael Neale made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          jamesdumay James Dumay made changes -
          Sprint frank, Blue Ocean up next [ 156, 251 ] frank [ 156 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jbriden Jenn Briden made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              imeredith Ivan Meredith
              Reporter:
              jamesdumay James Dumay
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: