Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40521

Orphaned branch projects should not be considered buildable

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      WorkflowJob should consult WorkflowJobProperty for isBuildable, and BranchJobProperty should in turn consult Branch.isBuildable. This should prevent orphaned jobs from being scheduled.

      This attempt by Stephen Connolly is probably wrong, as it would not affect, for example, TimerTrigger. It is not a permission check which we want, but rather an emulation of disablement.

        Attachments

          Issue Links

            Activity

            Hide
            hrmpw Patrick Wolf added a comment -

            @rtyler says this PR was closed but has continued to build every 10 minutes based on polling:

            https://ci.jenkins.io/job/Infra/job/azure/view/Pull%20Requests/job/PR-5/

            Show
            hrmpw Patrick Wolf added a comment - @rtyler says this PR was closed but has continued to build every 10 minutes based on polling: https://ci.jenkins.io/job/Infra/job/azure/view/Pull%20Requests/job/PR-5/
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJobProperty.java
            http://jenkins-ci.org/commit/workflow-job-plugin/333bd368a0d705b8273450bce6f9c7f6373aa651
            Log:
            JENKINS-40521 Added WorkflowJobProperty.isBuildable.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJobProperty.java http://jenkins-ci.org/commit/workflow-job-plugin/333bd368a0d705b8273450bce6f9c7f6373aa651 Log: JENKINS-40521 Added WorkflowJobProperty.isBuildable.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJobProperty.java
            http://jenkins-ci.org/commit/workflow-job-plugin/c2bb083e4c21baa50c94d5fd57f386a8a82fcebd
            Log:
            Merge pull request #37 from jglick/buildable-orphan-JENKINS-40521

            JENKINS-40521 Added WorkflowJobProperty.isBuildable

            Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/00d7e14f4613...c2bb083e4c21

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJobProperty.java http://jenkins-ci.org/commit/workflow-job-plugin/c2bb083e4c21baa50c94d5fd57f386a8a82fcebd Log: Merge pull request #37 from jglick/buildable-orphan- JENKINS-40521 JENKINS-40521 Added WorkflowJobProperty.isBuildable Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/00d7e14f4613...c2bb083e4c21
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/multibranch/BranchJobProperty.java
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/1ba8c225ca6de7ff27c825356a310f9684466613
            Log:
            [FIXED JENKINS-40521] Mark orphaned branch projects as unbuildable.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/multibranch/BranchJobProperty.java src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/1ba8c225ca6de7ff27c825356a310f9684466613 Log: [FIXED JENKINS-40521] Mark orphaned branch projects as unbuildable.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: