Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40765

Make Release Plugin compatible with pipeline

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Allow to trigger release plugin from a pipeline dsl. It should be similar to trigger job's build.

      To support this the plugin would need to be refactored according to pipeline development instructions: https://github.com/jenkinsci/pipeline-plugin/blob/master/DEVGUIDE.md

        Attachments

          Activity

          estarter Alexey M created issue -
          Hide
          estarter Alexey M added a comment -

          Hi,

          I made a corresponding change, see the pull request https://github.com/jenkinsci/release-plugin/pull/22
          Could you please take a look on the modification.

          Oleg Nenashev FYI

          Cheers

          Show
          estarter Alexey M added a comment - Hi, I made a corresponding change, see the pull request https://github.com/jenkinsci/release-plugin/pull/22 Could you please take a look on the modification. Oleg Nenashev FYI Cheers
          jglick Jesse Glick made changes -
          Field Original Value New Value
          Labels pipeline
          estarter Alexey M made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: estarter
          Path:
          pom.xml
          src/main/java/hudson/plugins/release/SafeParametersAction.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseQueueListener.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseStep.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseStepExecution.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerAction.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerListener.java
          src/main/resources/hudson/plugins/release/pipeline/Messages.properties
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/DescriptorImpl/parameters.groovy
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.jelly
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.properties
          src/test/java/hudson/plugins/release/pipeline/ReleaseStepTest.java
          http://jenkins-ci.org/commit/release-plugin/1f9b17f72bdab24531cf7eb8f8ef52fdbadca417
          Log:
          JENKINS-40765 add pipeline support (#22)

          • fix after code review
          • remove guice
          • allow to schedule release when build is in queue

          rewrite SafeParametersAction in order to use parent's parameters field
          that allows to benefit on correct execution of ParametersAction#shouldSchedule method

          • acquire the lock only when needed
          • fix after code review
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: estarter Path: pom.xml src/main/java/hudson/plugins/release/SafeParametersAction.java src/main/java/hudson/plugins/release/pipeline/ReleaseQueueListener.java src/main/java/hudson/plugins/release/pipeline/ReleaseStep.java src/main/java/hudson/plugins/release/pipeline/ReleaseStepExecution.java src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerAction.java src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerListener.java src/main/resources/hudson/plugins/release/pipeline/Messages.properties src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/DescriptorImpl/parameters.groovy src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.jelly src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.properties src/test/java/hudson/plugins/release/pipeline/ReleaseStepTest.java http://jenkins-ci.org/commit/release-plugin/1f9b17f72bdab24531cf7eb8f8ef52fdbadca417 Log: JENKINS-40765 add pipeline support (#22) JENKINS-40765 add pipeline support fix after code review remove guice allow to schedule release when build is in queue rewrite SafeParametersAction in order to use parent's parameters field that allows to benefit on correct execution of ParametersAction#shouldSchedule method acquire the lock only when needed fix after code review
          oleg_nenashev Oleg Nenashev made changes -
          Assignee Peter Hayes [ petehayes ] Oleg Nenashev [ oleg_nenashev ]
          oleg_nenashev Oleg Nenashev made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Another PR with fixes of the implementation by Alexey M: https://github.com/jenkinsci/release-plugin/pull/24

          Show
          oleg_nenashev Oleg Nenashev added a comment - Another PR with fixes of the implementation by Alexey M : https://github.com/jenkinsci/release-plugin/pull/24
          oleg_nenashev Oleg Nenashev made changes -
          Priority Minor [ 4 ] Major [ 3 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/pipeline-plugin/b293156039a223ee592298cbd762fed9291f68a5
          Log:
          Merge pull request #426 from estarter/patch-1

          JENKINS-40765 JENKINS-40766 Add release/m2release plugins to the list

          Compare: https://github.com/jenkinsci/pipeline-plugin/compare/be4c63608ad5...b293156039a2

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/pipeline-plugin/b293156039a223ee592298cbd762fed9291f68a5 Log: Merge pull request #426 from estarter/patch-1 JENKINS-40765 JENKINS-40766 Add release/m2release plugins to the list Compare: https://github.com/jenkinsci/pipeline-plugin/compare/be4c63608ad5...b293156039a2
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/hudson/plugins/release/SafeParametersAction.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseStep.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseStepExecution.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerAction.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerListener.java
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/DescriptorImpl/parameters.groovy
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.jelly
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.properties
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/help-job.html
          http://jenkins-ci.org/commit/release-plugin/82a1b5db58e2809efb6a0fe77915800cfba6bda2
          Log:
          JENKINS-40765 - Apply some fixes after the manual testing (#24)

          • Update Parent POM to the latest version
          • JENKINS-40765 - ReleaseStep#parameters.groovy should return proper message when specifying a Pipeline job
          • JENKINS-40765 - Cleanup support of folders in the release() step

          Just in case we need to change them

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/hudson/plugins/release/SafeParametersAction.java src/main/java/hudson/plugins/release/pipeline/ReleaseStep.java src/main/java/hudson/plugins/release/pipeline/ReleaseStepExecution.java src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerAction.java src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerListener.java src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/DescriptorImpl/parameters.groovy src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.jelly src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.properties src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/help-job.html http://jenkins-ci.org/commit/release-plugin/82a1b5db58e2809efb6a0fe77915800cfba6bda2 Log: JENKINS-40765 - Apply some fixes after the manual testing (#24) Update Parent POM to the latest version JENKINS-40765 - Restore the broken SafeParameters action JENKINS-40765 - ReleaseStep#parameters.groovy should return proper message when specifying a Pipeline job JENKINS-40765 - Cleanup support of folders in the release() step JENKINS-40765 - Restrict the newly introduced classes Just in case we need to change them
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Released it in 2.7

          Show
          oleg_nenashev Oleg Nenashev added a comment - Released it in 2.7
          oleg_nenashev Oleg Nenashev made changes -
          Status In Review [ 10005 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          mustafau Mustafa Ulu added a comment -

          I couldn't trigger parallel releases with latest version.

          Also "wait: false" didn't work.

          Show
          mustafau Mustafa Ulu added a comment - I couldn't trigger parallel releases with latest version. Also "wait: false" didn't work.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Mustafa Ulu Please create separate JIRA issues for it. Will try to process on the weekend, but no guarantee

          Show
          oleg_nenashev Oleg Nenashev added a comment - Mustafa Ulu Please create separate JIRA issues for it. Will try to process on the weekend, but no guarantee
          Hide
          nfalco Nikolas Falco added a comment -

          The title of this issue it's misleading because it's not a real support to describe a steps and parameter of a release wrapper but enable call release job of of other non pipeline job. Since there is not documentation and a bug that prevent to have a pipeline syntax after spent 2g I realise this plugin could not be used to release a pipeline job with extra parameters and pre/post build steps

          Show
          nfalco Nikolas Falco added a comment - The title of this issue it's misleading because it's not a real support to describe a steps and parameter of a release wrapper but enable call release job of of other non pipeline job. Since there is not documentation and a bug that prevent to have a pipeline syntax after spent 2g I realise this plugin could not be used to release a pipeline job with extra parameters and pre/post build steps

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              estarter Alexey M
            • Votes:
              3 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: