Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40876

ObjectMetadataAction objectUrl never gets populated for PRs or Branches

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I used the 2.0.0-beta-1 release and ran a index scan over my repository. I had a mixture of new and existing branches.

      While they all got populated with ObjectMetadataAction the objectUrl never got populated for any of my branches or pull requests.

      Interesting the javadoc for ObjectMetadataAction states that it will only produce a URL for a SCMHead if it is a Pull Request. We should be providing a URL for both PRs and Branches.

      For Branch URLs we want
      https://github.com/$ORG_NAME/$REPO_NAME/tree/$BRANCH_NAME

      For PR URLs we want
      https://github.com/$ORG_NAME/$REPO_NAME/pull/$PR

        Attachments

          Issue Links

            Activity

            Hide
            jamesdumay James Dumay added a comment -

            Nice! Thanks Stephen

            Show
            jamesdumay James Dumay added a comment - Nice! Thanks Stephen
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/ItemColumn.java
            src/main/resources/jenkins/branch/ItemColumn/column.jelly
            http://jenkins-ci.org/commit/branch-api-plugin/982d7e1171d61c704dcf013936c0f89c0b871691
            Log:
            JENKINS-40876 Fixes to display of object metadata

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/ItemColumn.java src/main/resources/jenkins/branch/ItemColumn/column.jelly http://jenkins-ci.org/commit/branch-api-plugin/982d7e1171d61c704dcf013936c0f89c0b871691 Log: JENKINS-40876 Fixes to display of object metadata
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/ItemColumn.java
            src/main/resources/jenkins/branch/ItemColumn/column.jelly
            http://jenkins-ci.org/commit/branch-api-plugin/99647e920bbee58a30fcc50ae0bf869a0195d908
            Log:
            Merge pull request #69 from stephenc/jenkins-40876

            JENKINS-40876 Fixes to display of object metadata

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/d55f2b4369e0...99647e920bbe

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/ItemColumn.java src/main/resources/jenkins/branch/ItemColumn/column.jelly http://jenkins-ci.org/commit/branch-api-plugin/99647e920bbee58a30fcc50ae0bf869a0195d908 Log: Merge pull request #69 from stephenc/jenkins-40876 JENKINS-40876 Fixes to display of object metadata Compare: https://github.com/jenkinsci/branch-api-plugin/compare/d55f2b4369e0...99647e920bbe
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/e1f132e1724b56599bab43d32806642488dd346f
            Log:
            [FIXED JENKINS-40876] Retrieve the ObjectMetadataAction instances for heads

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/e1f132e1724b56599bab43d32806642488dd346f Log: [FIXED JENKINS-40876] Retrieve the ObjectMetadataAction instances for heads

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: