Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40920

Credentials migration fails if project has more than one liquibase builder

    Details

    • Similar Issues:

      Description

      if a project has more than one liquibase builder (either update or rollback), only the first will have any credentials migrated.

      The errant code is located in CredentialsMigrator. Specifically:

      buildersList.get(AbstractLiquibaseBuilder.class);

      should be changed to "getAll"

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: propspero238
          Path:
          src/main/java/org/jenkinsci/plugins/liquibase/evaluator/CredentialsMigrator.java
          src/test/java/org/jenkinsci/plugins/liquibase/evaluator/CredentialsMigratorTest.java
          src/test/resources/scripted-upgrade-test/oldauth_job_config.xml
          src/test/resources/scripted-upgrade-test/unsecured-jenkins.xml
          src/test/resources/scripted-upgrade-test/upgrade-credentials-test.sh
          src/test/resources/update-test-data.zip
          http://jenkins-ci.org/commit/liquibase-runner-plugin/40731449b9dba29bc91019d95fab224109225c50
          Log:
          JENKINS-40920
          no longer assuming just one liquibase builder per project.
          Also better way of testing migration

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: propspero238 Path: src/main/java/org/jenkinsci/plugins/liquibase/evaluator/CredentialsMigrator.java src/test/java/org/jenkinsci/plugins/liquibase/evaluator/CredentialsMigratorTest.java src/test/resources/scripted-upgrade-test/oldauth_job_config.xml src/test/resources/scripted-upgrade-test/unsecured-jenkins.xml src/test/resources/scripted-upgrade-test/upgrade-credentials-test.sh src/test/resources/update-test-data.zip http://jenkins-ci.org/commit/liquibase-runner-plugin/40731449b9dba29bc91019d95fab224109225c50 Log: JENKINS-40920 no longer assuming just one liquibase builder per project. Also better way of testing migration

            People

            • Assignee:
              prospero238 Keith Collison
              Reporter:
              prospero238 Keith Collison
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: