Details

    • Similar Issues:
    • Sprint:
      iapetus

      Description

      (this is more just a question, so I dont' forget)

      I noted that the script step just allows normal children steps, but this doesn't quite make sense. I thought the idea was that this would take arbitrary script content (perhaps a text box, or a wider selection of steps, or something).

      Related, if I paste in the following pipeline:

      pipeline {
          
          agent any 
          stages {
              stage('first') {
                  steps {
                      script {
                          sh 'echo 42'
                          
                      }
                      
                  }
              }
          }
          
      }
      

      then I don't see a way to get to the "echo 42" shell script step.

        Attachments

          Issue Links

            Activity

            Hide
            kzantow Keith Zantow added a comment -

            I can add a custom editor for this one, but it looks like the metadata is wrong.

            This step has a 'scriptBlock' argument with the text of the script. But the metadata has no parameters listed.

            Show
            kzantow Keith Zantow added a comment - I can add a custom editor for this one, but it looks like the metadata is wrong. This step has a 'scriptBlock' argument with the text of the script. But the metadata has no parameters listed.
            Hide
            michaelneale Michael Neale added a comment -

            Keith Zantow I must say I am shocked, SHOCKED that the meta data might be wrong.

            Show
            michaelneale Michael Neale added a comment - Keith Zantow I must say I am shocked, SHOCKED that the meta data might be wrong.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Keith Zantow
            Path:
            package.json
            pom.xml
            src/main/js/components/Sheets.jsx
            src/main/js/components/editor/AgentConfiguration.jsx
            src/main/js/components/editor/EditorMain.jsx
            src/main/js/components/editor/EditorPage.jsx
            src/main/js/components/editor/EditorPipelineGraph.jsx
            src/main/js/components/editor/EditorStepDetails.jsx
            src/main/js/components/editor/EditorStepList.jsx
            src/main/js/components/editor/EnvironmentConfiguration.jsx
            src/main/js/components/editor/NewPipelineTemplate.json
            src/main/js/components/editor/ValidationMessageList.jsx
            src/main/js/components/editor/common.jsx
            src/main/js/components/editor/steps/GenericStepEditor.jsx
            src/main/js/components/editor/steps/PipelineScriptStepEditor.jsx
            src/main/js/components/properties/BooleanPropertyInput.jsx
            src/main/js/components/properties/DecimalPropertyInput.jsx
            src/main/js/components/properties/IntegerPropertyInput.jsx
            src/main/js/components/properties/ListPropertyInput.jsx
            src/main/js/components/properties/StringPropertyInput.jsx
            src/main/js/services/PipelineMetadataService.js
            src/main/js/services/PipelineStore.js
            src/main/js/services/PipelineSyntaxConverter.js
            src/main/js/services/PipelineValidator.js
            src/main/js/services/fetchClassic.js
            src/main/less/editor.less
            http://jenkins-ci.org/commit/blueocean-pipeline-editor-plugin/c341fddf36d316b599ec66df68fb7970b1d469a4
            Log:
            Pipeline validation and cleanup (#20)

            • basic working pipeline validator
            • Restyle pipeline
            • Handle top-level errors in parallel nodes
            • Fix z-index issue, dont include empty args
            • Fix default to agent any
            • Default new to NewPipelineTemplate
            • Editing child steps in container steps
            • JENKINS-41358 - stage-level agent not exported
            • JENKINS-41356 - Fix stage delete
            • JENKINS-41362 - edit 'script' with a textbox
            • Usage blurb for load/save dialog
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Keith Zantow Path: package.json pom.xml src/main/js/components/Sheets.jsx src/main/js/components/editor/AgentConfiguration.jsx src/main/js/components/editor/EditorMain.jsx src/main/js/components/editor/EditorPage.jsx src/main/js/components/editor/EditorPipelineGraph.jsx src/main/js/components/editor/EditorStepDetails.jsx src/main/js/components/editor/EditorStepList.jsx src/main/js/components/editor/EnvironmentConfiguration.jsx src/main/js/components/editor/NewPipelineTemplate.json src/main/js/components/editor/ValidationMessageList.jsx src/main/js/components/editor/common.jsx src/main/js/components/editor/steps/GenericStepEditor.jsx src/main/js/components/editor/steps/PipelineScriptStepEditor.jsx src/main/js/components/properties/BooleanPropertyInput.jsx src/main/js/components/properties/DecimalPropertyInput.jsx src/main/js/components/properties/IntegerPropertyInput.jsx src/main/js/components/properties/ListPropertyInput.jsx src/main/js/components/properties/StringPropertyInput.jsx src/main/js/services/PipelineMetadataService.js src/main/js/services/PipelineStore.js src/main/js/services/PipelineSyntaxConverter.js src/main/js/services/PipelineValidator.js src/main/js/services/fetchClassic.js src/main/less/editor.less http://jenkins-ci.org/commit/blueocean-pipeline-editor-plugin/c341fddf36d316b599ec66df68fb7970b1d469a4 Log: Pipeline validation and cleanup (#20) basic working pipeline validator Restyle pipeline Handle top-level errors in parallel nodes Fix z-index issue, dont include empty args Fix default to agent any Default new to NewPipelineTemplate Editing child steps in container steps JENKINS-41358 - stage-level agent not exported JENKINS-41356 - Fix stage delete JENKINS-41362 - edit 'script' with a textbox Usage blurb for load/save dialog

              People

              • Assignee:
                kzantow Keith Zantow
                Reporter:
                michaelneale Michael Neale
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: