JenkinsIcon indicating the project type

Jenkins

Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41522

There is some good stuff in PR#109 that is extra from JENKINS-40652 and should be considered

    Details

    • Similar Issues:

      Description

      Look at the changes in https://github.com/jenkinsci/github-branch-source-plugin/pull/109 and assess which of the changes additional to the fix for the regression in JENKINS-40652 should be picked up

        Attachments

          Issue Links

          is blocked by

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. JENKINS-43426 Refactor UX for GitHub and Bitbucket branch sources

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-40652 origin pr builds not treated as trusted

          • Major - Major loss of function.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jglick Jesse Glick added a comment -

            Is there anything useful left in that PR? I do not believe so.

            Show
            jglick Jesse Glick added a comment - Is there anything useful left in that PR? I do not believe so.
            Hide
            Permalink
            jamesdumay James Dumay added a comment -

            Stephen Connolly I like "Allow PR's from non-fork code" - thats how it should work.

            Show
            jamesdumay James Dumay added a comment - Stephen Connolly I like "Allow PR's from non-fork code" - thats how it should work.
            Hide
            Permalink
            ridgway Terry Ridgway added a comment - - edited

            I'm still seeing this issue with GitHub Branch Source plugin v2.0.4 and Jenkins v2.32.3, even though I've made sure the user id of the committer is part of the contributors list in Git. I've even uninstalled the plugin and reinstalled it, but I still cannot get Jenkins to use the PR branch version  (from origin, not from a fork) of the JenkinsFile instead of the master branch version. Is there a beta version of the plugin that I can try?

            Show
            ridgway Terry Ridgway added a comment - - edited I'm still seeing this issue with GitHub Branch Source plugin v2.0.4 and Jenkins v2.32.3, even though I've made sure the user id of the committer is part of the contributors list in Git. I've even uninstalled the plugin and reinstalled it, but I still cannot get Jenkins to use the PR branch version  (from origin, not from a fork) of the JenkinsFile instead of the master branch version. Is there a beta version of the plugin that I can try?
            Hide
            Permalink
            mslusarczyk Michal Slusarczyk added a comment -

            I proposed a fix for issue mentioned by Terry Ridgway

            Show
            mslusarczyk Michal Slusarczyk added a comment - I proposed a fix for issue mentioned by Terry Ridgway

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: