Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41528

Use local git reference repo to speed up cloning when using large jenkins instances

    Details

    • Similar Issues:

      Attachments

        Activity

        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Victor Martinez
        Path:
        CONTRIBUTING.md
        README.md
        src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefChecker.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java
        http://jenkins-ci.org/commit/jenkinslint-plugin/5eaffc09d9b048d3f03fa997811eaa4425913bfe
        Log:
        JENKINS-41528 Merge pull request #2 from jenkinsci/git_ref

        JENKINS-41528 Git Ref cloning might help to speed up your cloning time

        Compare: https://github.com/jenkinsci/jenkinslint-plugin/compare/2f95712cd9f7...5eaffc09d9b0

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: CONTRIBUTING.md README.md src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefChecker.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/5eaffc09d9b048d3f03fa997811eaa4425913bfe Log: JENKINS-41528 Merge pull request #2 from jenkinsci/git_ref JENKINS-41528 Git Ref cloning might help to speed up your cloning time Compare: https://github.com/jenkinsci/jenkinslint-plugin/compare/2f95712cd9f7...5eaffc09d9b0
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Victor Martinez
        Path:
        pom.xml
        src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractAction.java
        src/main/resources/org/jenkins/ci/plugins/jenkinslint/check/Messages.properties
        src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintActionTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelCheckerTestCase.java
        http://jenkins-ci.org/commit/jenkinslint-plugin/a581519c6d00a69ce55304bce391476c38f50b3f
        Log:
        JENKINS-41528 Git ref sub (#4)

        • Initial approach: suggest to use git ref repos in submodules... only when using git over 2.4+
        • Using the right method name and fixed some syntax errors
        • Added further tests and using the right plugin version validation
        • Still WIP
        • Fixed wrong asserts
        • Speeding up tests and using the AbstractAction pattern
        • Added missing import
        • Fixed test asserts
        • Git Plugin 2.4.1 version required another Jenkins Core Version which didn't have the MatrixProject bundled within the core and thereofre it required an explicit version, and I didn't want to depend on it therefore I used the reflection to avoid ti
        • Fixed flake test since it is not the right assert to test
        • Visualise Test output
        • Fixed unused imports
        • Added UI Test
        • Fixed hardcoded strings
        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: pom.xml src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractAction.java src/main/resources/org/jenkins/ci/plugins/jenkinslint/check/Messages.properties src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintActionTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/a581519c6d00a69ce55304bce391476c38f50b3f Log: JENKINS-41528 Git ref sub (#4) Initial approach: suggest to use git ref repos in submodules... only when using git over 2.4+ Using the right method name and fixed some syntax errors Added further tests and using the right plugin version validation Still WIP Fixed wrong asserts Speeding up tests and using the AbstractAction pattern Added missing import Fixed test asserts Git Plugin 2.4.1 version required another Jenkins Core Version which didn't have the MatrixProject bundled within the core and thereofre it required an explicit version, and I didn't want to depend on it therefore I used the reflection to avoid ti Fixed flake test since it is not the right assert to test Visualise Test output Fixed unused imports Added UI Test Fixed hardcoded strings
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Victor Martinez
        Path:
        README.md
        src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/JobLintAction.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/BFAChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveDescriptionChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveLabelChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/check/WindowsSlaveLaunchChecker.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractAction.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractCheck.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractSlaveCheck.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/InterfaceCheck.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/InterfaceSlaveCheck.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Job.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Lint.java
        src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Slave.java
        src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction/index.jelly
        src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration/config.jelly
        src/main/resources/org/jenkins/ci/plugins/jenkinslint/JobLintAction/index.jelly
        src/main/resources/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction/index.jelly
        src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintActionTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfigurationTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/JobLintActionTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintActionTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/AbstractCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveDescriptionCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveLabelCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java
        src/test/java/org/jenkins/ci/plugins/jenkinslint/check/WindowsSlaveLaunchCheckerTestCase.java
        http://jenkins-ci.org/commit/jenkinslint-plugin/8be91308e606ed60310171aee1634980d73400a1
        Log:
        JENKINS-45882 [JENKINS-41528] [JENKINS-42268] Jenkins Lint Global Configuration and new Checkers (#21)

        • Initial approach to use GlobalConfiguration
        • Added Lint global settings to enable/disable it
        • Disabling and Ignoring are now different status.
        • Fixed README.md
        • Added remaining checkers
        • Some minor bits and pieces to only show defects when they are in the right state
        • Fixed Tests to use the enabled flag
        • Enabled JobAction managed by GlobalSettings although the system property will be deprecated shortly
        • Added Threshold option in the Global Settings
        • Added TestCases for the new hardcoded threshold argument/variable
        • Added FormValidation Test Case for the Threshold value
        • SpeedUp TestCases usng the ClassRule pattern
        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: README.md src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration.java src/main/java/org/jenkins/ci/plugins/jenkinslint/JobLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/BFAChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveDescriptionChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveLabelChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/WindowsSlaveLaunchChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractCheck.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractSlaveCheck.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/InterfaceCheck.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/InterfaceSlaveCheck.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Job.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Lint.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Slave.java src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction/index.jelly src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration/config.jelly src/main/resources/org/jenkins/ci/plugins/jenkinslint/JobLintAction/index.jelly src/main/resources/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction/index.jelly src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintActionTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfigurationTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/JobLintActionTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintActionTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/AbstractCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveDescriptionCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveLabelCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/WindowsSlaveLaunchCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/8be91308e606ed60310171aee1634980d73400a1 Log: JENKINS-45882 [JENKINS-41528] [JENKINS-42268] Jenkins Lint Global Configuration and new Checkers (#21) Initial approach to use GlobalConfiguration Added Lint global settings to enable/disable it Disabling and Ignoring are now different status. Fixed README.md Added remaining checkers Saving global configuration based on the https://wiki.jenkins.io/display/JENKINS/Manage+global+settings+and+tools+installations Some minor bits and pieces to only show defects when they are in the right state Fixed Tests to use the enabled flag Enabled JobAction managed by GlobalSettings although the system property will be deprecated shortly Added Threshold option in the Global Settings Added TestCases for the new hardcoded threshold argument/variable Added FormValidation Test Case for the Threshold value SpeedUp TestCases usng the ClassRule pattern

          People

          • Assignee:
            v2v Victor Martinez
            Reporter:
            v2v Victor Martinez
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: