Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41535

NodeJS installation configuration is not persisted to file

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: nodejs-plugin
    • Labels:
      None
    • Environment:
      RHEL7/CentOS7 JDK8, Jenkins v2.42
    • Similar Issues:

      Description

      On Jenkins v2.42 using NodeJS v1.0 plugin, NodeJS installation configuration entered via the Global Tools Configuration UI ($JENKINS_HOME/configureTools/) is only persisted in-memory and not to file so when Jenkins is restarted, the configuration is lost.

      No errors are seen in the log. I've also tried manually uploading existing config file from a previous version but doesn't help.

      Uninstalled v1.0 and installed v0.2.2 on same test CentOS instance and nodejs.xml persisted fine.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstallation.java
            http://jenkins-ci.org/commit/nodejs-plugin/a15909ab05ac5a3267c92909c5a16bcaf9cc5482
            Log:
            [FIX JENKINS-41535] Fix persistence of nodejs installation tool invoking load and save methods.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstallation.java http://jenkins-ci.org/commit/nodejs-plugin/a15909ab05ac5a3267c92909c5a16bcaf9cc5482 Log: [FIX JENKINS-41535] Fix persistence of nodejs installation tool invoking load and save methods.
            Hide
            khobbits Robert Gornall added a comment -

            Thanks, seems to be writing the file to disk properly now.

            Show
            khobbits Robert Gornall added a comment - Thanks, seems to be writing the file to disk properly now.
            Hide
            nfalco Nikolas Falco added a comment -

            Thank for the confirm.

            Show
            nfalco Nikolas Falco added a comment - Thank for the confirm.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/test/java/jenkins/plugins/nodejs/tools/NodeJSInstallationTest.java
            src/test/resources/jenkins/plugins/nodejs/tools/NodeJSInstallationTest/load_at_startup/jenkins.plugins.nodejs.tools.NodeJSInstallation.xml
            http://jenkins-ci.org/commit/nodejs-plugin/98dfda43d6546145e2f50ddf935d0daefc6c9ff7
            Log:
            JENKINS-41535 Add a new test case

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/test/java/jenkins/plugins/nodejs/tools/NodeJSInstallationTest.java src/test/resources/jenkins/plugins/nodejs/tools/NodeJSInstallationTest/load_at_startup/jenkins.plugins.nodejs.tools.NodeJSInstallation.xml http://jenkins-ci.org/commit/nodejs-plugin/98dfda43d6546145e2f50ddf935d0daefc6c9ff7 Log: JENKINS-41535 Add a new test case
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/test/java/jenkins/plugins/nodejs/tools/NodeJSInstallationTest.java
            src/test/resources/jenkins/plugins/nodejs/tools/NodeJSInstallationTest/test_load_at_startup/jenkins.plugins.nodejs.tools.NodeJSInstallation.xml
            http://jenkins-ci.org/commit/nodejs-plugin/5993ea7074b9ba9365b70e6ec3112e451b2837e8
            Log:
            JENKINS-41535 Add a new test case

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/test/java/jenkins/plugins/nodejs/tools/NodeJSInstallationTest.java src/test/resources/jenkins/plugins/nodejs/tools/NodeJSInstallationTest/test_load_at_startup/jenkins.plugins.nodejs.tools.NodeJSInstallation.xml http://jenkins-ci.org/commit/nodejs-plugin/5993ea7074b9ba9365b70e6ec3112e451b2837e8 Log: JENKINS-41535 Add a new test case

              People

              • Assignee:
                nfalco Nikolas Falco
                Reporter:
                paulo774774 Paul Atkinson
              • Votes:
                15 Vote for this issue
                Watchers:
                20 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: