Details

    • Epic Link:
    • Sprint:
      pannonian, iapetus
    • Similar Issues:

      Description

      Need to make it look like the zeplin https://zpl.io/2ka0Kn

      • Font weight is incorrect for "Branch" and "Commit"
        • Lacks correct spacing as per mockup
      • Spacing between the Job name and run number is incorrect
      • Spacing / alignment between Branch/Commit labels & span
      • Spacing between icons & spans
      • Alignment of "branch" row and "commit" row
      • Always have to show “Commit: foo", either "Commit: ce87d64" or "Commit: N/A"

        Attachments

          Issue Links

            Activity

            Hide
            sophistifunk Josh McDonald added a comment -

            <-- Fix long-branch-name also

            Show
            sophistifunk Josh McDonald added a comment - <-- Fix long-branch-name also
            Hide
            sophistifunk Josh McDonald added a comment -

            Note to self: ellipses for long branches, as per JENKINS-41782

            Show
            sophistifunk Josh McDonald added a comment - Note to self: ellipses for long branches, as per JENKINS-41782
            Hide
            sophistifunk Josh McDonald added a comment -

            I'll do what I can about the alignment stuff, but no promises you're going to get pixel-perfection, IIRC it doesn't fit exactly evenly. I mean, I can put things on half-pixels and it'll be sweet on retina, but god help those people on duplo-pixels with IE's text renderer

            Show
            sophistifunk Josh McDonald added a comment - I'll do what I can about the alignment stuff, but no promises you're going to get pixel-perfection, IIRC it doesn't fit exactly evenly. I mean, I can put things on half-pixels and it'll be sweet on retina, but god help those people on duplo-pixels with IE's text renderer
            Hide
            sophistifunk Josh McDonald added a comment -

            More importantly, we're going to have a lot of layouts that can blow out with extension points, so y'all might want to warm up to letting go of a little control

            Show
            sophistifunk Josh McDonald added a comment - More importantly, we're going to have a lot of layouts that can blow out with extension points, so y'all might want to warm up to letting go of a little control
            Show
            sophistifunk Josh McDonald added a comment - https://github.com/jenkinsci/blueocean-plugin/pull/804
            Hide
            sophistifunk Josh McDonald added a comment -

            Fixed in master

            Show
            sophistifunk Josh McDonald added a comment - Fixed in master

              People

              • Assignee:
                sophistifunk Josh McDonald
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: