If a PR is not trusted and has a Jenkinsfile but the target branch of the PR does not have a Jenkinsfile, we should not report that as a PR matching the Jenkinsfile criteria as the Jenkinsfile should be sourced from the trusted revision (where there is none)
The current behaviour is that the PR will be flagged as matching the criteria and hence a build attempt will be started, but as the trusted revision does not have the Jenkinsfile the build will fail.
We should never even try to build in the first case for such an untrusted PR
|Assignee||Stephen Connolly [ stephenconnolly ]|
|Status||Open [ 1 ]||In Progress [ 3 ]|
|Remote Link||This issue links to "PR#128 (Web Link)" [ 15713 ]|
|Status||In Progress [ 3 ]||In Review [ 10005 ]|
[ I suspect that JENKINS-24347 is just some confusion around how form validation works, but in any case form validation cannot consider the full entire security realm configuration as this involves nested hetero-list elements.
I do not think that JENKINS-24347 is strictly a duplicate of this issue but they are somewhat related in concept and we may be able to close that as WONTFIX with this new feature ]
|Status||In Review [ 10005 ]||Resolved [ 5 ]|
|Resolution||Fixed [ 1 ]|
|Status||Resolved [ 5 ]||Closed [ 6 ]|
|Remote Link||This issue links to "CloudBees Internal OSS-2065 (Web Link)" [ 18435 ]|