Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41785

Multi-branch pipeline status icon no longer shows worst status of jobs in that multi-branch 'folder'

    Details

    • Similar Issues:

      Description

      The status icon of multi-branch pipeline jobs in a folder could optionally be adjusted to show the status of the worst job in that multi-branch pipeline as the status for that multi-branch pipeline. Recent updates to plugins have changed that behavior so it no longer shows worst status.

      Steps to see the expected behavior (before the change):

      1. Clone my docker instance and checkout the JENKINS-41785-before tag
          $ git clone https://github.com/MarkEWaite/docker JENKINS-41785-before
          $ cd JENKINS-41785-before
          $ git checkout -b JENKINS-41785-before JENKINS-41785-before
        
      2. Build and run the docker instance
          $ docker build -t jenkins:JENKINS-41785-before .
          $ docker run -i --rm --publish 8080:8080 --publish 50000:50000 --publish 18022:18022 -t jenkins:JENKINS-41785-before
        
      3. Open a web browser to that running docker instance
      4. Open the "Bugs - Pipeline Checks" folder
      5. Observe the icon for the jenkins-bugs multi-branch pipeline folder
      6. Open the jenkins-bugs multi-branch pipeline folder and index the branches
      7. Wait until at least one of the pipeline jobs completes
      8. Navigate to the "Bus - Pipeline Checks" folder and confirm the status is correct

      Steps to see the unexpected (changed) behavior:

      1. Clone my docker instance and checkout the JENKINS-41785-after tag
          $ git clone https://github.com/MarkEWaite/docker JENKINS-41785-after
          $ cd JENKINS-41785-after
          $ git checkout -b JENKINS-41785-after JENKINS-41785-after
        
      2. Build and run the docker instance
          $ docker build -t jenkins:JENKINS-41785-after .
          $ docker run -i --rm --publish 8080:8080 --publish 50000:50000 --publish 18022:18022 -t jenkins:JENKINS-41785-after
        
      3. Open a web browser to that running docker instance
      4. Open the "Bugs - Pipeline Checks" folder
      5. Observe the icon for the jenkins-bugs multi-branch pipeline folder is incorrect (shows no status)
      6. Open the jenkins-bugs multi-branch pipeline folder and index the branches
      7. Wait until at least one of the pipeline jobs completes
      8. Navigate to the "Bus - Pipeline Checks" folder and confirm the status is still incorrect (shows no status)

      The parent folder does still show the "worst status" when it is configured (see ). It seems to only be the pipeline folder that is unable to show worst case status. This might be related to JENKINS-40545, since I see a null pointer exception reported when I try to configure that pipeline job in the folder, though the null pointer exception also appears when I configure a folder in a folder.

        Attachments

          Activity

          Hide
          stephenconnolly Stephen Connolly added a comment -

          Patrick Wolf We need to discuss this one. The ability to configure a custom folder icon was only exposed by accident in the original implementation. With 2.0.x this was locked down as the API to lock it down was made available. To support the customization would require adding some sort of organization folder property that allows delegating the configuration to the child projects (as child projects are read-only, so would need configuration at the organization folder level).

          In short, getting a consistent UI for this that works for both raw multi-branch projects and multi-branch projects in an org folder is not a trivial solution, and given that the design is that the avatar be displayed in the status icon rather than an aggregate status, I am inclined to mark this as WONTFIX. On the other hand, I can see the utility for some users in being able to get the aggregate status... WDYT?

          Show
          stephenconnolly Stephen Connolly added a comment - Patrick Wolf We need to discuss this one. The ability to configure a custom folder icon was only exposed by accident in the original implementation. With 2.0.x this was locked down as the API to lock it down was made available. To support the customization would require adding some sort of organization folder property that allows delegating the configuration to the child projects (as child projects are read-only, so would need configuration at the organization folder level). In short, getting a consistent UI for this that works for both raw multi-branch projects and multi-branch projects in an org folder is not a trivial solution, and given that the design is that the avatar be displayed in the status icon rather than an aggregate status, I am inclined to mark this as WONTFIX. On the other hand, I can see the utility for some users in being able to get the aggregate status... WDYT?
          Hide
          jadchamoun Jad Chamoun added a comment -

          It's the same here, ever since updating to 2.12. Thank you Mark Waite for reporting it.

          Show
          jadchamoun Jad Chamoun added a comment - It's the same here, ever since updating to 2.12. Thank you Mark Waite for reporting it.
          Hide
          recampbell Ryan Campbell added a comment -

          Thanks for the detailed steps to reproduce. Stephen Connolly, I think we need to prioritize this one.

          Show
          recampbell Ryan Campbell added a comment - Thanks for the detailed steps to reproduce. Stephen Connolly , I think we need to prioritize this one.

            People

            • Assignee:
              stephenconnolly Stephen Connolly
              Reporter:
              markewaite Mark Waite
            • Votes:
              4 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: