Details

    • Epic Link:
    • Sprint:
      1.0
    • Similar Issues:

      Description

      Scope

      • Spacing between creation flow and header
      • Font size of headings
      • Line should be faded
      • Overall width of creation flow
      • Github access key placeholder should be "Your Github access key"
      • Errors should end with an error step

      Screenshots
      adjustments

      error step

        Attachments

        1. creation.png
          creation.png
          48 kB
        2. error-step.png
          error-step.png
          43 kB
        3. screenshot-1.png
          screenshot-1.png
          18 kB
        4. screenshot-2.png
          screenshot-2.png
          23 kB
        5. screenshot-3.png
          screenshot-3.png
          45 kB

          Issue Links

            Activity

            Hide
            brody Brody Maclean added a comment -

            Distance between header & top of node should be 48px. (slightly different from what the designs are currently)

            I tried to use a grid when designing this, but it's an uneven number of columns so it wasn't centred perfectly. Just center the entire thing in the middle & ignore my weird positioning.

            Show
            brody Brody Maclean added a comment - Distance between header & top of node should be 48px. (slightly different from what the designs are currently) I tried to use a grid when designing this, but it's an uneven number of columns so it wasn't centred perfectly. Just center the entire thing in the middle & ignore my weird positioning.
            Hide
            cliffmeyers Cliff Meyers added a comment -

            There are some areas where there is a paragraph of copy ~2 sentences long. If we don't set a max width, then the entire UI stretches and centering looks weird (to me). I currently have it set to 700px. Let me know if that needs fixing.

            Show
            cliffmeyers Cliff Meyers added a comment - There are some areas where there is a paragraph of copy ~2 sentences long. If we don't set a max width, then the entire UI stretches and centering looks weird (to me). I currently have it set to 700px. Let me know if that needs fixing.
            Hide
            brody Brody Maclean added a comment -

            I was thinking the main column would have a container and everything would fit within that 460px wide container.

            An example with a paragraph of text.

            Show
            brody Brody Maclean added a comment - I was thinking the main column would have a container and everything would fit within that 460px wide container. An example with a paragraph of text.
            Hide
            cliffmeyers Cliff Meyers added a comment - - edited

            Note: I changed the access token placeholder to "Your Github access token" since they are referred to as "personal access tokens" on the Github site.

            Show
            cliffmeyers Cliff Meyers added a comment - - edited Note: I changed the access token placeholder to "Your Github access token" since they are referred to as "personal access tokens" on the Github site.
            Hide
            cliffmeyers Cliff Meyers added a comment -

            James Dumay if we receive an error at the end of Github, we currently do display an error step, although the copy is a little different since we are responding to an error in a specific step in the workflow. I also added a more generic error step that is capable of showing an excerpt of the error message returned by the server.

            It's possible there are some service calls are missing the right logic, but perhaps that can be done as part of a separate ticket? They aren't really "design tweaks" in my view (it would also help to keep the PR more targeted)

            Show
            cliffmeyers Cliff Meyers added a comment - James Dumay if we receive an error at the end of Github, we currently do display an error step, although the copy is a little different since we are responding to an error in a specific step in the workflow. I also added a more generic error step that is capable of showing an excerpt of the error message returned by the server. It's possible there are some service calls are missing the right logic, but perhaps that can be done as part of a separate ticket? They aren't really "design tweaks" in my view (it would also help to keep the PR more targeted)
            Show
            cliffmeyers Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/869/files

              People

              • Assignee:
                cliffmeyers Cliff Meyers
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: