Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42189

Groovy 2.4.8 interoperability issues

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The issue depicted in blocked_threads.png appeared in our production server.
      (it results on a broken state that we fixed by rebooting the server)

      The result of the first investigation is the following:
      cleanUpGlobalClassSet
      https://github.com/jenkinsci/workflow-cps-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java#L1037

      seems to have compatibility issues with the memory leak fix implemented in groovy 2.4.8
      https://github.com/apache/groovy/pull/219/commits/f7c688e101af77170448cf0be9103c4e6dac3f74

      It seems that gradle had a similar issue, that was fixed by the following commit in groovy 2.4.8
      https://github.com/apache/groovy/commit/82c9d20a160c7e4f59630f163a68df82f5e0eba4

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecutionTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/e6038f2494d55f13e2294f04c720f6fdce28508a
            Log:
            JENKINS-42189 Using https://github.com/jenkinsci/jenkins-test-harness/pull/50 to amend #109 to fail if we get another soft leak.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecutionTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/e6038f2494d55f13e2294f04c720f6fdce28508a Log: JENKINS-42189 Using https://github.com/jenkinsci/jenkins-test-harness/pull/50 to amend #109 to fail if we get another soft leak.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecutionTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/7e0b27433db5a4bb72fe47b826fb54ca29d5bf7b
            Log:
            Merge pull request #111 from jglick/MemoryAssert

            JENKINS-42189 Forcing a test failure in case of another soft leak

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/d59b417e08b8...7e0b27433db5

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecutionTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/7e0b27433db5a4bb72fe47b826fb54ca29d5bf7b Log: Merge pull request #111 from jglick/MemoryAssert JENKINS-42189 Forcing a test failure in case of another soft leak Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/d59b417e08b8...7e0b27433db5
            Hide
            edilect Emmanuel Debanne added a comment - - edited

            When testing groovy 2.4.8, we needed to restart twice Jenkins. We already provided a screenshot corresponding to the first restart on on the 18th. I add an attachment with the thread dump of the second restart on the 21th, hoping it will help to investigate the deadlock. The job names have been replaced by 'AJOB'.

            Show
            edilect Emmanuel Debanne added a comment - - edited When testing groovy 2.4.8, we needed to restart twice Jenkins. We already provided a screenshot corresponding to the first restart on on the 18th. I add an attachment with the thread dump of the second restart on the 21th, hoping it will help to investigate the deadlock. The job names have been replaced by 'AJOB'.
            Hide
            jglick Jesse Glick added a comment -

            Emmanuel Debanne just please pick up the workflow-cps update and verify that this addresses the issue for you.

            Show
            jglick Jesse Glick added a comment - Emmanuel Debanne just please pick up the workflow-cps update and verify that this addresses the issue for you.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/dc00a0e56c08ee30e74ea8b848bc3ab8e69b7eff
            Log:
            Merge pull request #109 from jglick/groovy-2.4.8-JENKINS-42189

            JENKINS-42189 Fix ClassInfo cleanup in Groovy 2.4.8+

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java http://jenkins-ci.org/commit/workflow-cps-plugin/dc00a0e56c08ee30e74ea8b848bc3ab8e69b7eff Log: Merge pull request #109 from jglick/groovy-2.4.8- JENKINS-42189 JENKINS-42189 Fix ClassInfo cleanup in Groovy 2.4.8+

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                yetanotherion Jon Alberdi
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: