Details

    • Type: Improvement
    • Status: In Review (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: cli
    • Labels:
      None
    • Similar Issues:

      Description

      We had to make mandatory the use of a proxy in our infrastructure to access CLI port. During the journey, we made some improvement to the CLI proxy support:

      • make proxy support work with recent Squid version which reply with HTTP/1.1 even if request is HTTP 1.0
      • close the socket connected to the proxy if the connection failed
      • output an error message when proxy connection failed
      • don't do a reverse DNS lookup, instead use the host string provided in X-Jenkins-CLI-Host headers. It can be a IP address passed with hudson.TcpSlaveAgentListener.hostName (we don't know if the DNS resolver on the proxy will be able to resolve the name correctly, or like us).

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Yoann Dubreuil
            Path:
            cli/src/main/java/hudson/cli/CLI.java
            cli/src/main/resources/hudson/cli/client/Messages.properties
            http://jenkins-ci.org/commit/jenkins/1b3121db248ed0e75343ded5bf870935535a61d2
            Log:
            JENKINS-42191 Enhance CLI HTTP proxy support (#2711)

            • Enhance CLI HTTP proxy support

            Fix few issues around proxy support in CLI:

            • make proxy support work with recent Squid version which reply with HTTP/1.1 even if request is HTTP 1.0
            • close the socket connected to the proxy if the connection failed
            • output an error message when proxy connection failed
            • don't do a reverse DNS lookup, instead use the host string provided in X-Jenkins-CLI-Host headers (we don't know if the DNS resolver on the
              proxy will be able to resolve the name correctly, or like us).
            • Use stdout to output CLI proxy connection error message
            • Use the logger to output the error message, not System.out
            • Add a 'verbose' option to the CLI to turn logging on

            This should help people diagnosing connection issues with the CLI.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Yoann Dubreuil Path: cli/src/main/java/hudson/cli/CLI.java cli/src/main/resources/hudson/cli/client/Messages.properties http://jenkins-ci.org/commit/jenkins/1b3121db248ed0e75343ded5bf870935535a61d2 Log: JENKINS-42191 Enhance CLI HTTP proxy support (#2711) Enhance CLI HTTP proxy support Fix few issues around proxy support in CLI: make proxy support work with recent Squid version which reply with HTTP/1.1 even if request is HTTP 1.0 close the socket connected to the proxy if the connection failed output an error message when proxy connection failed don't do a reverse DNS lookup, instead use the host string provided in X-Jenkins-CLI-Host headers (we don't know if the DNS resolver on the proxy will be able to resolve the name correctly, or like us). Use stdout to output CLI proxy connection error message Use the logger to output the error message, not System.out Add a 'verbose' option to the CLI to turn logging on This should help people diagnosing connection issues with the CLI. JENKINS-42191 Set log level to FINEST when -v is passed

              People

              • Assignee:
                ydubreuil Yoann Dubreuil
                Reporter:
                ydubreuil Yoann Dubreuil
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: