Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42196

Eliminate overly-eager SSE ping request

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      1.0

      Description

      Atm, the SSE client executes an immediate ping request to the server on receipt of an SSE channel error. This is too eager. We should wait a few seconds before performing the ping, giving the SSE connection a chance to see if it can "fix" itself (e.g. during a reconnect).

      I was sure this was how it was working already. Maybe I unwittingly introduced this at some point.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Tom Fennelly
            Path:
            package.json
            src/main/js/SSEConnection.js
            http://jenkins-ci.org/commit/sse-gateway-plugin/c225bf976b0b0b42aadea1135eef7392e8dcd721
            Log:
            [FIX JENKINS-42196] Eliminate overly-eager SSE ping request (#18)

            • Only ping after giving the connection a chance to heal itself
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: package.json src/main/js/SSEConnection.js http://jenkins-ci.org/commit/sse-gateway-plugin/c225bf976b0b0b42aadea1135eef7392e8dcd721 Log: [FIX JENKINS-42196] Eliminate overly-eager SSE ping request (#18) Only ping after giving the connection a chance to heal itself 0.0.19-tf- JENKINS-42196 -1
            Hide
            tfennelly Tom FENNELLY added a comment -

            Noticed this while investigating JENKINS-42137.

            Show
            tfennelly Tom FENNELLY added a comment - Noticed this while investigating JENKINS-42137 .

              People

              • Assignee:
                tfennelly Tom FENNELLY
                Reporter:
                tfennelly Tom FENNELLY
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: