Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42490

500 error when unfavoriting a Pipeline

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      1.0, Blue Ocean 1.0-rc3

      Description

      Steps to reproduce

      1. create a multi branch pipeline
      2. go to classic, favourite the Folder
      3. go to Blue Ocean and try to remove it as a favourite

      What should happen
      A favourited folder should never show up as a favourite in Blue Ocean

      Original request
      I am only able to reproduce this with one specific Pipeline on ci.jenkins.io, and I'm not sure why.
      I think I might need to pair with Thorsten Scherler again to debug this.

        Attachments

          Activity

          Hide
          jamesdumay James Dumay added a comment -

          From R. Tyler Croy HAR file:

          Request body:

          {
          "favorite": false
          }

          So I think something odd is going on in the favorite plugin itself.

          R. Tyler Croy can you send me a copy of your user.xml from Jenkins.io? You can redact any secrets before you send it and if you gpg it to me I can analyze whats going on locally.

          Show
          jamesdumay James Dumay added a comment - From R. Tyler Croy HAR file: Request body: { "favorite" : false } So I think something odd is going on in the favorite plugin itself. R. Tyler Croy can you send me a copy of your user.xml from Jenkins.io? You can redact any secrets before you send it and if you gpg it to me I can analyze whats going on locally.
          Hide
          rtyler R. Tyler Croy added a comment -

          James Dumay, I assume you mean JENKINS_HOME/users/rtyler/config.xml ?

          Show
          rtyler R. Tyler Croy added a comment - James Dumay , I assume you mean JENKINS_HOME/users/rtyler/config.xml ?
          Hide
          jamesdumay James Dumay added a comment -

          R. Tyler Croy yes, thats the one. Your favourites are stored in there.

          Show
          jamesdumay James Dumay added a comment - R. Tyler Croy yes, thats the one. Your favourites are stored in there.
          Hide
          rtyler R. Tyler Croy added a comment -

          One of these things doesn't look like the other, I have no idea how that entry was made

              <hudson.plugins.favorite.user.FavoriteUserProperty plugin="favorite@2.0.4">
                <data class="concurrent-hash-map">
                  <entry>
                    <string>Infra/infra-statistics</string>
                    <boolean>true</boolean>
                  </entry>
                  <entry>
                    <string>Infra/azure/master</string>
                    <boolean>true</boolean>
                  </entry>
                  <entry>
                    <string>Infra/plugin-site-api/master</string>
                    <boolean>true</boolean>
                  </entry>
                  <entry>
                    <string>Infrastructure/jenkins.io</string>
                    <boolean>false</boolean>
                  </entry>
                  <entry>
                    <string>Core/remoting/master</string>
                    <boolean>false</boolean>
                  </entry>
                  <entry>
                    <string>Core/jenkins_master</string>
                    <boolean>true</boolean>
                  </entry>
                  <entry>
                    <string>Core/jenkins/master</string>
                    <boolean>true</boolean>
                  </entry>
                  <entry>
                    <string>Infra/plugin-site-api</string>
                    <boolean>true</boolean>
                  </entry>
                  <entry>
                    <string>Core/remoting/3.4.x</string>
                    <boolean>false</boolean>
                  </entry>
                  <entry>
                    <string>Plugins/azure-vm-agents-plugin/master</string>
                    <boolean>false</boolean>
                  </entry>
                  <entry>
                    <string>Infra/jenkins-infra/production</string>
                    <boolean>true</boolean>
                  </entry>
                  <entry>
                    <string>Infrastructure/statistics</string>
                    <boolean>true</boolean>
                  </entry>
                </data>
              </hudson.plugins.favorite.user.FavoriteUserProperty>
          
          Show
          rtyler R. Tyler Croy added a comment - One of these things doesn't look like the other, I have no idea how that entry was made <hudson.plugins.favorite.user.FavoriteUserProperty plugin= "favorite@2.0.4" > <data class= "concurrent-hash-map" > <entry> <string>Infra/infra-statistics</string> < boolean > true </ boolean > </entry> <entry> <string>Infra/azure/master</string> < boolean > true </ boolean > </entry> <entry> <string>Infra/plugin-site-api/master</string> < boolean > true </ boolean > </entry> <entry> <string>Infrastructure/jenkins.io</string> < boolean > false </ boolean > </entry> <entry> <string>Core/remoting/master</string> < boolean > false </ boolean > </entry> <entry> <string>Core/jenkins_master</string> < boolean > true </ boolean > </entry> <entry> <string>Core/jenkins/master</string> < boolean > true </ boolean > </entry> <entry> <string>Infra/plugin-site-api</string> < boolean > true </ boolean > </entry> <entry> <string>Core/remoting/3.4.x</string> < boolean > false </ boolean > </entry> <entry> <string>Plugins/azure-vm-agents-plugin/master</string> < boolean > false </ boolean > </entry> <entry> <string>Infra/jenkins-infra/production</string> < boolean > true </ boolean > </entry> <entry> <string>Infrastructure/statistics</string> < boolean > true </ boolean > </entry> </data> </hudson.plugins.favorite.user.FavoriteUserProperty>
          Hide
          jamesdumay James Dumay added a comment -

          I found the issue It looks like you have favourited the Multibranch Folder in classic and BO counts that as a favourite (it shouldn't). When you go to unfavourite, it will try to unfavourite the "master" within the folder which throws an exception.

          Show
          jamesdumay James Dumay added a comment - I found the issue It looks like you have favourited the Multibranch Folder in classic and BO counts that as a favourite (it shouldn't). When you go to unfavourite, it will try to unfavourite the "master" within the folder which throws an exception.

            People

            • Assignee:
              imeredith Ivan Meredith
              Reporter:
              rtyler R. Tyler Croy
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: