Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42511

Computed Folder API poorly designed for concurrent event processing

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      https://ci.jenkins.io/job/Tools/job/maven-hpi-plugin/view/change-requests/job/PR-53/  was build by a PR (mine) but on the job page there is no information about the job.

      BlueOcean shows a failed build with no information.

       

      If you follow the permalink (which takes you to build#1) then you can see the build exists and did indeed fail...

      R. Tyler Croy has a support bundle - if you are workin on the ticket connect with him directly (as it has some private infor that is not available to anonymous users such as hostnames/ports etc...)

        Attachments

        1. build.log
          9 kB
        2. build.png
          build.png
          349 kB
        3. job page.png
          job page.png
          278 kB

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/branch/MultiBranchProject.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            http://jenkins-ci.org/commit/branch-api-plugin/a76ffb08afe1c9577711618b148c6b991815369f
            Log:
            JENKINS-42511 Pick up the ComputedFolder API changes

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java http://jenkins-ci.org/commit/branch-api-plugin/a76ffb08afe1c9577711618b148c6b991815369f Log: JENKINS-42511 Pick up the ComputedFolder API changes
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/branch/MultiBranchProject.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            src/test/java/integration/EventsTest.java
            http://jenkins-ci.org/commit/branch-api-plugin/fb0ae05c1469edc0e73516044ce7366d1718fe50
            Log:
            Merge pull request #94 from stephenc/jenkins-42511

            JENKINS-42511 Add a test to verify root cause

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/509a08caa65e...fb0ae05c1469

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java src/test/java/integration/EventsTest.java http://jenkins-ci.org/commit/branch-api-plugin/fb0ae05c1469edc0e73516044ce7366d1718fe50 Log: Merge pull request #94 from stephenc/jenkins-42511 JENKINS-42511 Add a test to verify root cause Compare: https://github.com/jenkinsci/branch-api-plugin/compare/509a08caa65e...fb0ae05c1469
            Hide
            seadub Chris Williams added a comment - - edited

            looks like the latest update to this plugin or the github organization folder is causing NPEs all over the place for my org scans/event handling:

            ERROR: Failed to create or update a subproject appc-studio-server
            java.lang.NullPointerException
            	at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder$FullReindexChildObserver.shouldUpdate(ComputedFolder.java:728)
            	at jenkins.branch.OrganizationFolder$SCMSourceObserverImpl$1.complete(OrganizationFolder.java:1290)
            	at org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.add(GitHubSCMNavigator.java:460)
            	at org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.visitSources(GitHubSCMNavigator.java:319)
            	at jenkins.branch.OrganizationFolder.computeChildren(OrganizationFolder.java:399)
            	at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.updateChildren(ComputedFolder.java:252)
            	at com.cloudbees.hudson.plugins.folder.computed.FolderComputation.run(FolderComputation.java:154)
            	at jenkins.branch.OrganizationFolder$OrganizationScan.run(OrganizationFolder.java:850)
            	at hudson.model.ResourceController.execute(ResourceController.java:98)
            	at hudson.model.Executor.run(Executor.java:404)

            Oh, and now it seems to be wiping out all the projects where the NPE is occurring...

            Show
            seadub Chris Williams added a comment - - edited looks like the latest update to this plugin or the github organization folder is causing NPEs all over the place for my org scans/event handling: ERROR: Failed to create or update a subproject appc-studio-server java.lang.NullPointerException at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder$FullReindexChildObserver.shouldUpdate(ComputedFolder.java:728) at jenkins.branch.OrganizationFolder$SCMSourceObserverImpl$1.complete(OrganizationFolder.java:1290) at org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.add(GitHubSCMNavigator.java:460) at org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.visitSources(GitHubSCMNavigator.java:319) at jenkins.branch.OrganizationFolder.computeChildren(OrganizationFolder.java:399) at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.updateChildren(ComputedFolder.java:252) at com.cloudbees.hudson.plugins.folder.computed.FolderComputation.run(FolderComputation.java:154) at jenkins.branch.OrganizationFolder$OrganizationScan.run(OrganizationFolder.java:850) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:404) Oh, and now it seems to be wiping out all the projects where the NPE is occurring...
            Hide
            jglick Jesse Glick added a comment -
            Show
            jglick Jesse Glick added a comment - Chris Williams see  JENKINS-42593 .
            Hide
            seadub Chris Williams added a comment -

            After doing a lot of backtracking to figure out what plugins I updated today and find the source of the issue, I can confirm that the 6.0.0 cloudbees-folder plugin introduces the NPE I see above, which is a major blocking bug - it breaks scans of repos on github and actually deletes the existing jobs/folders/projects for those repos.

            Show
            seadub Chris Williams added a comment - After doing a lot of backtracking to figure out what plugins I updated today and find the source of the issue, I can confirm that the 6.0.0 cloudbees-folder plugin introduces the NPE I see above, which is a major blocking bug - it breaks scans of repos on github and actually deletes the existing jobs/folders/projects for those repos.

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                teilo James Nord
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: