Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42511

Computed Folder API poorly designed for concurrent event processing

    Details

    • Similar Issues:

      Description

      https://ci.jenkins.io/job/Tools/job/maven-hpi-plugin/view/change-requests/job/PR-53/  was build by a PR (mine) but on the job page there is no information about the job.

      BlueOcean shows a failed build with no information.

       

      If you follow the permalink (which takes you to build#1) then you can see the build exists and did indeed fail...

      R. Tyler Croy has a support bundle - if you are workin on the ticket connect with him directly (as it has some private infor that is not available to anonymous users such as hostnames/ports etc...)

        Attachments

        1. build.log
          9 kB
        2. build.png
          build.png
          349 kB
        3. job page.png
          job page.png
          278 kB

          Issue Links

            Activity

            teilo James Nord created issue -
            teilo James Nord made changes -
            teilo James Nord made changes -
            Attachment job page.png [ 36304 ]
            teilo James Nord made changes -
            Attachment build.png [ 36305 ]
            teilo James Nord made changes -
            Attachment build.log [ 36306 ]
            Hide
            teilo James Nord added a comment -

            I only have read access to this box - for any follow questions please speak to R. Tyler Croy or anothermemober of the infra-admin team

            Show
            teilo James Nord added a comment - I only have read access to this box - for any follow questions please speak to R. Tyler Croy or anothermemober of the infra-admin team
            teilo James Nord made changes -
            teilo James Nord made changes -
            Description [https://ci.jenkins.io/job/Tools/job/maven-hpi-plugin/view/change-requests/job/PR-53/]  was build by a PR (mine) but on the job page there is no information about the job.

            BlueOcean shows a failed build with no information.

             

            If you follow the permalink (which takes you to build#1) then you can see the build exists and did indeed fail...
            [https://ci.jenkins.io/job/Tools/job/maven-hpi-plugin/view/change-requests/job/PR-53/]  was build by a PR (mine) but on the job page there is no information about the job.

            BlueOcean shows a failed build with no information.

             

            If you follow the permalink (which takes you to build#1) then you can see the build exists and did indeed fail...

            [~rtyler] has a support bundle - if you are workin on the ticket connect with him directly (as it has some private infor that is not available to anonymous users such as hostnames/ports etc...)
            Hide
            jglick Jesse Glick added a comment -

            No idea offhand. Build failure is not indicative of any deep problem in Jenkins, just a hung Docker daemon.

            Show
            jglick Jesse Glick added a comment - No idea offhand. Build failure is not indicative of any deep problem in Jenkins, just a hung Docker daemon.
            Hide
            rtyler R. Tyler Croy added a comment -

            Found some details in the system log:

            Mar 06, 2017 12:32:56 PM jenkins.model.lazy.LazyBuildMixIn newBuild
            WARNING: A new build could not be created in job Tools/maven-hpi-plugin/PR-53
            java.lang.IllegalStateException: JENKINS-23152: /var/jenkins_home/jobs/Tools/jobs/maven-hpi-plugin/branches/PR-53/builds/1 already existed; will not overwrite with Tools/maven-hpi-plugin/PR-53 #1
                    at hudson.model.RunMap.put(RunMap.java:188)
                    at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:185)
                    at org.jenkinsci.plugins.workflow.job.WorkflowJob.createExecutable(WorkflowJob.java:260)
                    at hudson.model.Executor$1.call(Executor.java:356)
                    at hudson.model.Executor$1.call(Executor.java:338)
                    at hudson.model.Queue._withLock(Queue.java:1393)
                    at hudson.model.Queue.withLock(Queue.java:1254)
                    at hudson.model.Executor.run(Executor.java:338)
            
            Mar 06, 2017 12:32:56 PM hudson.model.Executor run
            SEVERE: Unexpected executor death
            java.lang.Error: java.lang.IllegalStateException: JENKINS-23152: /var/jenkins_home/jobs/Tools/jobs/maven-hpi-plugin/branches/PR-53/builds/1 already existed; will not overwrite with Tools/maven-hpi-plugin/PR-53 #1
                    at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:193)
                    at org.jenkinsci.plugins.workflow.job.WorkflowJob.createExecutable(WorkflowJob.java:260)
                    at hudson.model.Executor$1.call(Executor.java:356)
                    at hudson.model.Executor$1.call(Executor.java:338)
                    at hudson.model.Queue._withLock(Queue.java:1393)
                    at hudson.model.Queue.withLock(Queue.java:1254)
                    at hudson.model.Executor.run(Executor.java:338)
            Caused by: java.lang.IllegalStateException: JENKINS-23152: /var/jenkins_home/jobs/Tools/jobs/maven-hpi-plugin/branches/PR-53/builds/1 already existed; will not overwrite with Tools/maven-hpi-plugin/PR-53 #1
                    at hudson.model.RunMap.put(RunMap.java:188)
                    at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:185)
                    ... 6 more
            
            
            Show
            rtyler R. Tyler Croy added a comment - Found some details in the system log: Mar 06, 2017 12:32:56 PM jenkins.model.lazy.LazyBuildMixIn newBuild WARNING: A new build could not be created in job Tools/maven-hpi-plugin/PR-53 java.lang.IllegalStateException: JENKINS-23152: / var /jenkins_home/jobs/Tools/jobs/maven-hpi-plugin/branches/PR-53/builds/1 already existed; will not overwrite with Tools/maven-hpi-plugin/PR-53 #1 at hudson.model.RunMap.put(RunMap.java:188) at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:185) at org.jenkinsci.plugins.workflow.job.WorkflowJob.createExecutable(WorkflowJob.java:260) at hudson.model.Executor$1.call(Executor.java:356) at hudson.model.Executor$1.call(Executor.java:338) at hudson.model.Queue._withLock(Queue.java:1393) at hudson.model.Queue.withLock(Queue.java:1254) at hudson.model.Executor.run(Executor.java:338) Mar 06, 2017 12:32:56 PM hudson.model.Executor run SEVERE: Unexpected executor death java.lang.Error: java.lang.IllegalStateException: JENKINS-23152: / var /jenkins_home/jobs/Tools/jobs/maven-hpi-plugin/branches/PR-53/builds/1 already existed; will not overwrite with Tools/maven-hpi-plugin/PR-53 #1 at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:193) at org.jenkinsci.plugins.workflow.job.WorkflowJob.createExecutable(WorkflowJob.java:260) at hudson.model.Executor$1.call(Executor.java:356) at hudson.model.Executor$1.call(Executor.java:338) at hudson.model.Queue._withLock(Queue.java:1393) at hudson.model.Queue.withLock(Queue.java:1254) at hudson.model.Executor.run(Executor.java:338) Caused by: java.lang.IllegalStateException: JENKINS-23152: / var /jenkins_home/jobs/Tools/jobs/maven-hpi-plugin/branches/PR-53/builds/1 already existed; will not overwrite with Tools/maven-hpi-plugin/PR-53 #1 at hudson.model.RunMap.put(RunMap.java:188) at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:185) ... 6 more
            Hide
            teilo James Nord added a comment -

            Jesse Glick Its not the failure of the build that this bug is for - it is the lack of the build being shown when it is quite clearly exists.

            Seems like there is another way to get duplicate build numbers again

            Show
            teilo James Nord added a comment - Jesse Glick Its not the failure of the build that this bug is for - it is the lack of the build being shown when it is quite clearly exists. Seems like there is another way to get duplicate build numbers again
            jglick Jesse Glick made changes -
            Link This issue blocks JENKINS-23152 [ JENKINS-23152 ]
            Hide
            jglick Jesse Glick added a comment -

            I saw this get thrown from workflow-aggregator-plugin/demo

            … jenkins.model.lazy.LazyBuildMixIn newBuild
            WARNING: A new build could not be created in job cd/master
            java.lang.IllegalStateException: JENKINS-23152: /var/jenkins_home/jobs/cd/branches/master/builds/1 already existed; will not overwrite with cd/master #1
            	at hudson.model.RunMap.put(RunMap.java:188)
            	at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:185)
            	at org.jenkinsci.plugins.workflow.job.WorkflowJob.createExecutable(WorkflowJob.java:260)
            	at hudson.model.Executor$1.call(Executor.java:355)
            	at hudson.model.Executor$1.call(Executor.java:337)
            	at hudson.model.Queue._withLock(Queue.java:1368)
            	at hudson.model.Queue.withLock(Queue.java:1229)
            	at hudson.model.Executor.run(Executor.java:337)
            

             
            but could not reproduce it—the next time I started the container, all was fine.

            I have not yet figured out what could cause this. Something has to be deeply wrong for this to happen—for example, two Job’s with the same name.

            I have a suspicion that something in the SCM API 2.x changes caused this. Stephen Connolly any clues?

            Show
            jglick Jesse Glick added a comment - I saw this get thrown from workflow-aggregator-plugin/demo … jenkins.model.lazy.LazyBuildMixIn newBuild WARNING: A new build could not be created in job cd/master java.lang.IllegalStateException: JENKINS-23152: /var/jenkins_home/jobs/cd/branches/master/builds/1 already existed; will not overwrite with cd/master #1 at hudson.model.RunMap.put(RunMap.java:188) at jenkins.model.lazy.LazyBuildMixIn.newBuild(LazyBuildMixIn.java:185) at org.jenkinsci.plugins.workflow.job.WorkflowJob.createExecutable(WorkflowJob.java:260) at hudson.model.Executor$1.call(Executor.java:355) at hudson.model.Executor$1.call(Executor.java:337) at hudson.model.Queue._withLock(Queue.java:1368) at hudson.model.Queue.withLock(Queue.java:1229) at hudson.model.Executor.run(Executor.java:337)   but could not reproduce it—the next time I started the container, all was fine. I have not yet figured out what could cause this. Something has to be deeply wrong for this to happen—for example, two Job ’s with the same name. I have a suspicion that something in the SCM API 2.x changes caused this. Stephen Connolly any clues?
            jglick Jesse Glick made changes -
            Summary a job has a build but no history. ISE from RunMap.put
            Priority Minor [ 4 ] Critical [ 2 ]
            Labels core pipeline pipeline
            Hide
            jglick Jesse Glick added a comment -

            Happens sporadically, but often enough to do diagnosis I think.

            Show
            jglick Jesse Glick added a comment - Happens sporadically, but often enough to do diagnosis I think.
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Component/s branch-api-plugin [ 18621 ]
            Component/s core [ 15593 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 92 (Web Link)" [ 15617 ]
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ] Stephen Connolly [ stephenconnolly ]
            jglick Jesse Glick made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            jglick Jesse Glick made changes -
            Labels pipeline pipeline regression
            jglick Jesse Glick made changes -
            Summary ISE from RunMap.put Branch indexing creates duplicate copies of branch projects
            Hide
            stephenconnolly Stephen Connolly added a comment -

            I wonder could it be concurrent branch indexing with event processing?

            Show
            stephenconnolly Stephen Connolly added a comment - I wonder could it be concurrent branch indexing with event processing?
            Show
            stephenconnolly Stephen Connolly added a comment - https://github.com/jenkinsci/branch-api-plugin/pull/94 specifically https://github.com/jenkinsci/branch-api-plugin/pull/94/commits/f46693f39abd13586cf243089a3136f5c3533c51  seems to be reproducing
            stephenconnolly Stephen Connolly made changes -
            Component/s cloudbees-folder-plugin [ 18137 ]
            Component/s branch-api-plugin [ 18621 ]
            Hide
            stephenconnolly Stephen Connolly added a comment -

            More correctly this is a bug in ComputedFolder though creating a test case there may be more complex

            Show
            stephenconnolly Stephen Connolly added a comment - More correctly this is a bug in ComputedFolder though creating a test case there may be more complex
            stephenconnolly Stephen Connolly made changes -
            Summary Branch indexing creates duplicate copies of branch projects Computed Folder API poorly designed for concurrent event processing
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Jesse Glick this one is a doozie... may end up with scm-api 3.0.0 before the bug is fixed

            ]

            Show
            stephenconnolly Stephen Connolly added a comment - Jesse Glick this one is a doozie... may end up with scm-api 3.0.0 before the bug is fixed ]
            Hide
            stephenconnolly Stephen Connolly added a comment -

            I believe the least risk way to fix this will require JENKINS-42542

            Show
            stephenconnolly Stephen Connolly added a comment - I believe the least risk way to fix this will require  JENKINS-42542
            stephenconnolly Stephen Connolly made changes -
            Link This issue depends on JENKINS-42542 [ JENKINS-42542 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 94 (Web Link)" [ 15621 ]
            Hide
            jglick Jesse Glick added a comment -

            could it be concurrent branch indexing with event processing?

            Did you manage to pinpoint the problem? From looking at logs it seems like PeriodicFolderTrigger fires and then the indexing runs twice in a row but with identical (down to ms) start timestamp. Furthermore the code in SCMHeadObserverImpl.observe seems to be faulty somehow—it has already called observer.shouldUpdate, so it should know there is an existing project, yet it is still getting down to the _factory.newInstance call. Or is it the shouldUpdate implementation which is wrong?

            Show
            jglick Jesse Glick added a comment - could it be concurrent branch indexing with event processing? Did you manage to pinpoint the problem? From looking at logs it seems like PeriodicFolderTrigger fires and then the indexing runs twice in a row but with identical (down to ms) start timestamp. Furthermore the code in SCMHeadObserverImpl.observe seems to be faulty somehow—it has already called observer.shouldUpdate , so it should know there is an existing project, yet it is still getting down to the _factory.newInstance call. Or is it the shouldUpdate implementation which is wrong?
            jglick Jesse Glick made changes -
            Remote Link This issue links to "cloudbees-folder PR 91 (Web Link)" [ 15622 ]
            Hide
            jglick Jesse Glick added a comment -

            FTR shouldUpdate was the problem here.

            Show
            jglick Jesse Glick added a comment - FTR shouldUpdate was the problem here.
            stephenconnolly Stephen Connolly made changes -
            Remote Link This issue links to "PR#92 (Web Link)" [ 15623 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/PeriodicFolderTrigger.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/4bc16d7552d6473ea1e86813564ba055860e2437
            Log:
            JENKINS-42511 FolderCron can run PeriodicFolderTrigger multiple times in quick succession, so do not rely solely on FolderComputation.timestamp.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/PeriodicFolderTrigger.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/4bc16d7552d6473ea1e86813564ba055860e2437 Log: JENKINS-42511 FolderCron can run PeriodicFolderTrigger multiple times in quick succession, so do not rely solely on FolderComputation.timestamp.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/PeriodicFolderTrigger.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/93690dbd078a4a8db63e36b1e65a8fa2b0f1219e
            Log:
            Merge pull request #91 from jglick/ISE-JENKINS-42511

            JENKINS-42511 Race condition in PeriodicFolderTrigger

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/0d35973205f9...93690dbd078a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/PeriodicFolderTrigger.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/93690dbd078a4a8db63e36b1e65a8fa2b0f1219e Log: Merge pull request #91 from jglick/ISE- JENKINS-42511 JENKINS-42511 Race condition in PeriodicFolderTrigger Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/0d35973205f9...93690dbd078a
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ChildObserver.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/PeriodicFolderTrigger.java
            src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorAltTest.java
            src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorRecTest.java
            src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorTest.java
            src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/0d8d28063afbcfc94b7aa455e97e1c31dce0ea1a
            Log:
            JENKINS-42511 Change the ComputedFolder API to define locking behaviour between events and computations

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ChildObserver.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/PeriodicFolderTrigger.java src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorAltTest.java src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorRecTest.java src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorTest.java src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/0d8d28063afbcfc94b7aa455e97e1c31dce0ea1a Log: JENKINS-42511 Change the ComputedFolder API to define locking behaviour between events and computations
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ChildObserver.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/PeriodicFolderTrigger.java
            src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorAltTest.java
            src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorRecTest.java
            src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorTest.java
            src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/de167635e2e0d41c04fdc7bf4328d75f90fe45e1
            Log:
            Merge pull request #92 from stephenc/jenkins-42511

            JENKINS-42511 Correct ComputedFolder API to include blocking behaviour for concurrent events and computations

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/93690dbd078a...de167635e2e0

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/com/cloudbees/hudson/plugins/folder/computed/ChildObserver.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/PeriodicFolderTrigger.java src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorAltTest.java src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorRecTest.java src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorTest.java src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/de167635e2e0d41c04fdc7bf4328d75f90fe45e1 Log: Merge pull request #92 from stephenc/jenkins-42511 JENKINS-42511 Correct ComputedFolder API to include blocking behaviour for concurrent events and computations Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/93690dbd078a...de167635e2e0
            Hide
            stephenconnolly Stephen Connolly added a comment -

            cloudbees-folders 6.0.0

            Show
            stephenconnolly Stephen Connolly added a comment - cloudbees-folders 6.0.0
            stephenconnolly Stephen Connolly made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/3cbceaae991309206afe17b7cf642309917dc3ab
            Log:
            JENKINS-42511 Ooops, forgot to turn on te fix

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/3cbceaae991309206afe17b7cf642309917dc3ab Log: JENKINS-42511 Ooops, forgot to turn on te fix
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/jenkins/branch/MultiBranchProject.java
            http://jenkins-ci.org/commit/branch-api-plugin/61a48b16f22690256701354e661675e56b8d4b38
            Log:
            JENKINS-42511 Make sure we do not attempt to create the same branch project twice.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/jenkins/branch/MultiBranchProject.java http://jenkins-ci.org/commit/branch-api-plugin/61a48b16f22690256701354e661675e56b8d4b38 Log: JENKINS-42511 Make sure we do not attempt to create the same branch project twice.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/MultiBranchProject.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            http://jenkins-ci.org/commit/branch-api-plugin/509a08caa65eb72c7c228fd46534c5899c50ecd3
            Log:
            Merge pull request #92 from jglick/ISE-JENKINS-42511

            JENKINS-42511 Make sure we do not attempt to create the same branch project twice

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/5f30c4ef7408...509a08caa65e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java http://jenkins-ci.org/commit/branch-api-plugin/509a08caa65eb72c7c228fd46534c5899c50ecd3 Log: Merge pull request #92 from jglick/ISE- JENKINS-42511 JENKINS-42511 Make sure we do not attempt to create the same branch project twice Compare: https://github.com/jenkinsci/branch-api-plugin/compare/5f30c4ef7408...509a08caa65e
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/test/java/integration/EventsTest.java
            http://jenkins-ci.org/commit/branch-api-plugin/3f65b5cecaf444adc00a315cd7a9baaa4827cdb1
            Log:
            JENKINS-42511 Add a test to verify root cause

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/test/java/integration/EventsTest.java http://jenkins-ci.org/commit/branch-api-plugin/3f65b5cecaf444adc00a315cd7a9baaa4827cdb1 Log: JENKINS-42511 Add a test to verify root cause
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/branch/MultiBranchProject.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            http://jenkins-ci.org/commit/branch-api-plugin/a76ffb08afe1c9577711618b148c6b991815369f
            Log:
            JENKINS-42511 Pick up the ComputedFolder API changes

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java http://jenkins-ci.org/commit/branch-api-plugin/a76ffb08afe1c9577711618b148c6b991815369f Log: JENKINS-42511 Pick up the ComputedFolder API changes
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/branch/MultiBranchProject.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            src/test/java/integration/EventsTest.java
            http://jenkins-ci.org/commit/branch-api-plugin/fb0ae05c1469edc0e73516044ce7366d1718fe50
            Log:
            Merge pull request #94 from stephenc/jenkins-42511

            JENKINS-42511 Add a test to verify root cause

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/509a08caa65e...fb0ae05c1469

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java src/test/java/integration/EventsTest.java http://jenkins-ci.org/commit/branch-api-plugin/fb0ae05c1469edc0e73516044ce7366d1718fe50 Log: Merge pull request #94 from stephenc/jenkins-42511 JENKINS-42511 Add a test to verify root cause Compare: https://github.com/jenkinsci/branch-api-plugin/compare/509a08caa65e...fb0ae05c1469
            Hide
            seadub Chris Williams added a comment - - edited

            looks like the latest update to this plugin or the github organization folder is causing NPEs all over the place for my org scans/event handling:

            ERROR: Failed to create or update a subproject appc-studio-server
            java.lang.NullPointerException
            	at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder$FullReindexChildObserver.shouldUpdate(ComputedFolder.java:728)
            	at jenkins.branch.OrganizationFolder$SCMSourceObserverImpl$1.complete(OrganizationFolder.java:1290)
            	at org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.add(GitHubSCMNavigator.java:460)
            	at org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.visitSources(GitHubSCMNavigator.java:319)
            	at jenkins.branch.OrganizationFolder.computeChildren(OrganizationFolder.java:399)
            	at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.updateChildren(ComputedFolder.java:252)
            	at com.cloudbees.hudson.plugins.folder.computed.FolderComputation.run(FolderComputation.java:154)
            	at jenkins.branch.OrganizationFolder$OrganizationScan.run(OrganizationFolder.java:850)
            	at hudson.model.ResourceController.execute(ResourceController.java:98)
            	at hudson.model.Executor.run(Executor.java:404)

            Oh, and now it seems to be wiping out all the projects where the NPE is occurring...

            Show
            seadub Chris Williams added a comment - - edited looks like the latest update to this plugin or the github organization folder is causing NPEs all over the place for my org scans/event handling: ERROR: Failed to create or update a subproject appc-studio-server java.lang.NullPointerException at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder$FullReindexChildObserver.shouldUpdate(ComputedFolder.java:728) at jenkins.branch.OrganizationFolder$SCMSourceObserverImpl$1.complete(OrganizationFolder.java:1290) at org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.add(GitHubSCMNavigator.java:460) at org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator.visitSources(GitHubSCMNavigator.java:319) at jenkins.branch.OrganizationFolder.computeChildren(OrganizationFolder.java:399) at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.updateChildren(ComputedFolder.java:252) at com.cloudbees.hudson.plugins.folder.computed.FolderComputation.run(FolderComputation.java:154) at jenkins.branch.OrganizationFolder$OrganizationScan.run(OrganizationFolder.java:850) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:404) Oh, and now it seems to be wiping out all the projects where the NPE is occurring...
            Hide
            jglick Jesse Glick added a comment -
            Show
            jglick Jesse Glick added a comment - Chris Williams see  JENKINS-42593 .
            jglick Jesse Glick made changes -
            Link This issue is blocked by JENKINS-42593 [ JENKINS-42593 ]
            Hide
            seadub Chris Williams added a comment -

            After doing a lot of backtracking to figure out what plugins I updated today and find the source of the issue, I can confirm that the 6.0.0 cloudbees-folder plugin introduces the NPE I see above, which is a major blocking bug - it breaks scans of repos on github and actually deletes the existing jobs/folders/projects for those repos.

            Show
            seadub Chris Williams added a comment - After doing a lot of backtracking to figure out what plugins I updated today and find the source of the issue, I can confirm that the 6.0.0 cloudbees-folder plugin introduces the NPE I see above, which is a major blocking bug - it breaks scans of repos on github and actually deletes the existing jobs/folders/projects for those repos.
            stephenconnolly Stephen Connolly made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "CloudBees Internal OSS-2090 (Web Link)" [ 18424 ]
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "CloudBees Internal OSS-2082 (Web Link)" [ 18427 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal CLTS-1453 (Web Link)" [ 19228 ]

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                teilo James Nord
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: