Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42728

An attempt to update a view using the CLI command update-view using input of a different view type does not fail

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If you try to update a view using the CLI command update-view using input of a different view type, the command succeeds. This is not correct.

      Steps to reproduce:

      • Create view of typeA using UI
      • Get xml representation of view
      • Create view of typeB using UI
      • Update view using xml from typeA
      • The command succeeds.

        Attachments

          Activity

          Hide
          scoheb Scott Hebert added a comment -
          Show
          scoheb Scott Hebert added a comment - Review pending here:  https://github.com/jenkinsci/jenkins/pull/2804
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Scott Hebert
          Path:
          core/src/main/java/hudson/model/View.java
          test/src/test/java/hudson/cli/UpdateViewCommandTest.java
          test/src/test/resources/hudson/cli/testview-foo.xml
          http://jenkins-ci.org/commit/jenkins/07683617d3f9277fe274e7a35f745b14b6a35e44
          Log:
          JENKINS-42728 Updating view with CLI using input of a different view type should fail (#2804)

          • JENKINS-42728 Updating view with CLI using different view type should fail
          • Additionally, updating a view using an XML that will be converted by XStream via an alias
            will succeed.

          [FIXES JENKINS-42728]

          • Remove TestView
          • update test
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Scott Hebert Path: core/src/main/java/hudson/model/View.java test/src/test/java/hudson/cli/UpdateViewCommandTest.java test/src/test/resources/hudson/cli/testview-foo.xml http://jenkins-ci.org/commit/jenkins/07683617d3f9277fe274e7a35f745b14b6a35e44 Log: JENKINS-42728 Updating view with CLI using input of a different view type should fail (#2804) JENKINS-42728 Updating view with CLI using different view type should fail Additionally, updating a view using an XML that will be converted by XStream via an alias will succeed. [FIXES JENKINS-42728] Remove TestView update test

            People

            • Assignee:
              scoheb Scott Hebert
              Reporter:
              scoheb Scott Hebert
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: