Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42791

Developer should be asked for their Github token when loading the editor

    Details

    • Similar Issues:
    • Sprint:
      Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2

      Description

      Improvement on roadmap

      This improvement is on the Blue Ocean project roadmap. Check the roadmap page for updates.

      Context
      A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token. They could also be asked to provide their credential if the one stored is invalid.

      Scope

      • When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
        • If they cannot write to the repository they should see a dialog:
          • Title: Permission denied
          • Description: You do not have the required permissions to edit this Pipeline.
          • Button: "Go back"
      • If there is no token, we ask for the token (as per the mockups below)
        • Title: "Connect to Github"
        • Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
        • Buttons
          • Connect
          • "Cancel" - takes you back whence you came

      Notes
      Keep in mind that we will have to make the same flow work for when the user does not have SSH credentials for Git and Bitbucket. Does not need to be resolved this effort but just something to think about as you are developing.

      Mockups

        Attachments

          Issue Links

            Activity

            jamesdumay James Dumay created issue -
            jamesdumay James Dumay made changes -
            Field Original Value New Value
            Epic Link JENKINS-36291 [ 172300 ]
            jamesdumay James Dumay made changes -
            Assignee James Dumay [ jamesdumay ] Keith Zantow [ kzantow ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            michaelneale Michael Neale made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3 [ 261 ] Blue Ocean 1.0-rc3, Blue Ocean 1.0-rc4 [ 261, 281 ]
            jamesdumay James Dumay made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.0-rc4 [ 261, 281 ] Blue Ocean 1.0-rc3 [ 261 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3 [ 261 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 271 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 271 ] Blue Ocean 1.0-rc3, Blue Ocean 1.2 [ 261, 296 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.2 [ 261, 296 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 271 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "Wiki Page (Jenkins Wiki)" [ 16222 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 271 ] Blue Ocean 1.0-rc3, Blue Ocean 1.2 [ 261, 296 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Assignee Keith Zantow [ kzantow ] James Dumay [ jamesdumay ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.2 [ 261, 296 ] Blue Ocean 1.0-rc3, Blue Ocean 1.2-beta1 [ 261, 326 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Assignee James Dumay [ jamesdumay ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.2 [ 261, 326 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 331 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Assignee Cliff Meyers [ cliffmeyers ]
            jamesdumay James Dumay made changes -
            Description *Context*
            A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token.

            *Scope*
            * When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
            ** If they cannot write to the repository they should see a dialog:
            *** Title: Permission denied
            *** Description: You do not have the required permissions to edit this Pipeline.
            *** Button: "Go back"
            * If there is no token, we ask for the token (as per the mockups below)
            ** Title: "Connect to Github"
            ** Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
            ** Buttons
            *** Connect
            *** "Cancel" - takes you back whence you came

            *Mockups*
            * https://invis.io/Q2A110KM9#/219318668_Editor-Commit_New_File_Connect_To_Github
            * https://zpl.io/ZT8LLy
            *Context*
            A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token.

            *Scope*
            * When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
            ** If they cannot write to the repository they should see a dialog:
            *** Title: Permission denied
            *** Description: You do not have the required permissions to edit this Pipeline.
            *** Button: "Go back"
            * If there is no token, we ask for the token (as per the mockups below)
            ** Title: "Connect to Github"
            ** Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
            ** Buttons
            *** Connect
            *** "Cancel" - takes you back whence you came

            *Notes*
            Keep in mind that we will have to make the same flow work for when the user does not have SSH credentials for Git and Bitbucket. Does not need to be resolved this effort but just something to think about as you are developing.

            *Mockups*
            * https://invis.io/Q2A110KM9#/219318668_Editor-Commit_New_File_Connect_To_Github
            * https://zpl.io/ZT8LLy
            jamesdumay James Dumay made changes -
            Description *Context*
            A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token.

            *Scope*
            * When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
            ** If they cannot write to the repository they should see a dialog:
            *** Title: Permission denied
            *** Description: You do not have the required permissions to edit this Pipeline.
            *** Button: "Go back"
            * If there is no token, we ask for the token (as per the mockups below)
            ** Title: "Connect to Github"
            ** Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
            ** Buttons
            *** Connect
            *** "Cancel" - takes you back whence you came

            *Notes*
            Keep in mind that we will have to make the same flow work for when the user does not have SSH credentials for Git and Bitbucket. Does not need to be resolved this effort but just something to think about as you are developing.

            *Mockups*
            * https://invis.io/Q2A110KM9#/219318668_Editor-Commit_New_File_Connect_To_Github
            * https://zpl.io/ZT8LLy
            *Context*
            A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token. They could also be asked to provide their credential is invalid.

            *Scope*
            * When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
            ** If they cannot write to the repository they should see a dialog:
            *** Title: Permission denied
            *** Description: You do not have the required permissions to edit this Pipeline.
            *** Button: "Go back"
            * If there is no token, we ask for the token (as per the mockups below)
            ** Title: "Connect to Github"
            ** Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
            ** Buttons
            *** Connect
            *** "Cancel" - takes you back whence you came

            *Notes*
            Keep in mind that we will have to make the same flow work for when the user does not have SSH credentials for Git and Bitbucket. Does not need to be resolved this effort but just something to think about as you are developing.

            *Mockups*
            * https://invis.io/Q2A110KM9#/219318668_Editor-Commit_New_File_Connect_To_Github
            * https://zpl.io/ZT8LLy
            jamesdumay James Dumay made changes -
            Description *Context*
            A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token. They could also be asked to provide their credential is invalid.

            *Scope*
            * When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
            ** If they cannot write to the repository they should see a dialog:
            *** Title: Permission denied
            *** Description: You do not have the required permissions to edit this Pipeline.
            *** Button: "Go back"
            * If there is no token, we ask for the token (as per the mockups below)
            ** Title: "Connect to Github"
            ** Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
            ** Buttons
            *** Connect
            *** "Cancel" - takes you back whence you came

            *Notes*
            Keep in mind that we will have to make the same flow work for when the user does not have SSH credentials for Git and Bitbucket. Does not need to be resolved this effort but just something to think about as you are developing.

            *Mockups*
            * https://invis.io/Q2A110KM9#/219318668_Editor-Commit_New_File_Connect_To_Github
            * https://zpl.io/ZT8LLy
            *Context*
            A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token. They could also be asked to provide their credential if the one stored is invalid.

            *Scope*
            * When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
            ** If they cannot write to the repository they should see a dialog:
            *** Title: Permission denied
            *** Description: You do not have the required permissions to edit this Pipeline.
            *** Button: "Go back"
            * If there is no token, we ask for the token (as per the mockups below)
            ** Title: "Connect to Github"
            ** Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
            ** Buttons
            *** Connect
            *** "Cancel" - takes you back whence you came

            *Notes*
            Keep in mind that we will have to make the same flow work for when the user does not have SSH credentials for Git and Bitbucket. Does not need to be resolved this effort but just something to think about as you are developing.

            *Mockups*
            * https://invis.io/Q2A110KM9#/219318668_Editor-Commit_New_File_Connect_To_Github
            * https://zpl.io/ZT8LLy
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 331 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1 [ 261, 331, 336 ]
            jamesdumay James Dumay made changes -
            Description *Context*
            A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token. They could also be asked to provide their credential if the one stored is invalid.

            *Scope*
            * When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
            ** If they cannot write to the repository they should see a dialog:
            *** Title: Permission denied
            *** Description: You do not have the required permissions to edit this Pipeline.
            *** Button: "Go back"
            * If there is no token, we ask for the token (as per the mockups below)
            ** Title: "Connect to Github"
            ** Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
            ** Buttons
            *** Connect
            *** "Cancel" - takes you back whence you came

            *Notes*
            Keep in mind that we will have to make the same flow work for when the user does not have SSH credentials for Git and Bitbucket. Does not need to be resolved this effort but just something to think about as you are developing.

            *Mockups*
            * https://invis.io/Q2A110KM9#/219318668_Editor-Commit_New_File_Connect_To_Github
            * https://zpl.io/ZT8LLy
            {panel:title=Improvement on roadmap|titleBGColor=#3878de|titleColor=white}
            This improvement is on the Blue Ocean project roadmap. Check the [roadmap page|https://jenkins.io/projects/blueocean/roadmap/] for updates.
            {panel}

            *Context*
            A Github token is required to read and write the Jenkinsfile. In the situation where a second user tries to edit a pipeline and they have never provided their Github token, the editor should prompt them for their token. They could also be asked to provide their credential if the one stored is invalid.

            *Scope*
            * When loading the editor we should check that the token they have associated with the user is valid and has the correct scopes to write to the repository.
            ** If they cannot write to the repository they should see a dialog:
            *** Title: Permission denied
            *** Description: You do not have the required permissions to edit this Pipeline.
            *** Button: "Go back"
            * If there is no token, we ask for the token (as per the mockups below)
            ** Title: "Connect to Github"
            ** Description: "Jenkins needs an access key to read and write to the repository <i>$repositoryName</i>"
            ** Buttons
            *** Connect
            *** "Cancel" - takes you back whence you came

            *Notes*
            Keep in mind that we will have to make the same flow work for when the user does not have SSH credentials for Git and Bitbucket. Does not need to be resolved this effort but just something to think about as you are developing.

            *Mockups*
            * https://invis.io/Q2A110KM9#/219318668_Editor-Commit_New_File_Connect_To_Github
            * https://zpl.io/ZT8LLy
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1 [ 261, 331, 336 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2 [ 261, 331, 336, 341 ]
            cliffmeyers Cliff Meyers made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2 [ 261, 331, 336, 341 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3 [ 261, 331, 336, 341, 346 ]
            jamesdumay James Dumay made changes -
            Link This issue relates to JENKINS-43148 [ JENKINS-43148 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3 [ 261, 331, 336, 341, 346 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4 [ 261, 331, 336, 341, 346, 361 ]
            cliffmeyers Cliff Meyers made changes -
            Remote Link This issue links to "#1266 (Web Link)" [ 17330 ]
            cliffmeyers Cliff Meyers made changes -
            Remote Link This issue links to "PR#1276 (Web Link)" [ 17331 ]
            cliffmeyers Cliff Meyers made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            cliffmeyers Cliff Meyers made changes -
            Remote Link This issue links to "PR#45 (Web Link)" [ 17365 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4 [ 261, 331, 336, 341, 346, 361 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2-beta5 [ 261, 331, 336, 341, 346, 361, 376 ]
            jamesdumay James Dumay made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            cliffmeyers Cliff Meyers made changes -
            Remote Link This issue links to "#1318 (Web Link)" [ 17449 ]
            cliffmeyers Cliff Meyers made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]

              People

              • Assignee:
                cliffmeyers Cliff Meyers
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: