Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42872

Inputs with multiple approvers do not work

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      Blue Ocean 1.0-rc3

      Description

      Notes
      This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error. Due to JENKINS-42920 the user will not receive feedback on why they are not allowed to proceed or any other error, which made this problem more confusing.

      To run these scenarios you will need two users - 'alice' and 'bob'.

      Scenario 1 - current user is 'alice', single approver
      This works fine in Blue Ocean

      node {
          echo 'hello world'
          input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
      }
      

      Scenario 2 - current user is 'alice', multiple approvers

      node {
          echo 'hello world'
          input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice,bob"
      }
      

      Original request
      I use input step like below:

      timeout(time: 5, unit: "DAYS") \{
      
          input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A,B,C"
      
      }
      

      can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.

        Attachments

          Issue Links

            Activity

            hanks hanks justin created issue -
            hanks hanks justin made changes -
            Field Original Value New Value
            Description I use input step like below:

             

            ```

            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "hanks, jsuksl, yumuem-sl"

            }

            ```

             

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            I use input step like below:

             

            ```

            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }

            ```

             

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            jamesdumay James Dumay made changes -
            Epic Link JENKINS-38490 [ 174672 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.1 [ 271 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Assignee hanks justin [ hanks ]
            jamesdumay James Dumay made changes -
            Link This issue relates to JENKINS-42920 [ JENKINS-42920 ]
            jamesdumay James Dumay made changes -
            Description I use input step like below:

             

            ```

            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }

            ```

             

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            jamesdumay James Dumay made changes -
            Description I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error.

            To run the scenario you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice, bob"
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            jamesdumay James Dumay made changes -
            Description *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error.

            To run the scenario you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice, bob"
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error. Due to JENKINS-42920 the user will not receive feedback on why they are not allowed to proceed or any other error, which made this problem more confusing.

            To run these scenarios you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice, bob"
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            jamesdumay James Dumay made changes -
            Priority Blocker [ 1 ] Critical [ 2 ]
            jamesdumay James Dumay made changes -
            Summary Multi submitter defined in input step is not worked in Blue Ocean UI Inputs with multiple approvers do not work
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            Hide
            jamesdumay James Dumay added a comment -

            Vivek Pandey would you mind triaging this one when you have a minute?

            Show
            jamesdumay James Dumay added a comment - Vivek Pandey would you mind triaging this one when you have a minute?
            jamesdumay James Dumay made changes -
            Assignee Vivek Pandey [ vivek ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.1 [ 271 ] Blue Ocean 1.0-rc2 [ 261 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            michaelneale Michael Neale made changes -
            Assignee Vivek Pandey [ vivek ] Ivan Meredith [ detab ]
            michaelneale Michael Neale made changes -
            Assignee Ivan Meredith [ detab ] Ivan Meredith [ imeredith ]
            Hide
            michaelneale Michael Neale added a comment -

            Actually this may be API only - perhaps Ivan Meredith could take a look to diagnose. If it is a big one - lets move it out of this sprint. 

            Show
            michaelneale Michael Neale added a comment - Actually this may be API only - perhaps Ivan Meredith could take a look to diagnose. If it is a big one - lets move it out of this sprint. 
            michaelneale Michael Neale made changes -
            Rank Ranked lower
            imeredith Ivan Meredith made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            michaelneale Michael Neale made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            michaelneale Michael Neale added a comment -

            hanks justin there is a fix in review for this, but it uses a deprecated API so trying to get the bottom of that... 

            Show
            michaelneale Michael Neale added a comment - hanks justin there is a fix in review for this, but it uses a deprecated API so trying to get the bottom of that... 
            Hide
            michaelneale Michael Neale added a comment -

            I am not able to reproduce the setup with the instructions, I can't get classic to accept submitting in any case given, and not sure what matrix settings to use. 

            Show
            michaelneale Michael Neale added a comment - I am not able to reproduce the setup with the instructions, I can't get classic to accept submitting in any case given, and not sure what matrix settings to use. 
            Hide
            hanks hanks justin added a comment -

            Michael Neale Thank you for your quick job, Seems there should be no space in submitter settings like below
            submitter: "A,B,C"
            the classic UI

            Show
            hanks hanks justin added a comment - Michael Neale Thank you for your quick job, Seems there should be no space in submitter settings like below submitter: "A,B,C" the classic UI
            jamesdumay James Dumay made changes -
            Description *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error. Due to JENKINS-42920 the user will not receive feedback on why they are not allowed to proceed or any other error, which made this problem more confusing.

            To run these scenarios you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice, bob"
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error. Due to JENKINS-42920 the user will not receive feedback on why they are not allowed to proceed or any other error, which made this problem more confusing.

            To run these scenarios you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            }
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice, bob"
            }
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            jamesdumay James Dumay made changes -
            Description *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error. Due to JENKINS-42920 the user will not receive feedback on why they are not allowed to proceed or any other error, which made this problem more confusing.

            To run these scenarios you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            }
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice, bob"
            }
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error. Due to JENKINS-42920 the user will not receive feedback on why they are not allowed to proceed or any other error, which made this problem more confusing.

            To run these scenarios you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            }
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice,bob"
            }
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            jamesdumay James Dumay made changes -
            Description *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error. Due to JENKINS-42920 the user will not receive feedback on why they are not allowed to proceed or any other error, which made this problem more confusing.

            To run these scenarios you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            }
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice,bob"
            }
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A, B, C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            *Notes*
            This will work when there is a single approver specified but not when there are multiple. Blue Ocean will respond with a 400 error. Due to JENKINS-42920 the user will not receive feedback on why they are not allowed to proceed or any other error, which made this problem more confusing.

            To run these scenarios you will need two users - 'alice' and 'bob'.

            *Scenario 1 - current user is 'alice', single approver*
            This works fine in Blue Ocean
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice"
            }
            {code}

            *Scenario 2 - current user is 'alice', multiple approvers*
            {code}
            node {
                echo 'hello world'
                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "alice,bob"
            }
            {code}


            *Original request*
            I use input step like below:
            {code}
            timeout(time: 5, unit: "DAYS") \{

                input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "A,B,C"

            }
            {code}

            can not use multi submitter in Blue Ocean UI, but it works fine in the old UI.
            Hide
            michaelneale Michael Neale added a comment -

            hanks justin that is the opposite to what Ivan Meredith saw though - so I am not sure what is going on. In my case - I can't even get classic to work with this, so not sure what is going on. 

            Show
            michaelneale Michael Neale added a comment - hanks justin that is the opposite to what Ivan Meredith saw though - so I am not sure what is going on. In my case - I can't even get classic to work with this, so not sure what is going on. 
            michaelneale Michael Neale made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            michaelneale Michael Neale added a comment -

            should be in next release shortly...

            Show
            michaelneale Michael Neale added a comment - should be in next release shortly...
            Hide
            hanks hanks justin added a comment -

            Thanks!

            Show
            hanks hanks justin added a comment - Thanks!
            michaelneale Michael Neale made changes -
            Remote Link This issue links to "Wiki Page (Jenkins Wiki)" [ 15837 ]
            jbriden Jenn Briden made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                imeredith Ivan Meredith
                Reporter:
                hanks hanks justin
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: