Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42920

Developer should see error message for failed input step

    Details

    • Similar Issues:
    • Sprint:
      Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2, Blue Ocean 1.4 - beta 5

      Description

      Context
      If a input step cannot proceed when approving input an error message is returned from the API but not displayed to the user.

      Scope
      Show a form error message if we cannot proceed the input.

      Example

      Jenkinsfile

      node {
          echo 'hello world'
          input message: "Do you want to approve this job to deploy to production?", ok: "OK", submitter: "admin, B, C"
      }
      

      Response

      {
        "message" : "You need to be admin, B, C to submit this",
        "code" : 400,
        "errors" : [ ]
      }
      

        Attachments

          Issue Links

            Activity

            jamesdumay James Dumay created issue -
            jamesdumay James Dumay made changes -
            Field Original Value New Value
            Epic Link JENKINS-38490 [ 174672 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Link This issue relates to JENKINS-42872 [ JENKINS-42872 ]
            jamesdumay James Dumay made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            jamesdumay James Dumay made changes -
            Issue Type Story [ 10002 ] Bug [ 1 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            michaelneale Michael Neale made changes -
            Sprint Blue Ocean 1.1 [ 271 ] Blue Ocean 1.0-rc2 [ 261 ]
            michaelneale Michael Neale made changes -
            Rank Ranked lower
            Hide
            michaelneale Michael Neale added a comment -

            Hey Ivan - could be a quick win (but not strictly critical for 1.0)

            Show
            michaelneale Michael Neale added a comment - Hey Ivan - could be a quick win (but not strictly critical for 1.0)
            michaelneale Michael Neale made changes -
            Assignee Ivan Meredith [ imeredith ]
            Hide
            michaelneale Michael Neale added a comment -

            Perhaps we should have a general error handler? 

             

            Or in this case it is specific enough around permissions we want it specific to this screen. 

            Show
            michaelneale Michael Neale added a comment - Perhaps we should have a general error handler?    Or in this case it is specific enough around permissions we want it specific to this screen. 
            michaelneale Michael Neale made changes -
            Link This issue relates to JENKINS-42921 [ JENKINS-42921 ]
            imeredith Ivan Meredith made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            imeredith Ivan Meredith made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            michaelneale Michael Neale made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3 [ 261 ] Blue Ocean 1.0-rc3, Blue Ocean 1.0-rc4 [ 261, 281 ]
            michaelneale Michael Neale made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.0-rc4 [ 261, 281 ] Blue Ocean 1.0-rc3 [ 261 ]
            michaelneale Michael Neale made changes -
            Sprint Blue Ocean 1.0-rc3 [ 261 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 271 ]
            michaelneale Michael Neale made changes -
            Rank Ranked higher
            Hide
            jamesdumay James Dumay added a comment -

            Can we do a generic catch all for errors? Displaying the log would be fine in this case.

            Show
            jamesdumay James Dumay added a comment - Can we do a generic catch all for errors? Displaying the log would be fine in this case.
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 271 ] Blue Ocean 1.0-rc3, Blue Ocean - techdebt sprint 1 [ 261, 291 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean - techdebt sprint 1 [ 261, 291 ] Blue Ocean 1.0-rc3 [ 261 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3 [ 261 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 271 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Assignee Ivan Meredith [ imeredith ]
            jamesdumay James Dumay made changes -
            Labels pipeline-improvement
            jamesdumay James Dumay made changes -
            Epic Link JENKINS-38490 [ 174672 ] JENKINS-43952 [ 181484 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 271 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1-beta5 [ 261, 321 ]
            jamesdumay James Dumay made changes -
            Assignee Nicolae Pascu [ nicu ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1 [ 261, 321 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1 [ 261, 321, 331 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1 [ 261, 321, 331 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1 [ 261, 321, 331, 336 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1 [ 261, 321, 331, 336 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2 [ 261, 321, 331, 336, 341 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2 [ 261, 321, 331, 336, 341 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3 [ 261, 321, 331, 336, 341, 346 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3 [ 261, 321, 331, 336, 341, 346 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4 [ 261, 321, 331, 336, 341, 346, 361 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4 [ 261, 321, 331, 336, 341, 346, 361 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3 [ 261, 321, 326, 331, 336, 341, 346 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Assignee Nicolae Pascu [ nicu ] Josh McDonald [ sophistifunk ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.2, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3 [ 261, 321, 326, 331, 336, 341, 346 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta5 [ 261, 321, 331, 336, 341, 346, 376 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2 [ 261, 321, 331, 336, 341, 346, 376 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3 - beta 1 [ 261, 321, 331, 336, 341, 346, 376, 386 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3 [ 261, 321, 331, 336, 341, 346, 376, 386 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1 [ 261, 321, 331, 336, 341, 346, 376, 386, 401 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1 [ 261, 321, 331, 336, 341, 346, 376, 386, 401 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 2 [ 261, 321, 331, 336, 341, 346, 376, 386, 401, 426 ]
            jamesdumay James Dumay made changes -
            Assignee Josh McDonald [ sophistifunk ] Nicolae Pascu [ nicu ]
            Hide
            kshultz Karl Shultz added a comment -

            Testing Notes:

            • Depends on final implementation.
            • If we take the approach of making this specific to job permissions, tests should be created which verify the correct message is presented at the correct time
            Show
            kshultz Karl Shultz added a comment - Testing Notes: Depends on final implementation. If we take the approach of making this specific to job permissions, tests should be created which verify the correct message is presented at the correct time
            kshultz Karl Shultz made changes -
            Labels pipeline-improvement pipeline-improvement testing-notes-reviewed
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 2 [ 261, 321, 331, 336, 341, 346, 376, 386, 401, 426 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2 [ 261, 321, 331, 336, 341, 346, 376, 386, 401, 416, 426 ]
            michaelneale Michael Neale made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            jamesdumay James Dumay added a comment -

            Nicolae Pascu it might be worth grabbing Ivan Meredith for a quick hangout to discuss what to do about this one.

            Ivan Meredith if the input proceed fails, we should get a error back in the JSON with why the input could not be submitted. At the moment it looks like the Input plugin is redirecting to some classic page, so the AJAX response is HTML.

            Show
            jamesdumay James Dumay added a comment - Nicolae Pascu it might be worth grabbing Ivan Meredith for a quick hangout to discuss what to do about this one. Ivan Meredith if the input proceed fails, we should get a error back in the JSON with why the input could not be submitted. At the moment it looks like the Input plugin is redirecting to some classic page, so the AJAX response is HTML.
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "CloudBees Internal UX-576 (Web Link)" [ 18216 ]
            nicu Nicolae Pascu made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2 [ 261, 321, 331, 336, 341, 346, 376, 386, 401, 416, 426 ] Blue Ocean 1.0-rc3, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.2-beta2, Blue Ocean 1.2-beta3, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2, Blue Ocean 1.4 - beta 5 [ 261, 321, 331, 336, 341, 346, 376, 386, 401, 416, 426, 451 ]
            nicu Nicolae Pascu made changes -
            Status In Review [ 10005 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            nicu Nicolae Pascu made changes -
            Remote Link This issue links to "#1597 (Web Link)" [ 19824 ]
            michaelneale Michael Neale made changes -
            Remote Link This issue links to "Page (Jenkins Wiki)" [ 19840 ]
            zometer Chris Spears made changes -
            Rank Ranked lower

              People

              • Assignee:
                nicu Nicolae Pascu
                Reporter:
                jamesdumay James Dumay
              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: