Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42969

Computer.addAction will throw UnsupportedOperationException

    Details

    • Similar Issues:

      Description

      The fix of JENKINS-39555 (in 2.30) reverted some of the code introduced in JENKINS-39404, to fix some regressions there. Unfortunately it failed to revert one of the simplifications that was legitimately made in JENKINS-39404 to code originally introduced in JENKINS-18224: so now Computer.addAction is again inherited from Actionable, but will not work since getActions is an immutable list.

      Probably no one noticed this before because no one was trying to call Computer.addAction, but Evaristo Gutierrez noticed that yesterday's security release of ssh-slaves by Michael Clarke introduced code which does, and which causes a failure in TrustHostKeyActionTest.testSubmitNotAuthorised when run against 2.32.3:

      java.lang.UnsupportedOperationException
      	at java.util.Collections$UnmodifiableCollection.add(Collections.java:1055)
      	at hudson.model.Actionable.addAction(Actionable.java:134)
      	at hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy.verify(ManuallyTrustedKeyVerificationStrategy.java:70)
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: