Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43138

Webhook events don't get properly processed when instance is experiencing rate limits

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When ci.jenkins.io hits rate limits (which it still does), API requests slow down which is an improvement, but it appears that inbound webhooks don't get properly processed.

      The following is a Repository Events log. Note that the pull request in question most certainly has a

      {Jenkinsfile}

      associated with it.

      org.jenkinsci.plugins.github_branch_source.PushGHEventSubscriber$SCMHeadEventImpl UPDATED event from 192.30.252.41 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Mon Mar 27 16:21:39 UTC 2017 processed in 0.4 sec
          Checking branch master
            ‘Jenkinsfile’ found
          Met criteria
      No changes detected: master (still at f8f20c8e94d1e41eb96fcde019b6bc9ee98d9743)
      
        0 branches were processed (query completed)
      
      Done examining jenkins-infra/jenkins.io
      
      [Mon Mar 27 16:21:45 UTC 2017] org.jenkinsci.plugins.github_branch_source.PushGHEventSubscriber$SCMHeadEventImpl UPDATED event from 192.30.252.40 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Mon Mar 27 16:21:40 UTC 2017 processed in 0.41 sec
      [Mon Mar 27 16:51:05 UTC 2017] Received org.jenkinsci.plugins.github_branch_source.PullRequestGHEventSubscriber$SCMHeadEventImpl CREATED event from 192.30.252.42 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Mon Mar 27 16:51:00 UTC 2017
      [Mon Mar 27 16:51:05 UTC 2017] Received org.jenkinsci.plugins.github_branch_source.PullRequestGHEventSubscriber$SCMHeadEventImpl CREATED event from 192.30.252.41 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Mon Mar 27 16:51:00 UTC 2017
      16:51:05 Connecting to https://api.github.com using jenkinsadmin/****** (GitHub access token for jenkinsadmin)
      Looking up jenkins-infra/jenkins.io
      
        Getting remote pull request #781...
      
      16:51:05 Connecting to https://api.github.com using jenkinsadmin/****** (GitHub access token for jenkinsadmin)
      Looking up jenkins-infra/jenkins.io
      
        Getting remote pull request #781...
      
          Checking pull request #781
          Job name: PR-781
            ‘Jenkinsfile’ not found
          Does not meet criteria
      
        1 pull requests were processed
      
      Done examining jenkins-infra/jenkins.io
      
      [Mon Mar 27 16:51:06 UTC 2017] org.jenkinsci.plugins.github_branch_source.PullRequestGHEventSubscriber$SCMHeadEventImpl CREATED event from 192.30.252.41 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Mon Mar 27 16:51:00 UTC 2017 processed in 0.74 sec
          Checking pull request #781
          Job name: PR-781
            ‘Jenkinsfile’ not found
          Does not meet criteria
      
        1 pull requests were processed
      
      Done examining jenkins-infra/jenkins.io
      
      [Mon Mar 27 16:51:06 UTC 2017] org.jenkinsci.plugins.github_branch_source.PullRequestGHEventSubscriber$SCMHeadEventImpl CREATED event from 192.30.252.42 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Mon Mar 27 16:51:00 UTC 2017 processed in 0.83 sec
      
      

      Based on my observations it looks like event handling isn't queued for after the rate limit opens back up, so there's a gap in scanning the repository resulting in the "Does not meet criteria" above.

        Attachments

          Issue Links

            Activity

            Hide
            recampbell Ryan Campbell added a comment -

            R. Tyler Croy, are you still seeing this on the latest versions?

            Show
            recampbell Ryan Campbell added a comment - R. Tyler Croy , are you still seeing this on the latest versions?
            Hide
            rtyler R. Tyler Croy added a comment -

            No, I don't believe I have seen this recently

            Show
            rtyler R. Tyler Croy added a comment - No, I don't believe I have seen this recently
            Hide
            jamesdumay James Dumay added a comment -

            If this comes back R. Tyler Croy give me a yell and Ill see what I can do.

            Show
            jamesdumay James Dumay added a comment - If this comes back R. Tyler Croy give me a yell and Ill see what I can do.

              People

              • Assignee:
                Unassigned
                Reporter:
                rtyler R. Tyler Croy
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: