Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43194

Lightweight checkout for PR merge jobs

    Details

    • Sprint:
      Blue Ocean 1.4 - beta 2
    • Similar Issues:

      Description

      Please pull in the changes made to the SCM API to reduce the number of checkouts required for pipelines. Related to JENKINS-33273

       

      There was a mention in the referenced issue about PRs needing special treatment: "there is no implementation currently for github-branch-source-plugin in the case of a PR job configured to merge with the base branch, as GitHub does not offer an API dedicated to this purpose. In the case that the merge can be assumed to be a fast-forward (there is no base branch change subsequent to the common ancestor), this plugin could in principle load content via API from the PR branch; it would still need to fall back to full checkout and Git merge otherwise." - https://issues.jenkins-ci.org/browse/JENKINS-33273?focusedCommentId=292273#comment-292273

        Attachments

          Issue Links

            Activity

            Hide
            bitwiseman Liam Newman added a comment - - edited

            Jesse Glick

            We cannot use merge_commit_sha from this plugin. Just forget it exists.

            Why? I need to understand why this is not possible. I don't need you to spoon feed it to me but I do need more information than you've provided.

            The suggestion that we should fail and make the user bring their PR up-to-date is an interesting one. I'll add that to the list of options.

            Show
            bitwiseman Liam Newman added a comment - - edited Jesse Glick We cannot use merge_commit_sha from this plugin. Just forget it exists. Why? I need to understand why this is not possible. I don't need you to spoon feed it to me but I do need more information than you've provided. The suggestion that we should fail and make the user bring their PR up-to-date is an interesting one. I'll add that to the list of options.
            Hide
            bitwiseman Liam Newman added a comment -

            I've released a beta release of this change in v2.4.6-beta-1:

            This is not production ready but anyone wanting to test it and give feedback would be appreciated. It is on the experimental update site.
            Also: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/github-branch-source/2.4.6-beta-1/github-branch-source-2.4.6-beta-1.hpi

            Show
            bitwiseman Liam Newman added a comment - I've released a beta release of this change in v2.4.6-beta-1: This is not production ready but anyone wanting to test it and give feedback would be appreciated. It is on the experimental update site. Also: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/github-branch-source/2.4.6-beta-1/github-branch-source-2.4.6-beta-1.hpi
            Hide
            bitwiseman Liam Newman added a comment -

            Released in v2.5.0.

            Show
            bitwiseman Liam Newman added a comment - Released in v2.5.0.
            Hide
            silverorange James F. added a comment -

            I have been experiencing problems since the most recent update of this plugin to 2.5.0.  I'm running the latest Jenkins with all plugins updated.  After updating from 2.4.5 of this plugin to 2.5.0 my tests are failing with the following error.  As soon as I roll the plugin back to 2.4.5 the tests being passing again.  Anyone have any idea what might be causing this?

             

            Caused: org.kohsuke.github.GHFileNotFoundException:

            {"message":"No commit found for SHA: xxxxxxxxxxxxxxdc556f036","documentation_url":"[https://developer.github.com/v3/repos/commits/#get-a-single-commit]"}
            Show
            silverorange James F. added a comment - I have been experiencing problems since the most recent update of this plugin to 2.5.0.  I'm running the latest Jenkins with all plugins updated.  After updating from 2.4.5 of this plugin to 2.5.0 my tests are failing with the following error.  As soon as I roll the plugin back to 2.4.5 the tests being passing again.  Anyone have any idea what might be causing this?   Caused: org.kohsuke.github.GHFileNotFoundException: {"message":"No commit found for SHA: xxxxxxxxxxxxxxdc556f036","documentation_url":"[https://developer.github.com/v3/repos/commits/#get-a-single-commit]"}
            Hide
            bitwiseman Liam Newman added a comment -

            James F.
            Please open a new issue with more details including callstacks.
            As a work around please try closing and reopening the PR that is causing the failure.

            Show
            bitwiseman Liam Newman added a comment - James F. Please open a new issue with more details including callstacks. As a work around please try closing and reopening the PR that is causing the failure.

              People

              • Assignee:
                bitwiseman Liam Newman
                Reporter:
                maxpowa Max Gurela
              • Votes:
                11 Vote for this issue
                Watchers:
                21 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: