Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43195

non-relocated "com.github.fge.jsonschema" classes can cause issues elsewhere

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      We don't relocate "com.github.fge.jsonschema.*" but probably should - not relocating them means anyone else trying to depend on a different version of the library gets hosed, and anyone trying to depend on that version ends up with weird relocated Jackson APIs. So...we should relocate this too.

        Attachments

          Issue Links

            Activity

            Show
            abayer Andrew Bayer added a comment - Easy PR up at  https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/148
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ASTSchema.java
            pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/Converter.groovy
            pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy
            pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/JSONErrorCollector.groovy
            pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/endpoints/ModelConverterAction.java
            pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BaseParserLoaderTest.java
            pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/JSONSchemaTest.java
            pipeline-model-json-shaded/pom.xml
            http://jenkins-ci.org/commit/pipeline-model-definition-plugin/fa56a4c2b5290e77dddd3cd828744dfdc1697c80
            Log:
            [FIXED JENKINS-43195] Relocate shaded com.github.fge.*

            Avoids polluting classloaders for other uses.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ASTSchema.java pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/Converter.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/JSONErrorCollector.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/endpoints/ModelConverterAction.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BaseParserLoaderTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/JSONSchemaTest.java pipeline-model-json-shaded/pom.xml http://jenkins-ci.org/commit/pipeline-model-definition-plugin/fa56a4c2b5290e77dddd3cd828744dfdc1697c80 Log: [FIXED JENKINS-43195] Relocate shaded com.github.fge.* Avoids polluting classloaders for other uses.

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                abayer Andrew Bayer
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: