Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43211

Remove unneeded dependencies (markdown, redux)

    Details

    • Epic Link:
    • Sprint:
      Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2, Blue Ocean 1.4 - beta 5
    • Similar Issues:

      Description

      Once karaoke has moved off redux, and personalisation, redux may be removed as a dependency saving download and eval time. 

      Ditty for markdown (which Cliff Meyers mentioned may not be needed now with the new empty states, but correct me if wrong). 

      Well worth trimming things we know aren't needed. 

        Attachments

          Issue Links

            Activity

            Hide
            cliffmeyers Cliff Meyers added a comment -

            To eliminate redux, following areas need to be ported:

            • blueocean-personalization (full module)
            • blueocean-web (all bootstrapping code for stores, middleware, etc)
            • blueocean-dashboard
              • Dashboard
              • TestResults
              • various tests / specs

            To eliminate "react-remarkable", following areas need porting:

            • All remaining empty states (at present, only for RunDetailsArtifacts)
            • ParametersRunButton
            • inputStep
            Show
            cliffmeyers Cliff Meyers added a comment - To eliminate redux, following areas need to be ported: blueocean-personalization (full module) blueocean-web (all bootstrapping code for stores, middleware, etc) blueocean-dashboard Dashboard TestResults various tests / specs To eliminate "react-remarkable", following areas need porting: All remaining empty states (at present, only for RunDetailsArtifacts) ParametersRunButton inputStep
            Hide
            michaelneale Michael Neale added a comment -

            Cliff Meyers so based on that - my finger int he air guess is probably a good few days solid work to a week to flush it all out? If so - no hurry for this as "minor". Low cost-benefit return. 

            Show
            michaelneale Michael Neale added a comment - Cliff Meyers so based on that - my finger int he air guess is probably a good few days solid work to a week to flush it all out? If so - no hurry for this as "minor". Low cost-benefit return. 
            Hide
            cliffmeyers Cliff Meyers added a comment -

            Since I am likely to add a new dep in JENKINS-38323 I think it's time to remove some old ones

            Show
            cliffmeyers Cliff Meyers added a comment - Since I am likely to add a new dep in JENKINS-38323 I think it's time to remove some old ones
            Hide
            cliffmeyers Cliff Meyers added a comment -

            Added link to WIP PR.

            Show
            cliffmeyers Cliff Meyers added a comment - Added link to WIP PR.
            Hide
            cliffmeyers Cliff Meyers added a comment -

            This work was completed and ran fine locally but causes 100% failure of ATH in CI (but only in CI). This is effectively on-hold for now, refer to comments in PR for details.

            Show
            cliffmeyers Cliff Meyers added a comment - This work was completed and ran fine locally but causes 100% failure of ATH in CI (but only in CI). This is effectively on-hold for now, refer to comments in PR for details.
            Hide
            kshultz Karl Shultz added a comment -

            Testing Notes:

            • There are already new tests in the PR, which are being run and discussed
            • Automated testing is already catching problems that this change might introduce, which is great.
            Show
            kshultz Karl Shultz added a comment - Testing Notes: There are already new tests in the PR, which are being run and discussed Automated testing is already catching problems that this change might introduce, which is great.
            Hide
            cliffmeyers Cliff Meyers added a comment -

            Added link to the new / latest PR that should allow this be merged: https://github.com/jenkinsci/blueocean-plugin/pull/1627

            Show
            cliffmeyers Cliff Meyers added a comment - Added link to the new / latest PR that should allow this be merged: https://github.com/jenkinsci/blueocean-plugin/pull/1627

              People

              • Assignee:
                cliffmeyers Cliff Meyers
                Reporter:
                michaelneale Michael Neale
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: