Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43507

Allow SCMSource and SCMNavigator subtypes to share common traits

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Examples of traits from the JENKINS-43426 epic:

      • There will be a strategy to use switch the checkout to over SSH and this will have a option to select the SSH Credentials for checkout.
      • There will be at least one strategy to subset the branches by name (include / exclude)
        • There will one implementation that uses the existing wildcard style
        • Other strategies may be added later to support different branch name matching rules, e.g. Regex, etc. These secondary strategies do not form part of the MVP but it may prove assist extension point API validation to proof-of-concept implement a second one.
      • There will be three strategies to subset the branches by type:
        • There will be a strategy to select origin branches. This strategy will have a drop-down mode selection:
          • Only origin branches that are not filed as PRs
          • Only origin branches that are filed as PRs
          • All origin branches irrespective of whether filed as PR or not
        • There will be a strategy to select origin PRs. This strategy will have a drop-down mode selection:
          • Merge commit PRs
          • Head commit PRs
          • Both merge commit and head commit PRs
        • There will be a strategy to select fork PRs. This strategy will have a drop-down mode selection:
          • Merge commit PRs
          • Head commit PRs
          • Both merge commit and head commit PRs
      • There will also be a drop-down for trust selection:
          • Show all fork PRs but only trust fork PRs from repository contributors
          • Only show PRs from repository contributors
          • Show and trust all fork PRs
             TBD determine if we need to expose suppression of automatic builds of untrusted PRs here.
        • There will be a proof-of-concept implementation of a tag support branch selector. This is not a feature experienced by users today, but there are api's & code which is ready to provide it. We won't ship this enabled by default in the release.
      • There will be the ability to control a subset of the Git plugin’s additional behaviours for the generated SCM of branches. This will be an applies to all setting. The available options will be subject to a whitelisting extension point (so that plugins can define additional Git behaviours and whitelist them in at the same time). The default whitelist will be:
        • Advanced Checkout behaviours
        • Advanced Clone behaviours
        • Advanced Submodule behaviours
        • Clean after checkout
        • Clean before checkout
        • Custom user name / email address
        • Git LFS pull after checkout
        • Use commit author in changelog (says it requires workspace polling, but really does not / should not require workspace polling)
        • Wipe out repository & force clone

      Acceptance criteria

      • The SCM API provides the concept of a trait that applies to SCMSource and SCMNavigator
      • Traits will be opt-in, i.e. the SCMSource implementation must be written to use traits
      • Common trait implementations can be shared by multiple implementations.
      • Trait implementations can be specific to a single SCMSource or SCMNavigator
      • The SCM API will provide a trait implementation that allows for filtering branches based on include/exclude wildcard name matching
      • The SCM API MockSCM implementation will support traits
      • The common trait implementations in SCM API will have tests
      • The implementers guide will be updated to highlight the trait style of implementation and encourage following that path. 

        Attachments

          Issue Links

            Activity

            stephenconnolly Stephen Connolly created issue -
            stephenconnolly Stephen Connolly made changes -
            Field Original Value New Value
            Epic Link JENKINS-43426 [ 180671 ]
            stephenconnolly Stephen Connolly made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue is blocking JENKINS-43418 [ JENKINS-43418 ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue is duplicated by JENKINS-43348 [ JENKINS-43348 ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue is duplicated by JENKINS-31552 [ JENKINS-31552 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-43348 [ JENKINS-43348 ]
            jamesdumay James Dumay made changes -
            Link This issue blocks JENKINS-43348 [ JENKINS-43348 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-39392 [ JENKINS-39392 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-36283 [ JENKINS-36283 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-33739 [ JENKINS-33739 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-33531 [ JENKINS-33531 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-37706 [ JENKINS-37706 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-40475 [ JENKINS-40475 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-42657 [ JENKINS-42657 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-33701 [ JENKINS-33701 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-44618 [ JENKINS-44618 ]
            jamesdumay James Dumay made changes -
            Labels cloudbees-internal-pipeline
            stephenconnolly Stephen Connolly made changes -
            Link This issue relates to JENKINS-39982 [ JENKINS-39982 ]
            stephenconnolly Stephen Connolly made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue is duplicated by JENKINS-37658 [ JENKINS-37658 ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-39982 [ JENKINS-39982 ]
            stephenconnolly Stephen Connolly made changes -
            Attachment before-adding-advanced.png [ 38977 ]
            stephenconnolly Stephen Connolly made changes -
            Attachment advanced.png [ 38978 ]
            stephenconnolly Stephen Connolly made changes -
            Attachment after-adding-advanced.png [ 38979 ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue is duplicated by JENKINS-42947 [ JENKINS-42947 ]
            gregcovertsmith Greg Smith made changes -
            Assignee Stephen Connolly [ stephenconnolly ] Greg Smith [ gregcovertsmith ]
            stephenconnolly Stephen Connolly made changes -
            stephenconnolly Stephen Connolly made changes -
            Assignee Greg Smith [ gregcovertsmith ] Stephen Connolly [ stephenconnolly ]
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-45806 [ JENKINS-45806 ]

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                4 Vote for this issue
                Watchers:
                20 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: