Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43538

Display URL API plugin should not have mandatory dependency on the JUnit plugin

    Details

    • Similar Issues:
    • Epic Link:

      Description

      JUnit plugin is not an API plugin. It contributes logic like Publishers and UI. So any plugin developer adding dependency on this "API plugin" gets more stuff then he would expect.

      IMHO it is critical for API plugin, and now the fixing is more complicated due to the Blue Ocean 1.0 release.But it still requires a Fix (e.g. decoupling of "Test API Plugin" from JUnit or just a logic cleanup in order to make the dependency optional) . CC James Dumay

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James William Dumay
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/displayurlapi/ClassicDisplayURLProvider.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java
          src/main/java/org/jenkinsci/plugins/displayurlapi/actions/RunDisplayAction.java
          src/test/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProviderTest.java
          src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectEligibilityTest.java
          src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectExtendedTest.java
          http://jenkins-ci.org/commit/display-url-api-plugin/c45806f45c16b51af889e0de40e185710460a0e5
          Log:
          JENKINS-43538 API change: remove getTestUrl (#13)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: pom.xml src/main/java/org/jenkinsci/plugins/displayurlapi/ClassicDisplayURLProvider.java src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java src/main/java/org/jenkinsci/plugins/displayurlapi/actions/RunDisplayAction.java src/test/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProviderTest.java src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectEligibilityTest.java src/test/java/org/jenkinsci/plugins/displayurlapi/actions/ActionRedirectExtendedTest.java http://jenkins-ci.org/commit/display-url-api-plugin/c45806f45c16b51af889e0de40e185710460a0e5 Log: JENKINS-43538 API change: remove getTestUrl (#13)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James William Dumay
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java
          http://jenkins-ci.org/commit/blueocean-display-url-plugin/9283b505e5825aa6709f364ef28b43b41f096dd7
          Log:
          JENKINS-43538 API change: remove getTestUrl (#5)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: pom.xml src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java http://jenkins-ci.org/commit/blueocean-display-url-plugin/9283b505e5825aa6709f364ef28b43b41f096dd7 Log: JENKINS-43538 API change: remove getTestUrl (#5)
          Hide
          jamesdumay James Dumay added a comment -

          Oleg Nenashev JUnit plugin committers if we want to split hairs. Almost everyone in that thread had committed significantly to the plugin or was responsible for pulling that code out of core.

          Show
          jamesdumay James Dumay added a comment - Oleg Nenashev JUnit plugin committers if we want to split hairs. Almost everyone in that thread had committed significantly to the plugin or was responsible for pulling that code out of core.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James William Dumay
          Path:
          http://jenkins-ci.org/commit/display-url-api-plugin/6c454a69f18e5c31fa256b0880618f318e658fd8
          Log:
          Topic/remove junit dependency (#14)

          • Set version to 2.0
          • [maven-release-plugin] prepare release display-url-api-2.0
          • [maven-release-plugin] prepare for next development iteration
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: http://jenkins-ci.org/commit/display-url-api-plugin/6c454a69f18e5c31fa256b0880618f318e658fd8 Log: Topic/remove junit dependency (#14) JENKINS-43538 API change: remove getTestUrl Set version to 2.0 [maven-release-plugin] prepare release display-url-api-2.0 [maven-release-plugin] prepare for next development iteration
          Hide
          stevenfoster Steven Foster added a comment -

          Are there any plans to restore this functionality (if in a more suitable way?) I've found the API seems incomplete without it, there are a couple cases where it's been missing for things I'm working on.

          Show
          stevenfoster Steven Foster added a comment - Are there any plans to restore this functionality (if in a more suitable way?) I've found the API seems incomplete without it, there are a couple cases where it's been missing for things I'm working on.

            People

            • Assignee:
              jamesdumay James Dumay
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: