Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43825

Improve propagation of issues in ProcessTree.Windows

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      This is a requirement for better error handling in JENKINS-30782.

      Build termination uses environment variables to determine which processes need to be aborted. OSProcess API provides getEnvironmentVariables(), which does not support propagating exceptions to upper levels. But we need it for issues which may happen in WinP. hasMatchingEnvVars() is final on the OSProcess level, hence there is no way to reliably propagate issues.

      New API needs to be implemented in order to allow propagating exceptions, at least for Windows processes

        Attachments

          Issue Links

            Activity

            Show
            oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/jenkins/pull/2859
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/util/ProcessTree.java
            http://jenkins-ci.org/commit/jenkins/1899f36bfc372ec9b2ee536d3630ea5246e4570f
            Log:
            JENKINS-43825 - Refactor ProcessTree.Windows logic to propagate errors correctly (#2859)

            • JENKINS-43825 - Refactor WindowsProcess to a separate class and optimize logging
            • JENKINS-43825 - Refactor the code to properly propagate WindowsProcessException in ProcessTree to the top level
            • JENKINS-43825 - Next time I will try to compile the code before submitting
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/util/ProcessTree.java http://jenkins-ci.org/commit/jenkins/1899f36bfc372ec9b2ee536d3630ea5246e4570f Log: JENKINS-43825 - Refactor ProcessTree.Windows logic to propagate errors correctly (#2859) JENKINS-43825 - Refactor WindowsProcess to a separate class and optimize logging JENKINS-43825 - Refactor the code to properly propagate WindowsProcessException in ProcessTree to the top level JENKINS-43825 - Polish logging JENKINS-43828 - s/WindowsProcess/WindowsOSProcess JENKINS-43825 - Next time I will try to compile the code before submitting
            Hide
            danielbeck Daniel Beck added a comment -

            In 2.58.

            Show
            danielbeck Daniel Beck added a comment - In 2.58.

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: